chromium/src
0
Fork 0
Code Activity

Remove/replace unnecessary logging.h includes in .cc files (pdf)

Browse Source 
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved
to the much smaller headers check.h, check_op.h, and notreached.h,
respectively.

This CL updates .cc files to use those headers instead when
possible, with the purpose of saving compile time.

(Split out from https://crrev.com/c/2164525 which also has
notes on how the change was generated.)

Bug: 1031540
Change-Id: Ia89f8dd8a7ca818e539d4be41556e247e9849017
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164637
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763916}
This commit is contained in:
Hans Wennborg
2020-04-29 18:26:46 +00:00
committed by Commit Bot
parent fe097a691b
commit 5078d10ac4
21 changed files with 23 additions and 21 deletions

2
pdf/document_layout.cc

@ -6,7 +6,7 @@
#include <algorithm>
#include "base/logging.h"
#include "base/check_op.h"
#include "ppapi/cpp/rect.h"
#include "ppapi/cpp/size.h"
#include "ppapi/cpp/var.h"

3
pdf/document_loader_impl.cc

@ -10,7 +10,8 @@
#include <algorithm>
#include <utility>
#include "base/logging.h"
#include "base/check_op.h"
#include "base/notreached.h"
#include "base/numerics/safe_math.h"
#include "base/strings/string_util.h"
#include "pdf/url_loader_wrapper.h"

2
pdf/document_loader_impl_unittest.cc

@ -9,7 +9,7 @@
#include <string>
#include <vector>
#include "base/logging.h"
#include "base/check.h"
#include "pdf/url_loader_wrapper.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"

2
pdf/draw_utils/coordinates.cc

@ -7,7 +7,7 @@
#include <math.h>
#include <algorithm>
#include "base/logging.h"
#include "base/check_op.h"
#include "ppapi/cpp/point.h"
namespace chrome_pdf {

2
pdf/draw_utils/shadow.cc

@ -9,7 +9,7 @@
#include <algorithm>
#include "base/logging.h"
#include "base/check_op.h"
#include "ppapi/cpp/image_data.h"
#include "ppapi/cpp/rect.h"

2
pdf/paint_aggregator.cc

@ -9,7 +9,7 @@
#include <algorithm>
#include "base/logging.h"
#include "base/check.h"
namespace {

2
pdf/paint_manager.cc

@ -10,7 +10,7 @@
#include <algorithm>
#include "base/auto_reset.h"
#include "base/logging.h"
#include "base/check_op.h"
#include "ppapi/c/pp_errors.h"
#include "ppapi/cpp/instance.h"
#include "ppapi/cpp/module.h"

1
pdf/pdf.cc

@ -8,7 +8,6 @@
#include <utility>
#include "base/logging.h"
#include "base/macros.h"
#include "pdf/out_of_process_instance.h"
#include "pdf/pdf_ppapi.h"

2
pdf/pdf_transform.cc

@ -7,7 +7,7 @@
#include <algorithm>
#include <utility>
#include "base/logging.h"
#include "base/notreached.h"
#include "ui/gfx/geometry/point_f.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/size_f.h"

1
pdf/pdfium/fuzzers/pdfium_xfa_lpm_fuzzer/simple_xfa_pdf_unittest.cc

@ -7,7 +7,6 @@
#include <string>
#include <utility>
#include "base/logging.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {

2
pdf/pdfium/pdfium_api_string_buffer_adapter.cc

@ -8,7 +8,7 @@
#include <string>
#include "base/logging.h"
#include "base/check_op.h"
#include "base/strings/string16.h"
#include "base/strings/string_util.h"

2
pdf/pdfium/pdfium_document.cc

@ -6,7 +6,7 @@
#include <utility>
#include "base/logging.h"
#include "base/check.h"
#include "pdf/document_loader.h"
namespace chrome_pdf {

3
pdf/pdfium/pdfium_engine.cc

@ -16,8 +16,9 @@
#include "base/auto_reset.h"
#include "base/bind.h"
#include "base/check_op.h"
#include "base/feature_list.h"
#include "base/logging.h"
#include "base/notreached.h"
#include "base/stl_util.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"

2
pdf/pdfium/pdfium_font_linux.cc

@ -9,7 +9,7 @@
#include "base/i18n/encoding_detection.h"
#include "base/i18n/icu_string_conversions.h"
#include "base/logging.h"
#include "base/notreached.h"
#include "base/numerics/ranges.h"
#include "base/stl_util.h"
#include "base/strings/string_util.h"

3
pdf/pdfium/pdfium_page.cc

@ -11,8 +11,9 @@
#include <memory>
#include <utility>
#include "base/logging.h"
#include "base/check_op.h"
#include "base/metrics/histogram_functions.h"
#include "base/notreached.h"
#include "base/numerics/math_constants.h"
#include "base/numerics/safe_math.h"
#include "base/strings/string_number_conversions.h"

2
pdf/pdfium/pdfium_page_unittest.cc

@ -7,7 +7,7 @@
#include <utility>
#include <vector>
#include "base/logging.h"
#include "base/check.h"
#include "base/test/gtest_util.h"
#include "pdf/pdfium/pdfium_engine.h"
#include "pdf/pdfium/pdfium_test_base.h"

2
pdf/pdfium/pdfium_range.cc

@ -4,7 +4,7 @@
#include "pdf/pdfium/pdfium_range.h"
#include "base/logging.h"
#include "base/check_op.h"
#include "base/strings/string_util.h"
#include "pdf/pdfium/pdfium_api_string_buffer_adapter.h"

2
pdf/pdfium/pdfium_unsupported_features.cc

@ -4,7 +4,7 @@
#include "pdf/pdfium/pdfium_unsupported_features.h"
#include "base/logging.h"
#include "base/notreached.h"
#include "pdf/pdfium/pdfium_engine.h"
#include "third_party/pdfium/public/fpdf_ext.h"

2
pdf/preview_mode_client.cc

@ -6,7 +6,7 @@
#include <stdint.h>
#include "base/logging.h"
#include "base/notreached.h"
#include "pdf/document_layout.h"
namespace chrome_pdf {

3
pdf/test/test_document_loader.cc

@ -7,8 +7,9 @@
#include <stdint.h>
#include "base/base_paths.h"
#include "base/check_op.h"
#include "base/files/file_util.h"
#include "base/logging.h"
#include "base/notreached.h"
#include "base/path_service.h"
#include "pdf/range_set.h"
#include "pdf/url_loader_wrapper.h"

2
pdf/url_loader_wrapper_impl.cc

@ -7,7 +7,7 @@
#include <memory>
#include "base/bind.h"
#include "base/logging.h"
#include "base/check_op.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "net/http/http_util.h"