chromium/src
0
Fork 0
Code Activity

Closure Compiler: Add script to run compile and update Wiki docs.

Browse Source 
This patch adds a script to run the Closure Compile for Chrome resources. It also updates the wiki to reflect this.

BUG=596944

Review URL: https://codereview.chromium.org/1829553002

Cr-Commit-Position: refs/heads/master@{#383378}
This commit is contained in:
tommycli
2016-03-25 15:07:18 -07:00
committed by Commit bot
parent 12c8005e13
commit 521de10fba
4 changed files with 22 additions and 19 deletions

21
docs/closure_compilation.md

@ -15,17 +15,10 @@ On Mac or Windows, visit:
### Using ninja to compile the code
We use GYP and ninja as our build system. To generate the ninja files from GYP:
To compile the JavaScript, run this script:
```shell
# notice the 2 in compiled_resources2.gyp
GYP_GENERATORS=ninja tools/gyp/gyp --depth . third_party/closure_compiler/compiled_resources2.gyp
```
To compile the JavaScript:
```shell
ninja -C out/Default -j4
third_party/closure_compiler/run_compiler
```
The output should look something like this:
@ -35,16 +28,10 @@ ninja: Entering directory `out/Default/'
[30/106] ACTION Compiling chrome/browser/resources/md_history/constants.js
```
To generate and run the **deprecated** v1 gyp format, remove the "2" from "compiled_resources2.gyp":
To compile only a specific target, add an argument after the script name:
```shell
$ GYP_GENERATORS=ninja tools/gyp/gyp --depth . third_party/closure_compiler/compiled_resources.gyp
```
Compiling works the same way for both v1 and v2 systems:
```shell
ninja -C out/Default -j4
third_party/closure_compiler/run_compiler people_page
```
## Background

2
third_party/closure_compiler/compiled_resources.gyp vendored

@ -17,7 +17,7 @@
{
'targets': [
{
'target_name': 'compile_all_resources',
'target_name': 'compiled_resources',
'type': 'none',
'dependencies': [
'../../chrome/browser/resources/bookmark_manager/js/compiled_resources.gyp:*',

2
third_party/closure_compiler/compiled_resources2.gyp vendored

@ -11,7 +11,7 @@
{
'targets': [
{
'target_name': 'compile_all_resources',
'target_name': 'compiled_resources2',
'type': 'none',
'dependencies': [
'<(DEPTH)/chrome/browser/resources/chromeos/braille_ime/compiled_resources2.gyp:*',

16
third_party/closure_compiler/run_compiler vendored Executable file

@ -0,0 +1,16 @@
#!/bin/sh
# Copyright 2016 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
set -e
cd $(dirname "$0")/../..
export GYP_GENERATORS="ninja"
tools/gyp/gyp --no-circular-check \
third_party/closure_compiler/compiled_resources.gyp \
third_party/closure_compiler/compiled_resources2.gyp
ninja -C out/Default -j4 $@