chromium/src
0
Fork 0
Code Activity

Remove usage of base::make_span(): ipc/

Browse Source 
Replace with span() CTAD use, or more targeted helpers.

Bug: 341907909
Change-Id: Ibd8b85c70ae7db8f146eb7ad136b727be7e85af2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6058569
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1390387}
This commit is contained in:
Peter Kasting
2024-12-02 16:59:03 +00:00
committed by Chromium LUCI CQ
parent 9c6f6da356
commit 5364b4287f
2 changed files with 9 additions and 11 deletions

2
ipc/ipc_mojo_bootstrap_unittest.cc

@ -212,7 +212,7 @@ MULTIPROCESS_TEST_MAIN_WITH_SETUP(
uint8_t data = 0;
sender->Receive(
IPC::MessageView(base::make_span(&data, 0u), std::nullopt /* handles */));
IPC::MessageView(base::span(&data, 0u), std::nullopt /* handles */));
base::RunLoop run_loop;
PeerPidReceiver impl(std::move(receiver), run_loop.QuitClosure());

18
ipc/sync_socket_unittest.cc

@ -164,7 +164,7 @@ class SyncSocketClientListener : public IPC::Listener {
// the SyncSocketServerListener object.
EXPECT_EQ(socket_->Peek(), expected_bytes_to_receive);
base::FixedArray<char> buf(expected_bytes_to_receive);
socket_->Receive(base::as_writable_bytes(base::make_span(buf)));
socket_->Receive(base::as_writable_byte_span(buf));
EXPECT_EQ(strcmp(str.c_str(), buf.data()), 0);
// After receiving from the socket there should be no bytes left.
EXPECT_EQ(0U, socket_->Peek());
@ -244,13 +244,12 @@ TEST_F(SyncSocketTest, DisconnectTest) {
char buf[0xff];
size_t received = 1U; // Initialize to an unexpected value.
worker.task_runner()->PostTask(
FROM_HERE,
base::BindOnce(&BlockingRead, &pair[0],
base::as_writable_bytes(base::make_span(buf)), &received));
FROM_HERE, base::BindOnce(&BlockingRead, &pair[0],
base::as_writable_byte_span(buf), &received));
// Wait for the worker thread to say hello.
char hello[kHelloStringLength] = {0};
pair[1].Receive(base::as_writable_bytes(base::make_span(hello)));
pair[1].Receive(base::as_writable_byte_span(hello));
EXPECT_EQ(strcmp(hello, kHelloString), 0);
// Give the worker a chance to start Receive().
base::PlatformThread::YieldCurrentThread();
@ -276,13 +275,12 @@ TEST_F(SyncSocketTest, BlockingReceiveTest) {
char buf[kHelloStringLength] = {0};
size_t received = 1U; // Initialize to an unexpected value.
worker.task_runner()->PostTask(
FROM_HERE,
base::BindOnce(&BlockingRead, &pair[0],
base::as_writable_bytes(base::make_span(buf)), &received));
FROM_HERE, base::BindOnce(&BlockingRead, &pair[0],
base::as_writable_byte_span(buf), &received));
// Wait for the worker thread to say hello.
char hello[kHelloStringLength] = {0};
pair[1].Receive(base::as_writable_bytes(base::make_span(hello)));
pair[1].Receive(base::as_writable_byte_span(hello));
EXPECT_EQ(0, strcmp(hello, kHelloString));
// Give the worker a chance to start Receive().
base::PlatformThread::YieldCurrentThread();
@ -321,7 +319,7 @@ TEST_F(SyncSocketTest, NonBlockingWriteTest) {
// Read from another socket to free some space for a new write.
char hello[kHelloStringLength] = {0};
pair[1].Receive(base::as_writable_bytes(base::make_span(hello)));
pair[1].Receive(base::as_writable_byte_span(hello));
// Should be able to write more data to the buffer now.
EXPECT_EQ(pair[0].Send(bytes_to_send), bytes_to_send.size());