0

Update no results found string.

There should be no period.

Bug: b:345303965
Change-Id: Ifd41596afb0da23325b11072ba565ad6ea124cf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5773348
Reviewed-by: Michelle Chen <michellegc@google.com>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1340217}
This commit is contained in:
Darren Shen
2024-08-12 01:45:09 +00:00
committed by Chromium LUCI CQ
parent a27c42c56f
commit 554c2d28ab
5 changed files with 12 additions and 7 deletions

@ -7509,7 +7509,7 @@ New install
</message>
<message name="IDS_PICKER_NO_RESULTS_TEXT"
desc="This string appears a label inside a list of search results. It indicates that there are no search results found for the given query.">
No results found.
No results found
</message>
<message name="IDS_PICKER_INSERT_RESULT_BADGE_LABEL"
desc="This string appears as the label for a badge in a search result. It indicates that selecting the search result will insert it into the current page. For example, this badge might appear in a search result for an image, which would insert the image into the page. Try to limit translations to 10 characters.">

@ -1 +1 @@
2c509d2c937b5c67e8162c7222b417e6d770d006
fc6b3d8b23c6e07b0d7ea837d5f227d0005e1cbc

@ -23,6 +23,7 @@
#include "ash/picker/views/picker_submenu_controller.h"
#include "ash/picker/views/picker_traversable_item_container.h"
#include "ash/public/cpp/picker/picker_search_result.h"
#include "ash/strings/grit/ash_strings.h"
#include "ash/style/ash_color_provider.h"
#include "ash/test/view_drawn_waiter.h"
#include "base/files/file_path.h"
@ -32,6 +33,7 @@
#include "testing/gmock/include/gmock/gmock-matchers.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/compositor/layer.h"
#include "ui/compositor/layer_animator.h"
#include "ui/compositor/scoped_animation_duration_scale_mode.h"
@ -574,7 +576,8 @@ TEST_F(PickerSearchResultsViewTest,
views::test::AXEventCounter counter(views::AXEventManager::Get());
EXPECT_TRUE(view->SearchStopped(/*illustration=*/{}, u""));
EXPECT_EQ(view->GetAccessibleName(), u"No results found.");
EXPECT_EQ(view->GetAccessibleName(),
l10n_util::GetStringUTF16(IDS_PICKER_NO_RESULTS_TEXT));
EXPECT_EQ(counter.GetCount(ax::mojom::Event::kLiveRegionChanged), 1);
}
@ -612,7 +615,8 @@ TEST_F(PickerSearchResultsViewTest,
view->SearchStopped(/*illustration=*/{}, u"");
view->SearchStopped(/*illustration=*/{}, u"");
EXPECT_EQ(view->GetAccessibleName(), u"No results found.");
EXPECT_EQ(view->GetAccessibleName(),
l10n_util::GetStringUTF16(IDS_PICKER_NO_RESULTS_TEXT));
EXPECT_EQ(counter.GetCount(ax::mojom::Event::kLiveRegionChanged), 1);
}
@ -634,7 +638,8 @@ TEST_F(PickerSearchResultsViewTest,
view->ClearSearchResults();
view->SearchStopped(/*illustration=*/{}, u"");
EXPECT_EQ(view->GetAccessibleName(), u"No results found.");
EXPECT_EQ(view->GetAccessibleName(),
l10n_util::GetStringUTF16(IDS_PICKER_NO_RESULTS_TEXT));
EXPECT_EQ(counter.GetCount(ax::mojom::Event::kLiveRegionChanged), 2);
}

@ -1164,7 +1164,7 @@ TEST_F(PickerViewTest, NoMainResultsAndNoEmojisIsAnnounced) {
future.Take().Run({});
EXPECT_EQ(picker_view->search_results_view_for_testing().GetAccessibleName(),
u"No results found.");
l10n_util::GetStringUTF16(IDS_PICKER_NO_RESULTS_TEXT));
EXPECT_EQ(counter.GetCount(ax::mojom::Event::kLiveRegionChanged), 1);
}

@ -721,7 +721,7 @@ IN_PROC_BROWSER_TEST_F(PickerAccessibilityBrowserTest,
sm_.Call([view]() {
view->SearchStopped(/*illustration=*/{}, /*description=*/u"");
});
sm_.ExpectSpeechPattern("No results found.");
sm_.ExpectSpeechPattern(l10n_util::GetStringUTF8(IDS_PICKER_NO_RESULTS_TEXT));
sm_.ExpectSpeechPattern("Status");
sm_.Replay();
}