chromium/src
0
Fork 0
Code Activity

Move chrome_pdf::SendThumbnailCallback to pdf/ui/thumbnail.h

Browse Source 
Putting thumbnail-related definitions in thumbnail.h. This does require
an extra forward declaration of `Thumbnail` in thumbnail.h to work.

Change-Id: If948e4dbdc1fa8051c2d05e40e98381b45a7fe29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5714694
Reviewed-by: Alan Screen <awscreen@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1329839}
This commit is contained in:
Lei Zhang
2024-07-18 21:47:15 +00:00
committed by Chromium LUCI CQ
parent ff4556a0e9
commit 555f70f3a2
3 changed files with 7 additions and 4 deletions

5
pdf/pdf_engine.h

@ -13,11 +13,11 @@
#include <vector>
#include "base/containers/span.h"
#include "base/functional/callback.h"
#include "base/time/time.h"
#include "base/values.h"
#include "build/build_config.h"
#include "pdf/document_layout.h"
#include "pdf/ui/thumbnail.h"
#include "printing/mojom/print.mojom-forward.h"
#include "services/screen_ai/buildflags/buildflags.h"
#include "ui/gfx/geometry/point_f.h"
@ -43,7 +43,6 @@ class Vector2d;
namespace chrome_pdf {
class Thumbnail;
struct AccessibilityActionData;
struct AccessibilityFocusInfo;
struct AccessibilityLinkInfo;
@ -54,8 +53,6 @@ struct AccessibilityTextRunInfo;
struct DocumentAttachmentInfo;
struct DocumentMetadata;
using SendThumbnailCallback = base::OnceCallback<void(Thumbnail)>;
enum class FontMappingMode {
// Do not perform font mapping.
kNoMapping,

1
pdf/pdfium/pdfium_page.h

@ -17,6 +17,7 @@
#include "base/memory/raw_ptr.h"
#include "pdf/page_orientation.h"
#include "pdf/pdf_engine.h"
#include "pdf/ui/thumbnail.h"
#include "third_party/pdfium/public/cpp/fpdf_scopers.h"
#include "third_party/pdfium/public/fpdf_doc.h"
#include "third_party/pdfium/public/fpdf_formfill.h"

5
pdf/ui/thumbnail.h

@ -5,11 +5,16 @@
#ifndef PDF_UI_THUMBNAIL_H_
#define PDF_UI_THUMBNAIL_H_
#include "base/functional/callback.h"
#include "base/values.h"
#include "ui/gfx/geometry/size.h"
namespace chrome_pdf {
class Thumbnail;
using SendThumbnailCallback = base::OnceCallback<void(Thumbnail)>;
class Thumbnail final {
public:
Thumbnail(const gfx::Size& page_size, float device_pixel_ratio);