chromium/src
0
Fork 0
Code Activity

Add mandatory code-review initial announcement & link to document index & code_reviews docs.

Browse Source 
Change-Id: I8f8da9aa793b5818f2395795094f0e2313e0af25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321867
Commit-Queue: Andrew Whalley <awhalley@chromium.org>
Auto-Submit: Yulan Lin <yulanlin@google.com>
Reviewed-by: Andrew Whalley <awhalley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#793687}
This commit is contained in:
Yulan Lin
2020-07-31 17:58:29 +00:00
committed by Commit Bot
parent 26b74f2970
commit 55ae6a38e0
3 changed files with 19 additions and 1 deletions

1
docs/README.md

@ -110,6 +110,7 @@ used when committed.
* [Code Reviews](code_reviews.md) - Code review requirements and guidelines
* [Respectful Code Reviews](cr_respect.md) - A guide for code reviewers
* [Respectful Changes](cl_respect.md) - A guide for code authors
* [Mandatory Code-Review Rollout](code_review_owners.md) - Upcoming policy changes related to code review and OWNERS
* [LUCI Migration FAQ](luci_migration_faq.md) - FAQ on Buildbot-to-LUCI
builder migration for Chromium
* [Tour of Continuous Integration UI](tour_of_luci_ui.md) - A tour of our

15
docs/code_review_owners.md Normal file

@ -0,0 +1,15 @@
# Mandatory Code-Review and OWNERS
Beginning in Q1 2021, committers@ of Chromium will no longer be able
to circumvent code review and OWNERS approval on CLs.
Currently, these are circumventable by self-code-review and because the
enforcement is done by presumit, although rarely done by external
contributors. In Q1, Gerrit will disallow both bypasses. As part of the
transition, an audit service will automatically file bugs for CLs that
land with only self-approval, launching in Q4 2020. Within Google, where
these bypasses are more common, Googlers can find Google-specific
information in the internal announcements and landing site.
Periodic updates and FAQs will be sent to chromium-dev@chromium.org
and updated on this page.

4
docs/code_reviews.md

@ -4,7 +4,9 @@ Code reviews are a central part of developing high-quality code for Chromium.
All changes must be reviewed.
The general patch, upload, and land process is covered in more detail in the
[contributing code](contributing.md) page.
[contributing code](contributing.md) page. To learn about upcoming code review
and OWNERS policy changes, see
[Mandatory code review and OWNERS](code_review_owners.md).
# Code review policies