chromium/src
0
Fork 0
Code Activity

[Phone Hub][Eche] Include mini launcher title

Browse Source 
Screenshot: https://screenshot.googleplex.com/3H39cT99yeGLgHn.png

Test: Manually verified and included screenshot
Fixed: b/259299246
Change-Id: Ia5c32d7e24ad133e2b17234c17c9979f32a33f2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4064924
Reviewed-by: Abbas Nayebi <nayebi@google.com>
Commit-Queue: Crisrael Lucero <crisrael@google.com>
Reviewed-by: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1078138}
This commit is contained in:
Crisrael Lucero
2022-12-01 17:39:02 +00:00
committed by Chromium LUCI CQ
parent 630f7d5fcd
commit 59332c563b
3 changed files with 7 additions and 2 deletions

3
ash/ash_strings.grd

@ -1625,6 +1625,9 @@ Style notes:
<message name="IDS_ASH_PHONE_HUB_CAMERA_ROLL_AND_APPS_OPT_IN_DESCRIPTION" desc="Description for the notification opt in view.">
View your phone's recent photos, media, and apps on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
</message>
<message name="IDS_ASH_PHONE_HUB_APP_STREAM_LAUNCHER_TITLE" desc="Title for the launcher that displays apps from your phone.">
Apps from your phone
</message>
<message name="IDS_ASH_PHONE_HUB_APPS_OPT_IN_DESCRIPTION" desc="Description for the apps opt in view.">
View your phone's apps on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
</message>

1
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_APP_STREAM_LAUNCHER_TITLE.png.sha1 Normal file

@ -0,0 +1 @@
073f9a76d6f37d32495ad5278e555c49788a407f

5
ash/system/phonehub/app_stream_launcher_view.cc

@ -11,6 +11,7 @@
#include "ash/constants/ash_features.h"
#include "ash/controls/rounded_scroll_bar.h"
#include "ash/resources/vector_icons/vector_icons.h"
#include "ash/strings/grit/ash_strings.h"
#include "ash/style/ash_color_provider.h"
#include "ash/system/phonehub/app_stream_launcher_item.h"
#include "ash/system/phonehub/app_stream_launcher_view.h"
@ -239,8 +240,8 @@ std::unique_ptr<views::View> AppStreamLauncherView::CreateHeaderView() {
/*adjust_height_for_width =*/true)
.WithWeight(1));
title->SetHorizontalAlignment(gfx::ALIGN_LEFT);
// TODO(b/259299246) Finalize the text and read from the resource
title->SetText(u"Apps on your phone");
title->SetText(
l10n_util::GetStringUTF16(IDS_ASH_PHONE_HUB_APP_STREAM_LAUNCHER_TITLE));
return header;
}