0

Delete HostDelegate objects instead of HostImpl objects to avoid leaking the former.

BUG=116744


Review URL: http://codereview.chromium.org/9553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125105 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
fischman@chromium.org
2012-03-06 04:25:26 +00:00
parent 30fcc38967
commit 5998d9d3fa
2 changed files with 4 additions and 7 deletions
content/browser
tools/valgrind/memcheck

@ -105,7 +105,10 @@ void BrowserChildProcessHostImpl::TerminateAll() {
// Make a copy since the BrowserChildProcessHost dtor mutates the original
// list.
BrowserChildProcessList copy = g_child_process_list.Get();
STLDeleteElements(&copy);
for (BrowserChildProcessList::iterator it = copy.begin();
it != copy.end(); ++it) {
delete (*it)->delegate(); // ~*HostDelegate deletes *HostImpl.
}
}
void BrowserChildProcessHostImpl::Launch(

@ -5886,12 +5886,6 @@
fun:_ZN4test3api21additional_properties26ReturnAdditionalProperties6Result6CreateERKNS3_12ResultObjectE
fun:_ZN86JsonSchemaCompilerAdditionalPropertiesTest_ReturnAdditionalPropertiesResultCreate_Test8TestBodyEv
}
{
bug_116744
Memcheck:Leak
fun:_Znw*
fun:_ZN14GpuProcessHost12GetForClientEiN7content17CauseForGpuLaunchE
}
#-----------------------------------------------------------------------
# 4. These only occur on our Google workstations