Delete HostDelegate objects instead of HostImpl objects to avoid leaking the former.
BUG=116744 Review URL: http://codereview.chromium.org/9553003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125105 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
@ -105,7 +105,10 @@ void BrowserChildProcessHostImpl::TerminateAll() {
|
|||||||
// Make a copy since the BrowserChildProcessHost dtor mutates the original
|
// Make a copy since the BrowserChildProcessHost dtor mutates the original
|
||||||
// list.
|
// list.
|
||||||
BrowserChildProcessList copy = g_child_process_list.Get();
|
BrowserChildProcessList copy = g_child_process_list.Get();
|
||||||
STLDeleteElements(©);
|
for (BrowserChildProcessList::iterator it = copy.begin();
|
||||||
|
it != copy.end(); ++it) {
|
||||||
|
delete (*it)->delegate(); // ~*HostDelegate deletes *HostImpl.
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
void BrowserChildProcessHostImpl::Launch(
|
void BrowserChildProcessHostImpl::Launch(
|
||||||
|
@ -5886,12 +5886,6 @@
|
|||||||
fun:_ZN4test3api21additional_properties26ReturnAdditionalProperties6Result6CreateERKNS3_12ResultObjectE
|
fun:_ZN4test3api21additional_properties26ReturnAdditionalProperties6Result6CreateERKNS3_12ResultObjectE
|
||||||
fun:_ZN86JsonSchemaCompilerAdditionalPropertiesTest_ReturnAdditionalPropertiesResultCreate_Test8TestBodyEv
|
fun:_ZN86JsonSchemaCompilerAdditionalPropertiesTest_ReturnAdditionalPropertiesResultCreate_Test8TestBodyEv
|
||||||
}
|
}
|
||||||
{
|
|
||||||
bug_116744
|
|
||||||
Memcheck:Leak
|
|
||||||
fun:_Znw*
|
|
||||||
fun:_ZN14GpuProcessHost12GetForClientEiN7content17CauseForGpuLaunchE
|
|
||||||
}
|
|
||||||
|
|
||||||
#-----------------------------------------------------------------------
|
#-----------------------------------------------------------------------
|
||||||
# 4. These only occur on our Google workstations
|
# 4. These only occur on our Google workstations
|
||||||
|
Reference in New Issue
Block a user