chromium/src
0
Fork 0
Code Activity

mojom-webui: Consistently use ' and template strings

Browse Source 
Small cleanup CL.

Bug: 1407936
Change-Id: I583fef5006e28c6174df4e9c8beb574e8cbc3cdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4177721
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Giovanni Ortuno Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1096281}
This commit is contained in:
Giovanni Ortuño Urquidi
2023-01-24 18:41:13 +00:00
committed by Chromium LUCI CQ
parent 5977fb6f7b
commit 5eb1e1b72e
1 changed files with 12 additions and 13 deletions

25
mojo/public/tools/bindings/generators/mojom_js_interface_binder_generator.py

@ -68,7 +68,7 @@ class Generator(generator.Generator):
@staticmethod
def GetTemplatePrefix():
return "js_interface_binder_templates"
return 'js_interface_binder_templates'
def _GetKindName(self, kind):
"""Return `kind`'s name, prefixing it with its namespace if necessary."""
@ -83,18 +83,18 @@ class Generator(generator.Generator):
Returns None if the type is not supposed to be used in a JsInterfaceBinder.
"""
if mojom.IsPendingRemoteKind(kind):
return "::mojo::PendingRemote<%s>" % self._GetKindName(kind.kind)
return f'::mojo::PendingRemote<{self._GetKindName(kind.kind)}>'
if mojom.IsPendingReceiverKind(kind):
return "::mojo::PendingReceiver<%s>" % self._GetKindName(kind.kind)
return f'::mojo::PendingReceiver<{self._GetKindName(kind.kind)}>'
def _GetBinderMemberVariableName(self, bind_method):
"""Return the variable name of the binder corresponding to `bind_method`."""
return "binder_for_%s" % generator.ToLowerSnakeCase(bind_method.name)
return f'binder_for_{generator.ToLowerSnakeCase(bind_method.name)}'
def GetFilters(self):
return {
"cpp_type": self._GetCppType,
"binder_variable_name": self._GetBinderMemberVariableName,
'cpp_type': self._GetCppType,
'binder_variable_name': self._GetBinderMemberVariableName,
}
def _GetInterfaceBinders(self):
@ -111,7 +111,6 @@ class Generator(generator.Generator):
# Enforce JsInterfaceBinders constraints.
for interface_binder in interface_binders:
for method in interface_binder.methods:
print(method.response_parameters)
if method.response_parameters != None:
raise Exception(f'{interface_binder.name}.{method.name} has a '
'response. JsInterfaceBinder\'s methods should not '
@ -130,21 +129,21 @@ class Generator(generator.Generator):
def _GetParameters(self):
return {
"module": self.module,
"interface_binders": self._GetInterfaceBinders()
'module': self.module,
'interface_binders': self._GetInterfaceBinders()
}
@UseJinja("js_interface_binder_impl.h.tmpl")
@UseJinja('js_interface_binder_impl.h.tmpl')
def _GenerateJsInterfaceBinderImplDeclaration(self):
return self._GetParameters()
@UseJinja("js_interface_binder_impl.cc.tmpl")
@UseJinja('js_interface_binder_impl.cc.tmpl')
def _GenerateJsInterfaceBinderImplDefinition(self):
return self._GetParameters()
def GenerateFiles(self, args):
self.module.Stylize(JsInterfaceBinderImplStylizer())
self.WriteWithComment(self._GenerateJsInterfaceBinderImplDeclaration(),
"%s-js-interface-binder-impl.h" % self.module.path)
f'{self.module.path}-js-interface-binder-impl.h')
self.WriteWithComment(self._GenerateJsInterfaceBinderImplDefinition(),
"%s-js-interface-binder-impl.cc" % self.module.path)
f'{self.module.path}-js-interface-binder-impl.cc')