0

[Chromoting] Move breakpad files into crash/ subdirectory.

Change-Id: Id5b4016d67a6324f7e597133b5eacadd51c82c08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6015221
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1382484}
This commit is contained in:
Gary Kacmarcik
2024-11-13 18:51:36 +00:00
committed by Chromium LUCI CQ
parent de58b48afe
commit 5ec2901160
29 changed files with 72 additions and 69 deletions

@ -246,37 +246,6 @@ source_set("authorization") {
]
}
source_set("breakpad") {
sources = [
"breakpad.h",
"breakpad_utils.cc",
"breakpad_utils.h",
]
configs += [ "//build/config/compiler:wexit_time_destructors" ]
deps = [
":remoting_base_version",
"//base",
]
if (is_linux || is_chromeos) {
sources += [ "breakpad_linux.cc" ]
deps += [ "//third_party/breakpad:client" ]
} else if (is_mac) {
sources += [ "breakpad_mac.mm" ]
} else if (is_win) {
sources += [
"breakpad_server.cc",
"breakpad_win.cc",
]
deps += [
":logging",
"//third_party/breakpad:breakpad_handler",
]
}
}
source_set("logging") {
public = [ "logging.h" ]
@ -364,8 +333,8 @@ static_library("test_support") {
public_deps = [
":authorization",
":base",
":breakpad",
"//base",
"//remoting/base/crash",
"//testing/gmock",
"//testing/gtest",
"//third_party/protobuf:protobuf_lite",

@ -0,0 +1,34 @@
# Copyright 2024 The Chromium Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
source_set("crash") {
sources = [
"breakpad.h",
"breakpad_utils.cc",
"breakpad_utils.h",
]
configs += [ "//build/config/compiler:wexit_time_destructors" ]
deps = [
"//base",
"//remoting/base:remoting_base_version",
]
if (is_linux || is_chromeos) {
sources += [ "breakpad_linux.cc" ]
deps += [ "//third_party/breakpad:client" ]
} else if (is_mac) {
sources += [ "breakpad_mac.mm" ]
} else if (is_win) {
sources += [
"breakpad_server.cc",
"breakpad_win.cc",
]
deps += [
"//remoting/base:logging",
"//third_party/breakpad:breakpad_handler",
]
}
}

@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef REMOTING_BASE_BREAKPAD_H_
#define REMOTING_BASE_BREAKPAD_H_
#ifndef REMOTING_BASE_CRASH_BREAKPAD_H_
#define REMOTING_BASE_CRASH_BREAKPAD_H_
#include <string>
@ -39,4 +39,4 @@ void InitializeOopCrashServer();
} // namespace remoting
#endif // REMOTING_BASE_BREAKPAD_H_
#endif // REMOTING_BASE_CRASH_BREAKPAD_H_

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "remoting/base/breakpad.h"
#include "remoting/base/crash/breakpad.h"
#include <memory>
#include <utility>
@ -10,7 +10,7 @@
#include "base/files/file_path.h"
#include "base/no_destructor.h"
#include "base/time/time.h"
#include "remoting/base/breakpad_utils.h"
#include "remoting/base/crash/breakpad_utils.h"
#include "third_party/breakpad/breakpad/src/client/linux/handler/exception_handler.h"
namespace remoting {

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "remoting/base/breakpad.h"
#include "remoting/base/crash/breakpad.h"
namespace remoting {

@ -14,8 +14,8 @@
#include "base/win/access_control_list.h"
#include "base/win/security_descriptor.h"
#include "base/win/sid.h"
#include "remoting/base/breakpad.h"
#include "remoting/base/breakpad_utils.h"
#include "remoting/base/crash/breakpad.h"
#include "remoting/base/crash/breakpad_utils.h"
#include "remoting/base/logging.h"
#include "remoting/base/version.h"
#include "third_party/breakpad/breakpad/src/client/windows/crash_generation/crash_generation_server.h"

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "remoting/base/breakpad_utils.h"
#include "remoting/base/crash/breakpad_utils.h"
#include <utility>

@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef REMOTING_BASE_BREAKPAD_UTILS_H_
#define REMOTING_BASE_BREAKPAD_UTILS_H_
#ifndef REMOTING_BASE_CRASH_BREAKPAD_UTILS_H_
#define REMOTING_BASE_CRASH_BREAKPAD_UTILS_H_
#include <atomic>
#include <memory>
@ -87,4 +87,4 @@ class BreakpadHelper {
} // namespace remoting
#endif // REMOTING_BASE_BREAKPAD_UTILS_H_
#endif // REMOTING_BASE_CRASH_BREAKPAD_UTILS_H_

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "remoting/base/breakpad.h"
#include "remoting/base/crash/breakpad.h"
#include <windows.h>
@ -21,7 +21,7 @@
#include "base/strings/string_number_conversions.h"
#include "base/time/time.h"
#include "base/win/wrapped_window_proc.h"
#include "remoting/base/breakpad_utils.h"
#include "remoting/base/crash/breakpad_utils.h"
#include "remoting/base/version.h"
#include "third_party/breakpad/breakpad/src/client/windows/handler/exception_handler.h"

@ -753,7 +753,7 @@ static_library("common") {
"//media",
"//media/gpu:gpu",
"//mojo/core/embedder:embedder",
"//remoting/base:breakpad",
"//remoting/base/crash",
"//remoting/host/crash:crash_uploader",
"//remoting/host/win",
"//remoting/host/win:messages",
@ -1246,7 +1246,7 @@ if (enable_me2me_host) {
"//base:debugging_buildflags",
"//mojo/core/embedder:embedder",
"//remoting/base",
"//remoting/base:breakpad",
"//remoting/base/crash",
"//remoting/host/base",
"//remoting/host/setup:common",
]

@ -18,7 +18,7 @@ source_set("crash_uploader") {
deps = [
"//base",
"//remoting/base",
"//remoting/base:breakpad",
"//remoting/base/crash",
"//remoting/host:common_headers",
"//remoting/host/base",
"//services/network:network_service",
@ -41,7 +41,7 @@ source_set("crash_uploader_main") {
"//base",
"//mojo/core/embedder:embedder",
"//remoting/base",
"//remoting/base:breakpad",
"//remoting/base/crash",
"//remoting/host:common_headers",
"//remoting/host/base",
]

@ -25,7 +25,7 @@
#include "net/base/mime_util.h"
#include "net/base/net_errors.h"
#include "net/traffic_annotation/network_traffic_annotation.h"
#include "remoting/base/breakpad_utils.h"
#include "remoting/base/crash/breakpad_utils.h"
#include "services/network/public/cpp/resource_request.h"
#include "services/network/public/cpp/shared_url_loader_factory.h"
#include "services/network/public/cpp/simple_url_loader.h"

@ -5,7 +5,7 @@
#include "remoting/host/crash/minidump_handler.h"
#include "base/functional/bind.h"
#include "remoting/base/breakpad_utils.h"
#include "remoting/base/crash/breakpad_utils.h"
namespace remoting {

@ -35,7 +35,7 @@
#include "mojo/public/cpp/system/message_pipe.h"
#include "remoting/base/auto_thread.h"
#include "remoting/base/auto_thread_task_runner.h"
#include "remoting/base/breakpad.h"
#include "remoting/base/crash/breakpad.h"
#include "remoting/base/logging.h"
#include "remoting/base/scoped_sc_handle_win.h"
#include "remoting/host/base/host_exit_codes.h"

@ -19,7 +19,7 @@
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
#include "mojo/core/embedder/embedder.h"
#include "remoting/base/breakpad.h"
#include "remoting/base/crash/breakpad.h"
#include "remoting/base/logging.h"
#include "remoting/host/base/host_exit_codes.h"
#include "remoting/host/base/switches.h"

@ -207,7 +207,7 @@ if (!is_chromeos_ash && enable_remoting_host) {
"//mojo/core/embedder",
"//net",
"//remoting/base",
"//remoting/base:breakpad",
"//remoting/base/crash",
"//remoting/host",
"//remoting/host:resources",
"//remoting/host:settings",

@ -17,7 +17,7 @@
#include "mojo/core/embedder/embedder.h"
#include "net/base/network_change_notifier.h"
#include "remoting/base/auto_thread_task_runner.h"
#include "remoting/base/breakpad.h"
#include "remoting/base/crash/breakpad.h"
#include "remoting/base/host_settings.h"
#include "remoting/base/logging.h"
#include "remoting/host/base/host_exit_codes.h"

@ -164,7 +164,7 @@ target("mac_app_bundle", "remoting_me2me_host") {
deps = [
":permission_checking",
"//remoting/base:breakpad",
"//remoting/base/crash",
"//remoting/host:entry_point",
"//remoting/host/installer:credits",
"//remoting/resources",

@ -80,7 +80,7 @@ source_set("main") {
"//base:i18n",
"//mojo/core/embedder",
"//remoting/base",
"//remoting/base:breakpad",
"//remoting/base/crash",
"//remoting/host",
"//remoting/host:chromoting_host_services_client",
"//remoting/host:resources",

@ -13,7 +13,7 @@
#include "base/task/single_thread_task_runner.h"
#include "mojo/core/embedder/embedder.h"
#include "mojo/core/embedder/scoped_ipc_support.h"
#include "remoting/base/breakpad.h"
#include "remoting/base/crash/breakpad.h"
#include "remoting/base/host_settings.h"
#include "remoting/base/logging.h"
#include "remoting/host/base/host_exit_codes.h"

@ -66,7 +66,7 @@ if (is_win) {
"//base:debugging_buildflags",
"//mojo/core/embedder",
"//remoting/base",
"//remoting/base:breakpad",
"//remoting/base/crash",
"//remoting/host:chromoting_host_services_client",
"//remoting/host:common",
"//remoting/host/base",

@ -17,7 +17,7 @@
#include "build/build_config.h"
#include "mojo/core/embedder/embedder.h"
#include "mojo/core/embedder/scoped_ipc_support.h"
#include "remoting/base/breakpad.h"
#include "remoting/base/crash/breakpad.h"
#include "remoting/base/logging.h"
#include "remoting/host/base/host_exit_codes.h"
#include "remoting/host/chromoting_host_services_client.h"

@ -136,7 +136,7 @@ source_set("start_host_main") {
"//net",
"//remoting/base:authorization",
"//remoting/base:base",
"//remoting/base:breakpad",
"//remoting/base/crash",
"//remoting/host:common",
"//remoting/host/setup",
"//remoting/host/setup:start_host_main_headers",
@ -184,7 +184,7 @@ source_set("native_messaging_host_main") {
"//net",
"//remoting/base",
"//remoting/base:authorization",
"//remoting/base:breakpad",
"//remoting/base/crash",
"//remoting/host",
"//remoting/host:common",
"//remoting/host/base",

@ -24,7 +24,7 @@
#include "build/chromeos_buildflags.h"
#include "mojo/core/embedder/embedder.h"
#include "remoting/base/auto_thread_task_runner.h"
#include "remoting/base/breakpad.h"
#include "remoting/base/crash/breakpad.h"
#include "remoting/base/gaia_oauth_client.h"
#include "remoting/base/logging.h"
#include "remoting/base/url_request_context_getter.h"

@ -22,7 +22,7 @@
#include "build/build_config.h"
#include "mojo/core/embedder/embedder.h"
#include "net/url_request/url_request_context_getter.h"
#include "remoting/base/breakpad.h"
#include "remoting/base/crash/breakpad.h"
#include "remoting/base/logging.h"
#include "remoting/base/url_request_context_getter.h"
#include "remoting/host/setup/cloud_host_starter.h"

@ -52,7 +52,7 @@ source_set("main") {
"//base",
"//mojo/core/embedder:embedder",
"//remoting/base",
"//remoting/base:breakpad",
"//remoting/base/crash",
"//remoting/host:chromoting_host_services_client",
"//remoting/host:common_headers",
"//remoting/host/base",

@ -18,7 +18,7 @@
#include "mojo/core/embedder/embedder.h"
#include "mojo/core/embedder/scoped_ipc_support.h"
#include "remoting/base/auto_thread_task_runner.h"
#include "remoting/base/breakpad.h"
#include "remoting/base/crash/breakpad.h"
#include "remoting/base/logging.h"
#include "remoting/host/base/host_exit_codes.h"
#include "remoting/host/chromoting_host_services_client.h"

@ -430,7 +430,7 @@ shared_library("remoting_core") {
"//net",
"//remoting/base",
"//remoting/base:authorization",
"//remoting/base:breakpad",
"//remoting/base/crash",
"//remoting/host:host",
"//remoting/host:host_main_headers",
"//remoting/host:implementation",

@ -34,7 +34,7 @@
#include "ipc/ipc_message.h"
#include "mojo/public/cpp/platform/platform_channel.h"
#include "mojo/public/cpp/system/invitation.h"
#include "remoting/base/breakpad_utils.h"
#include "remoting/base/crash/breakpad_utils.h"
#include "remoting/base/typed_buffer.h"
#include "remoting/host/base/switches.h"
#include "remoting/host/usage_stats_consent.h"