chromium/src
0
Fork 0
Code Activity

[headless] Fixed HeadlessWebContentsTest.HandleSSLError flakiness.

Browse Source 
RenderProcessHostObserver could be destroyed before unsubscribing
from render process host, causing fatal failure thrown by
CheckedObserver::IsInObserverList().

Bug: 1164173,1164500
Change-Id: I4e0a9e8395ee4009b7797f65bada90939445d9f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2855008
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#876753}
This commit is contained in:
Peter Kvitek
2021-04-27 21:06:29 +00:00
committed by Chromium LUCI CQ
parent b471482c1d
commit 5f0796579e
1 changed files with 1 additions and 0 deletions

1
headless/lib/browser/headless_web_contents_impl.cc

@ -452,6 +452,7 @@ void HeadlessWebContentsImpl::RenderProcessExited(
void HeadlessWebContentsImpl::RenderProcessHostDestroyed(
content::RenderProcessHost* host) {
DCHECK_EQ(render_process_host_, host);
render_process_host_->RemoveObserver(this);
render_process_host_ = nullptr;
}