chromium/src
0
Fork 0
Code Activity

Update comments about is_chrome_branded and is_official_build.

Browse Source 
Make it clear that those are totally different flags
based on feedback from hashimoto@ on
https://chromium-review.googlesource.com/c/chromium/src/+/4227051

Bug: None
Change-Id: I68e646b399aa535868af59475857e2c5801f1966
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4263189
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Satoru Takabayashi <satorux@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1106641}
This commit is contained in:
Satoru Takabayashi
2023-02-17 05:31:53 +00:00
committed by Chromium LUCI CQ
parent a6c8233b1f
commit 5f3b2ec1bf
1 changed files with 7 additions and 4 deletions

11
docs/chromeos_build_instructions.md

@ -74,10 +74,13 @@ or running `gn args out/Default`:
dcheck_always_on = true # Enables DCHECK despite release build.
enable_nacl = false # Skips native client build, compiles faster.
# Set the following true to create a Chrome (instead of Chromium) build.
# This requires a src-internal checkout.
is_chrome_branded = true # Adds internal features and branded art assets.
is_official_build = true # Turns on many optimizations, slower build.
# Builds Chrome instead of Chromium. This requires a src-internal
# checkout. Adds internal features and branded art assets.
is_chrome_branded = true
# Enables many optimizations, leading to much slower compiles, links,
# and no runtime stack traces.
is_official_build = true
NOTE: You may wish to replace 'Default' with something like 'Cros' if
you switch back and forth between Linux and Chromium OS builds, or 'Debug'