0

Update PRESUBMIT warning for violating putting ForTesting() in prod.

It's possible to go through a backdoor now, and this explains that
you can do so, while begging you to not do so.

R=avi@chromium.org

Bug: 1091083
Change-Id: I164f1d39ec99a852dec2ce65662e22f81002a529
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402202
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805725}
This commit is contained in:
danakj
2020-09-10 13:52:55 +00:00
committed by Commit Bot
parent 003be2c449
commit 5f6e3b8766

@ -74,11 +74,15 @@ _THIRD_PARTY_EXCEPT_BLINK = 'third_party/(?!blink/)'
_TEST_ONLY_WARNING = (
'You might be calling functions intended only for testing from\n'
'production code. It is OK to ignore this warning if you know what\n'
'you are doing, as the heuristics used to detect the situation are\n'
'not perfect. The commit queue will not block on this warning,\n'
'however the android-binary-size trybot will block if the method\n'
'exists in the release apk.')
'production code. If you are doing this from inside another method\n'
'named as *ForTesting(), then consider exposing things to have tests\n'
'make that same call directly.\n'
'If that is not possible, you may put a comment on the same line with\n'
' // IN-TEST \n'
'to tell the PRESUBMIT script that the code is inside a *ForTesting()\n'
'method and can be ignored. Do not do this inside production code.\n'
'The android-binary-size trybot will block if the method exists in the\n'
'release apk.')
_INCLUDE_ORDER_WARNING = (