chromium/src
0
Fork 0
Code Activity

[wpt-importer] File bugs against Buganizer, not Monorail

Browse Source 
Monorail is read-only now. Activate the Buganizer code path, update the
WPT notification instructions, and add `buganizer_public.component_id`
to `external/DIR_METADATA` to collect all bugs for now. According to the
FAQ [0], the remaining `DIR_METADATA` will receive Buganizer component
IDs "soon after migration".

[0]: go/chrome-on-buganizer-faq

Bug: b/40257571
Change-Id: I9b0b89be29964ec46c7e09d7d39eadbf5ee23030
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5270234
Reviewed-by: Weizhong Xia <weizhong@google.com>
Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1256359}
This commit is contained in:
Jonathan Lee
2024-02-05 19:55:49 +00:00
committed by Chromium LUCI CQ
parent 0167500548
commit 61fc72853a
3 changed files with 11 additions and 15 deletions
docs/testing
web_platform_tests.md
third_party/blink
tools
blinkpy
w3c
import_notifier.py
web_tests
external
DIR_METADATA

17
docs/testing/web_platform_tests.md

@ -210,14 +210,11 @@ introduce failures as long as test owners did not choose to opt-out the failure
notification mechanism. This includes new tests that fail in Chromium, as well
as new failures introduced to an existing test. Test owners are encouraged to
create an `DIR_METADATA` file in the appropriate `external/wpt/` subdirectory
that contains at least the `monorail.component` and `buganizer_public.component_id`
fields, which the importer will use to file bugs.
that contains at least the `buganizer_public.component_id` field, which the
importer will use to file bugs.
For example, `external/wpt/css/css-grid/DIR_METADATA` looks like:
```
monorail {
component: "Blink>Layout>Grid"
}
buganizer_public {
component_id: 1415957
}
@ -225,9 +222,9 @@ team_email: "layout-dev@chromium.org"
```
When tests under `external/wpt/css/css-grid/` newly fail in a WPT import, the
importer will automatically file a bug against the `Blink>Layout>Grid` component
in [crbug.com](https://crbug.com), with details of which tests failed and the
outputs.
importer will automatically file a bug against the `Chromium>Blink>Layout>Grid`
component in [issues.chromium.org](https://issues.chromium.org/issues), with
details of which tests failed and the outputs.
The importer will also copy `layout-dev@chromium.org` (the `team_email`) and any
`external/wpt/css/css-grid/OWNERS` on the bug.
@ -240,8 +237,8 @@ For example, the following `DIR_METADATA` will suppress notification from tests
under the located directory:
```
monorail {
component: "Blink>Layout>Grid"
buganizer_public {
component_id: 1415957
}
team_email: "layout-dev@chromium.org"
wpt {

4
third_party/blink/tools/blinkpy/w3c/import_notifier.py vendored

@ -35,8 +35,8 @@ _log = logging.getLogger(__name__)
GITHUB_COMMIT_PREFIX = WPT_GH_URL + 'commit/'
SHORT_GERRIT_PREFIX = 'https://crrev.com/c/'
USE_BUGANIZER = False
BUGANIZER_WPT_COMPONENT = "1415957"
USE_BUGANIZER = True
BUGANIZER_WPT_COMPONENT = '1456176'
class ImportNotifier:

5
third_party/blink/web_tests/external/DIR_METADATA vendored

@ -1,5 +1,4 @@
monorail {
component: "Blink>Infra>Ecosystem"
buganizer_public {
component_id: 1456176
}
team_email: "ecosystem-infra@chromium.org"