0

test: Replace _TEST_CASE_ with _TEST_SUITE_ in /crypto.

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=rsleevi@chromium.org

Bug: 925652
Change-Id: Ib59d807085c7882083c82715d293d07989cfb253
Reviewed-on: https://chromium-review.googlesource.com/c/1438372
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626532}
This commit is contained in:
Victor Costan
2019-01-28 14:54:09 +00:00
committed by Commit Bot
parent 1c6d354d71
commit 62dd72b06c
2 changed files with 7 additions and 7 deletions

@ -17,7 +17,7 @@ const crypto::Aead::AeadAlgorithm kAllAlgorithms[]{
class AeadTest : public testing::TestWithParam<crypto::Aead::AeadAlgorithm> {};
INSTANTIATE_TEST_CASE_P(, AeadTest, testing::ValuesIn(kAllAlgorithms));
INSTANTIATE_TEST_SUITE_P(, AeadTest, testing::ValuesIn(kAllAlgorithms));
TEST_P(AeadTest, SealOpen) {
crypto::Aead::AeadAlgorithm alg = GetParam();

@ -207,10 +207,10 @@ static const ScryptTestVector kTestVectorsScrypt[] = {
"7023bdcb3afd7348461c06cd81fd38ebfda8fbba904f8e3ea9b543f6545da1f2d54329556"
"13f0fcf62d49705242a9af9e61e85dc0d651e40dfcf017b45575887"}};
INSTANTIATE_TEST_CASE_P(,
SymmetricKeyDeriveKeyFromPasswordUsingPbkdf2Test,
testing::ValuesIn(kTestVectorsPbkdf2));
INSTANTIATE_TEST_SUITE_P(,
SymmetricKeyDeriveKeyFromPasswordUsingPbkdf2Test,
testing::ValuesIn(kTestVectorsPbkdf2));
INSTANTIATE_TEST_CASE_P(,
SymmetricKeyDeriveKeyFromPasswordUsingScryptTest,
testing::ValuesIn(kTestVectorsScrypt));
INSTANTIATE_TEST_SUITE_P(,
SymmetricKeyDeriveKeyFromPasswordUsingScryptTest,
testing::ValuesIn(kTestVectorsScrypt));