chromium/src
0
Fork 0
Code Activity

Code health: port away from deprecated ListValue::Remove

Browse Source 
This is a portion for /chromecast/crash.
(And in some cases also adjust away from other deprecated Value APIs,
 when convenient)

This CL was uploaded by git cl split.

R=alexst@chromium.org

Bug: 1187094
Change-Id: I580635fb451b80126d10e5920e096949c3f4681e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2930359
Auto-Submit: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#893811}
This commit is contained in:
Maks Orlovich
2021-06-18 14:00:18 +00:00
committed by Chromium LUCI CQ
parent 9620d83b9b
commit 63e62cb762
1 changed files with 4 additions and 1 deletions

5
chromecast/crash/linux/synchronized_minidump_manager.cc

@ -359,7 +359,10 @@ bool SynchronizedMinidumpManager::AddEntryToLockFile(
}
bool SynchronizedMinidumpManager::RemoveEntryFromLockFile(int index) {
return dumps_->Remove(static_cast<uint64_t>(index), nullptr);
base::Value::ListView dumps_view = dumps_->GetList();
if (index < 0 || static_cast<size_t>(index) >= dumps_view.size())
return false;
return dumps_->EraseListIter(dumps_view.begin() + index);
}
void SynchronizedMinidumpManager::ReleaseLockFile() {