chromium/src
0
Fork 0
Code Activity

Expand conditions under which we'll force HLS rendering.

Browse Source 
It looks like flinging + MediaPlayer renderer can get us into situations
which cause us to use normal demuxing instead of MediaPlayer. This is
likely due to flinging not returning MediaResource::Type::URL. To fix
this, rely on |demuxer_detected_hls_| flag in addition to the type.

BUG=935755
TEST=none
R=tguilbert

Change-Id: I634c140f63942f08d1407abe5ff5d49a16d9db67
Reviewed-on: https://chromium-review.googlesource.com/c/1488069
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635369}
This commit is contained in:
Dale Curtis
2019-02-26 02:09:32 +00:00
committed by Commit Bot
parent 3644a76022
commit 65c151a58b
1 changed files with 3 additions and 2 deletions

5
media/blink/webmediaplayer_impl.cc

@ -2514,8 +2514,9 @@ void WebMediaPlayerImpl::StartPipeline() {
BindToCurrentLoop(base::BindOnce(
&WebMediaPlayerImpl::OnFirstFrame, AsWeakPtr()))));
if (renderer_factory_selector_->GetCurrentFactory()
->GetRequiredMediaResourceType() == MediaResource::Type::URL) {
if (demuxer_found_hls_ ||
renderer_factory_selector_->GetCurrentFactory()
->GetRequiredMediaResourceType() == MediaResource::Type::URL) {
// MediaPlayerRendererClient factory is the only factory that a
// MediaResource::Type::URL for the moment. This might no longer be true
// when we remove WebMediaPlayerCast.