chromium/src
0
Fork 0
Code Activity

media: add GpuArcVideoDecodeAccelerator codec profile usage UMAs

Browse Source 
This CL adds the UMAs:
Media.GpuArcVideoDecodeAccelerator.InitializeSucceeded and
Media.GpuArcVideoDecodeAccelerator.InitializeFailed.
These UMAs count successful/unsuccessful calls to
GpuArcVideoDecodeAccelerator::Initialize().

OBSOLETE_HISTOGRAM[Media.GpuArcVideoDecodeAccelerator.InitializeResult]=
Replaced by
Media.GpuArcVideoDecodeAccelerator.InitializeSucceeded and
Media.GpuArcVideoDecodeAccelerator.InitializeFailed.

Bug: None
Test: Play videos on Google Photos app and check chrome://histograms
Change-Id: I30152919e74b9a455bc3681867fc61bd102d8b98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4628631
Commit-Queue: Pilar Molina Lopez <pmolinalopez@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1164823}
This commit is contained in:
Pilar Molina Lopez
2023-06-30 18:54:04 +00:00
committed by Chromium LUCI CQ
parent c401c0f3fb
commit 65e328fa91
2 changed files with 24 additions and 8 deletions
ash/components/arc/video_accelerator
gpu_arc_video_decode_accelerator.cc
tools/metrics/histograms/metadata/media
histograms.xml

13
ash/components/arc/video_accelerator/gpu_arc_video_decode_accelerator.cc

@ -454,9 +454,16 @@ void GpuArcVideoDecodeAccelerator::OnInitializeDone(
if (result != mojom::VideoDecodeAccelerator::Result::SUCCESS)
error_state_ = true;
// Report initialization status to UMA.
UMA_HISTOGRAM_ENUMERATION(
"Media.GpuArcVideoDecodeAccelerator.InitializeResult", result);
// Report initialization status to UMAs.
if (result == mojom::VideoDecodeAccelerator::Result::SUCCESS) {
UMA_HISTOGRAM_ENUMERATION(
"Media.GpuArcVideoDecodeAccelerator.InitializeSucceeded", profile_,
media::VIDEO_CODEC_PROFILE_MAX + 1);
} else {
UMA_HISTOGRAM_ENUMERATION(
"Media.GpuArcVideoDecodeAccelerator.InitializeFailed", profile_,
media::VIDEO_CODEC_PROFILE_MAX + 1);
}
std::move(pending_init_callback_).Run(result);
RunPendingRequests();
}

19
tools/metrics/histograms/metadata/media/histograms.xml

@ -3128,14 +3128,23 @@ chromium-metrics-reviews@google.com.
</summary>
</histogram>
<histogram name="Media.GpuArcVideoDecodeAccelerator.InitializeResult"
enum="ArcVideoDecodeAcceleratorResult" expires_after="2024-06-22">
<histogram name="Media.GpuArcVideoDecodeAccelerator.InitializeFailed"
enum="VideoCodecProfile" expires_after="2024-06-29">
<owner>andrescj@chromium.org</owner>
<owner>chromeos-gfx-video@google.com</owner>
<summary>
Counts of status values returned from calls to
GpuArcVideoDecodeAccelerator::Initialize(). Warning: this histogram was
expired from 2021-02-18 to 2023-06-21; data may be missing.
Counts the unsuccessful calls to GpuArcVideoDecodeAccelerator::Initialize()
per VideoCodecProfile.
</summary>
</histogram>
<histogram name="Media.GpuArcVideoDecodeAccelerator.InitializeSucceeded"
enum="VideoCodecProfile" expires_after="2024-06-29">
<owner>andrescj@chromium.org</owner>
<owner>chromeos-gfx-video@google.com</owner>
<summary>
Counts the successful calls to GpuArcVideoDecodeAccelerator::Initialize()
per VideoCodecProfile.
</summary>
</histogram>