chromium/src
0
Fork 0
Code Activity

changes to get mac layout tests moving forward. Turn off objc GC and remove asserts in the plugin stub code that throw off the layout tests.

Browse Source 
Review URL: http://codereview.chromium.org/6588

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3026 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
pinkerton@google.com
2008-10-08 18:55:36 +00:00
parent 81c4557afa
commit 66b2bc1ccd
2 changed files with 3 additions and 4 deletions
build
common.xcconfig
webkit/port/platform
PluginStubsMac.cpp

1
build/common.xcconfig

@@ -6,7 +6,6 @@ ALWAYS_SEARCH_USER_PATHS = NO
GCC_C_LANGUAGE_STANDARD = c99
GCC_CW_ASM_SYNTAX = NO
GCC_DYNAMIC_NO_PIC = YES
GCC_ENABLE_OBJC_GC = supported
GCC_ENABLE_PASCAL_STRINGS = NO
GCC_INLINES_ARE_PRIVATE_EXTERN = YES
GCC_PRECOMPILE_PREFIX_HEADER = YES

6
webkit/port/platform/PluginStubsMac.cpp

@@ -23,7 +23,7 @@ class PluginInfoStore {
};
PluginInfo * PluginInfoStore::createPluginInfoForPluginAtIndex(unsigned) {
ASSERT_NOT_REACHED();
// TODO(pinkerton): don't assert here because that crashes layout tests.
return NULL;
}
@@ -37,7 +37,7 @@ bool PluginInfoStore::supportsMIMEType(const WebCore::String& mimeType) {
PluginData::PluginData(const Page* page)
: m_page(page) {
ASSERT_NOT_REACHED();
// TODO(pinkerton): don't assert here because that crashes layout tests.
}
PluginData::~PluginData() {
@@ -48,7 +48,7 @@ bool PluginData::supportsMimeType(const String& mimeType) const {
}
String PluginData::pluginNameForMimeType(const String& mimeType) const {
ASSERT_NOT_REACHED();
// TODO(pinkerton): don't assert here because that crashes layout tests.
return String();
}