chromium/src
0
Fork 0
Code Activity

Make reporting tests work on headless_shell

Browse Source 
This adds support for --short-reporting-delay in headless_shell,
enabling WPTs for the reporting API to work on headless_shell.

Change-Id: I168f90a783d324ec257609c92e34826ce2cd76bb
Bug: 338470458
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6069991
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Weizhong Xia <weizhong@google.com>
Cr-Commit-Position: refs/heads/main@{#1431340}
This commit is contained in:
Antonio Sartori
2025-03-11 22:47:53 -07:00
committed by Chromium LUCI CQ
parent 797a445dc8
commit 66c9a78def
3 changed files with 13 additions and 6 deletions
headless/lib/browser
headless_request_context_manager.cc
third_party/blink/web_tests/TestLists
chrome.filtercontent_shell.filter

8
headless/lib/browser/headless_request_context_manager.cc

@ -4,11 +4,13 @@
#include "headless/lib/browser/headless_request_context_manager.h"
#include "base/check_deref.h"
#include "base/command_line.h"
#include "base/feature_list.h"
#include "base/functional/bind.h"
#include "base/task/single_thread_task_runner.h"
#include "build/build_config.h"
#include "components/embedder_support/switches.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/network_service_instance.h"
#include "headless/lib/browser/headless_browser_context_options.h"
@ -233,6 +235,12 @@ void HeadlessRequestContextManager::ConfigureNetworkContextParamsInternal(
context_params->accept_language = accept_language_;
context_params->enable_zstd = true;
const base::CommandLine& command_line =
CHECK_DEREF(base::CommandLine::ForCurrentProcess());
if (command_line.HasSwitch(embedder_support::kShortReportingDelay)) {
context_params->reporting_delivery_interval = base::Milliseconds(100);
}
// TODO(crbug.com/40405715): Allow
// context_params->http_auth_static_network_context_params->allow_default_credentials
// to be controllable by a flag.

2
third_party/blink/web_tests/TestLists/chrome.filter vendored

@ -49,7 +49,6 @@ external/wpt/client-hints/sandbox/iframe-same-origin.https.html
external/wpt/cookies/attributes/max-age.html
external/wpt/fetch/fetch-later/new-window.tentative.https.window.html
external/wpt/html/browsers/the-window-object/window-open-windowfeatures-values.html
external/wpt/html/cross-origin-opener-policy/reporting/navigation-reporting/report-only-same-origin-report-to.https.html
external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-iframe-messagechannel.https.html
external/wpt/notifications/cross-origin-serviceworker.tentative.https.sub.html
external/wpt/notifications/event-onclose.https.html
@ -57,7 +56,6 @@ external/wpt/notifications/instance.https.window.html
external/wpt/notifications/permissions-non-secure.html
external/wpt/notifications/shownotification-without-permission.https.window.html
external/wpt/notifications/shownotification.https.window.html
external/wpt/permissions-policy/reporting/report-only-single-endpoint.https.sub.html
external/wpt/service-workers/service-worker/controller-on-reload.https.html
external/wpt/service-workers/service-worker/fetch-request-xhr.https.html
external/wpt/speech-api/SpeechRecognition-availableOnDevice.https.html

9
third_party/blink/web_tests/TestLists/content_shell.filter vendored

@ -48,7 +48,6 @@ external/wpt/compat/webkit-box-clamp-bottom-border.html
external/wpt/compat/webkit-box-horizontal-rtl-variants.html
external/wpt/compat/webkit-box-rtl-flex.html
external/wpt/console/console-log-large-array.any.html
external/wpt/content-security-policy/reporting-api/*
external/wpt/content-security-policy/report-hash/*
external/wpt/cookie-store/cookieStore_subscribe_arguments.https.any.html
external/wpt/cookies/attributes/attributes-ctl.sub.html
@ -663,7 +662,6 @@ external/wpt/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.t
external/wpt/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transferrable.w.html
external/wpt/html/cross-origin-embedder-policy/credentialless/service-worker.https.window.html
external/wpt/html/cross-origin-embedder-policy/reflection-require-corp.tentative.https.any.*
external/wpt/html/cross-origin-embedder-policy/reporting-to-document-reporting-endpoint.https.window.html
external/wpt/html/cross-origin-embedder-policy/shared-workers.https.html
external/wpt/html/cross-origin-opener-policy/coop-coep-sandbox.https.html
external/wpt/html/cross-origin-opener-policy/header-parsing-non-ascii.https.html
@ -808,7 +806,11 @@ external/wpt/payment-request/onpaymentmethodchange-attribute.https.html
external/wpt/payment-request/show-consume-activation.https.html
external/wpt/performance-timeline/not-restored-reasons/abort-block-bfcache.window.html
external/wpt/permissions-policy/bluetooth-*
external/wpt/permissions-policy/reporting/*
external/wpt/permissions-policy/reporting/bluetooth-*
external/wpt/permissions-policy/reporting/report-only-and-enforce.https.sub.html
external/wpt/permissions-policy/reporting/report-only-single-endpoint.https.sub.html
external/wpt/permissions-policy/reporting/report-to-multiple-endpoints.https.sub.html
external/wpt/permissions-policy/reporting/report-to-single-endpoint.https.sub.html
external/wpt/pointerevents/capturing_boundary_event_handler_at_ua_shadowdom.html*
external/wpt/pointerevents/coalesced_events_attributes_under_load.https.optional.html*
external/wpt/pointerevents/compat/pointerevent_mouse-pointer-on-scrollbar.html
@ -821,7 +823,6 @@ external/wpt/pointerevents/pointerevent_sequence_at_implicit_release_on_drag.htm
external/wpt/pointerevents/pointerevent_touch-action-modified_touch.html
external/wpt/preload/link-header-preload-non-html.html
external/wpt/preload/preconnect-onerror-event.html
external/wpt/reporting/*
external/wpt/resize-observer/callback-cross-realm-report-exception.html
external/wpt/resize-observer/scrollbars.html
external/wpt/resize-observer/svg.html