0

Remove debugging code from EventRouter.

In EventRouter::DoDispatchEventToSenderBookkeeping(), a logging call to
help debug a crash should have been removed over a year ago. Remove it
and also rewrite the method to be a little cleaner.

Bug: 897946
Change-Id: I91b6fbbc0971dd86ed3e2a346de1ee4e2dc26ed2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2914119
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Auto-Submit: Lei Zhang <thestig@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#886243}
This commit is contained in:
Lei Zhang
2021-05-25 11:16:04 +00:00
committed by Chromium LUCI CQ
parent 41e92362a0
commit 66e07e4f9f

@ -864,27 +864,22 @@ void EventRouter::DoDispatchEventToSenderBookkeeping(
events::HistogramValue histogram_value,
const std::string& event_name) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
// TODO(https://crbug.com/897946): Remove after investigating the bug.
if (ExtensionsBrowserClient::Get()->IsShuttingDown()) {
LOG(ERROR)
<< "Event dispatched while shutting down extensions browser client.";
return;
}
if (!ExtensionsBrowserClient::Get()->IsValidContext(browser_context))
return;
DCHECK(ExtensionRegistry::Get(browser_context));
auto* registry = ExtensionRegistry::Get(browser_context);
DCHECK(registry);
const Extension* extension =
ExtensionRegistry::Get(browser_context)->enabled_extensions().GetByID(
extension_id);
registry->enabled_extensions().GetByID(extension_id);
if (!extension)
return;
EventRouter* event_router = EventRouter::Get(browser_context);
DCHECK(event_router);
event_router->IncrementInFlightEvents(
browser_context, RenderProcessHost::FromID(render_process_id), extension,
event_id, event_name, service_worker_version_id);
event_router->ReportEvent(histogram_value, extension,
false /* did_enqueue */);
event_router->ReportEvent(histogram_value, extension, /*did_enqueue=*/false);
}
void EventRouter::IncrementInFlightEvents(BrowserContext* context,