chromium/src
0
Fork 0
Code Activity

CodeHealth: Remove use of Value::GetAsBoolean

Browse Source 
This change removes the use of Value::GetAsBoolean
and replaces with Value::is_bool(), Value::GetBool().
Value::GetBool() will CHECK that type matches.

https://source.chromium.org/chromium/chromium/src/+/master:base/values.h;l=199;drc=677e0c87cbbc129eb8b65c47036b19292c725127

Bug: 1187003
Change-Id: Ic0116543a8706e472505dd5a6c74e860d9af9e56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2828694
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874517}
This commit is contained in:
Ayu Ishii
2021-04-21 01:17:40 +00:00
committed by Chromium LUCI CQ
parent 57cffdf2d3
commit 68ff226525
3 changed files with 3 additions and 11 deletions

5
dbus/values_util.cc

@ -218,10 +218,7 @@ std::unique_ptr<base::Value> PopDataAsValue(MessageReader* reader) {
void AppendBasicTypeValueData(MessageWriter* writer, const base::Value& value) {
switch (value.type()) {
case base::Value::Type::BOOLEAN: {
bool bool_value = false;
bool success = value.GetAsBoolean(&bool_value);
DCHECK(success);
writer->AppendBool(bool_value);
writer->AppendBool(value.GetBool());
break;
}
case base::Value::Type::INTEGER: {

5
ipc/ipc_message_utils.cc

@ -95,10 +95,7 @@ void WriteValue(base::Pickle* m, const base::Value* value, int recursion) {
case base::Value::Type::NONE:
break;
case base::Value::Type::BOOLEAN: {
bool val;
result = value->GetAsBoolean(&val);
DCHECK(result);
WriteParam(m, val);
WriteParam(m, value->GetBool());
break;
}
case base::Value::Type::INTEGER: {

4
ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc

@ -44,9 +44,7 @@ PP_Var PPB_X509Certificate_Fields::GetFieldAsPPVar(
case base::Value::Type::NONE:
return PP_MakeNull();
case base::Value::Type::BOOLEAN: {
bool val;
value->GetAsBoolean(&val);
return PP_MakeBool(PP_FromBool(val));
return PP_MakeBool(PP_FromBool(value->GetBool()));
}
case base::Value::Type::INTEGER: {
return PP_MakeInt32(value->GetInt());