Exclude top of NOTREACHED tail still hit in stable

This includes the top ~30 in M128 and ~20 in M127 on ChromeOS.
... except the few ones I can't find due to ICF, or ones that have
already been fixed or removed as erroneous.

This is to further derisk NOTREACHED-fatal rollout. Per crash-reporting
volumes on Windows we should be about 1/50 as crashy as CHECK failures
after this has landed.

     40264195, 40895492, 354661907, 363109548, 361609999, 352381196,
     361612971, 362124606, 355803743, 41369768, 345232410, 346893376,
     40910294

Bug: 40580068, 332263206, 40942310, 40948203, 355803743, 362506636,
Change-Id: I56e42b3b7c8ce17d6dabb5d7edb48db925240e34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5824114
Owners-Override: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1349061}

ash/login/ui/login_base_bubble_view.cc

@@ -336,7 +336,7 @@ views::View* LoginBaseBubbleView::GetAnchorView() const {
   if (anchor_view_.WasInvalidated()) {
     // TODO(crbug.com/1171827): This is to detect dangling anchor_view_
     // pointers.
-    NOTREACHED();
+    DUMP_WILL_BE_NOTREACHED();
   }
   return anchor_view_.get();
 }

ash/wm/desks/desk_bar_view_base.cc

@@ -1334,7 +1334,7 @@ void DeskBarViewBase::HandleDragEvent(DeskMiniView* mini_view,
       ContinueDragDesk(mini_view, location);
       break;
     default:
-      NOTREACHED();
+      DUMP_WILL_BE_NOTREACHED();
   }
 }
 

base/metrics/sample_vector.cc

@@ -370,9 +370,10 @@ bool SampleVectorBase::AddSubtractImpl(SampleCountIterator* iter,
       SCOPED_CRASH_KEY_NUMBER("SampleVector", "range_max",
                               bucket_ranges_->range(dest_index + 1));
 #endif  // !BUILDFLAG(IS_NACL)
-      NOTREACHED() << "sample=" << min << "," << max
-                   << "; range=" << bucket_ranges_->range(dest_index) << ","
-                   << bucket_ranges_->range(dest_index + 1);
+      DUMP_WILL_BE_NOTREACHED()
+          << "sample=" << min << "," << max
+          << "; range=" << bucket_ranges_->range(dest_index) << ","
+          << bucket_ranges_->range(dest_index + 1);
     }
 
     // Sample's bucket matches exactly. Adjust count.

chrome/browser/ash/login/signin/token_handle_util.cc

@@ -242,7 +242,7 @@ void TokenHandleUtil::OnStatusChecked(TokenValidationCallback callback,
   const user_manager::User* user =
       user_manager::UserManager::Get()->FindUser(account_id);
   if (!user) {
-    NOTREACHED_IN_MIGRATION() << "Invalid user";
+    DUMP_WILL_BE_NOTREACHED() << "Invalid user";
     FinishWithStatus(std::move(callback), token, account_id, status,
                      /*user_has_gaia_password=*/true);
     return;

chrome/browser/cart/cart_discount_fetcher.cc

@@ -326,12 +326,12 @@ CouponDiscountInfo ConvertToCouponDiscountInfo(
 
 bool ValidateResponse(const std::optional<base::Value>& response) {
   if (!response) {
-    NOTREACHED_IN_MIGRATION() << "Response is not valid";
+    DUMP_WILL_BE_NOTREACHED() << "Response is not valid";
     return false;
   }
 
   if (!response->is_dict()) {
-    NOTREACHED_IN_MIGRATION()
+    DUMP_WILL_BE_NOTREACHED()
         << "Wrong response format, response is not a dictionary. Response: "
         << response->DebugString();
     return false;

chrome/browser/download/notification/download_item_notification.cc

@@ -1006,7 +1006,7 @@ std::u16string DownloadItemNotification::GetWarningStatusString() const {
     case download::DOWNLOAD_DANGER_TYPE_PROMPT_FOR_LOCAL_PASSWORD_SCANNING:
     case download::DOWNLOAD_DANGER_TYPE_ASYNC_LOCAL_PASSWORD_SCANNING: {
       // TODO(crbug.com/40074456): Implement UX for this danger type.
-      NOTREACHED_IN_MIGRATION();
+      DUMP_WILL_BE_NOTREACHED();
       break;
     }
     case download::DOWNLOAD_DANGER_TYPE_BLOCKED_SCAN_FAILED: {

chrome/browser/extensions/extension_context_menu_model.cc

@@ -165,7 +165,7 @@ ExtensionContextMenuModel::ContextMenuAction CommandIdToContextMenuAction(
     default:
       break;
   }
-  NOTREACHED_IN_MIGRATION();
+  DUMP_WILL_BE_NOTREACHED();
   return ContextMenuAction::kNoAction;
 }
 

chrome/browser/first_run/upgrade_util_win.cc

@@ -402,7 +402,7 @@ bool DoUpgradeTasks(const base::CommandLine& command_line) {
   // At this point the chrome.exe has been swapped with the new one.
   if (!RelaunchChromeBrowser(command_line)) {
     // The relaunch failed. Feel free to panic now.
-    NOTREACHED_IN_MIGRATION();
+    DUMP_WILL_BE_NOTREACHED();
   }
   return true;
 }

chrome/browser/ui/views/permissions/chip/permission_dashboard_controller.cc

@@ -577,7 +577,7 @@ std::u16string PermissionDashboardController::GetIndicatorTitle(
       return l10n_util::GetStringUTF16(IDS_MICROPHONE_NOT_ALLOWED);
     }
 
-    NOTREACHED_IN_MIGRATION();
+    DUMP_WILL_BE_NOTREACHED();
     return std::u16string();
   }
 

chrome/browser/ui/webui/ash/cloud_upload/cloud_upload_dialog.cc

@@ -368,7 +368,7 @@ void OnWaitingForAndroidUnsupportedPathFallbackChoiceReceived(
     std::unique_ptr<ash::cloud_upload::CloudOpenMetrics> cloud_open_metrics,
     std::optional<const std::string> choice) {
   if (!IsOpenInOfficeTask(task)) {
-    NOTREACHED_IN_MIGRATION();
+    DUMP_WILL_BE_NOTREACHED();
     return;
   }
 

chrome/browser/web_applications/os_integration/web_app_uninstallation_via_os_settings_registration.cc

@@ -29,7 +29,7 @@ bool RegisterUninstallationViaOsSettingsWithOs(
 bool UnregisterUninstallationViaOsSettingsWithOs(
     const webapps::AppId& app_id,
     const base::FilePath& profile_path) {
-  NOTREACHED_IN_MIGRATION();
+  DUMP_WILL_BE_NOTREACHED();
   return true;
 }
 

components/autofill/core/browser/webdata/autocomplete/autocomplete_table.cc

@@ -323,7 +323,7 @@ int AutocompleteTable::GetCountOfValuesContainedBetween(base::Time begin,
   s.BindInt64(1, end_time_t);
 
   if (!s.Step()) {
-    NOTREACHED_IN_MIGRATION();
+    DUMP_WILL_BE_NOTREACHED();
     return false;
   }
   return s.ColumnInt(0);

components/performance_manager/service_worker_context_adapter.cc

@@ -207,12 +207,12 @@ void ServiceWorkerContextAdapterImpl::OnControlleeNavigationCommitted(
   // not already a client of |version_id|.
   auto it = service_worker_clients_.find(version_id);
   if (it == service_worker_clients_.end()) {
-    NOTREACHED_IN_MIGRATION();
+    DUMP_WILL_BE_NOTREACHED();
     return;
   }
 
   if (it->second.find(client_uuid) == it->second.end()) {
-    NOTREACHED_IN_MIGRATION();
+    DUMP_WILL_BE_NOTREACHED();
     return;
   }
 

components/permissions/permission_uma_util.cc

@@ -1667,7 +1667,7 @@ void PermissionUmaUtil::RecordPageInfoPermissionChange(
       base::UmaHistogramEnumeration(histogram_name,
                                     PermissionChangeAction::RESET_FROM_DENIED);
     } else {
-      NOTREACHED_IN_MIGRATION();
+      DUMP_WILL_BE_NOTREACHED();
     }
   } else if (setting_before == ContentSetting::CONTENT_SETTING_ALLOW) {
     if (setting_after == ContentSetting::CONTENT_SETTING_BLOCK) {

components/policy/core/common/device_local_account_type.cc

@@ -80,7 +80,7 @@ GetDeviceLocalAccountType(std::string_view user_id) {
   }
 
   // |user_id| is a device-local account but its type is not recognized.
-  NOTREACHED_IN_MIGRATION();
+  DUMP_WILL_BE_NOTREACHED();
   return base::unexpected(GetDeviceLocalAccountTypeError::kUnknownDomain);
 }
 

components/sessions/core/session_service_commands.cc

@@ -222,7 +222,7 @@ ui::WindowShowState PersistedShowStateToShowState(int state) {
     case PERSISTED_SHOW_STATE_DOCKED_DEPRECATED:
       return ui::SHOW_STATE_NORMAL;
   }
-  NOTREACHED_IN_MIGRATION();
+  DUMP_WILL_BE_NOTREACHED();
   return ui::SHOW_STATE_NORMAL;
 }
 

components/user_manager/user_manager_base.cc

@@ -396,24 +396,24 @@ void UserManagerBase::UserLoggedIn(const AccountId& account_id,
 void UserManagerBase::SwitchActiveUser(const AccountId& account_id) {
   User* user = FindUserAndModify(account_id);
   if (!user) {
-    NOTREACHED_IN_MIGRATION() << "Switching to a non-existing user";
+    DUMP_WILL_BE_NOTREACHED() << "Switching to a non-existing user";
     return;
   }
   if (user == active_user_) {
-    NOTREACHED_IN_MIGRATION() << "Switching to a user who is already active";
+    DUMP_WILL_BE_NOTREACHED() << "Switching to a user who is already active";
     return;
   }
   if (!user->is_logged_in()) {
-    NOTREACHED_IN_MIGRATION() << "Switching to a user that is not logged in";
+    DUMP_WILL_BE_NOTREACHED() << "Switching to a user that is not logged in";
     return;
   }
   if (!user->HasGaiaAccount()) {
-    NOTREACHED_IN_MIGRATION()
+    DUMP_WILL_BE_NOTREACHED()
         << "Switching to a user without gaia account (non-regular one)";
     return;
   }
   if (user->username_hash().empty()) {
-    NOTREACHED_IN_MIGRATION()
+    DUMP_WILL_BE_NOTREACHED()
         << "Switching to a user that doesn't have username_hash set";
     return;
   }

content/browser/indexed_db/indexed_db_leveldb_coding.cc

@@ -896,7 +896,7 @@ static blink::mojom::IDBKeyType KeyTypeByteToKeyType(unsigned char type) {
       return blink::mojom::IDBKeyType::Min;
   }
 
-  NOTREACHED_IN_MIGRATION() << "Got invalid type " << type;
+  DUMP_WILL_BE_NOTREACHED() << "Got invalid type " << type;
   return blink::mojom::IDBKeyType::Invalid;
 }
 

content/browser/renderer_host/render_widget_host_view_child_frame.cc

@@ -1040,7 +1040,7 @@ RenderWidgetHostViewChildFrame::FilterInputEvent(
     if (gesture_event.SourceDevice() == blink::WebGestureDevice::kTouchscreen) {
       return blink::mojom::InputEventResultState::kConsumed;
     }
-    NOTREACHED_IN_MIGRATION();
+    DUMP_WILL_BE_NOTREACHED();
   }
 
   if (input_event.GetType() == blink::WebInputEvent::Type::kGestureFlingStart) {

content/child/child_thread_impl.cc

@@ -908,7 +908,7 @@ void ChildThreadImpl::OnAssociatedInterfaceRequest(
   // All associated interfaces are requested through RenderThreadImpl.
   LOG(ERROR) << "Receiver for unknown Channel-associated interface: "
              << interface_name;
-  NOTREACHED_IN_MIGRATION();
+  DUMP_WILL_BE_NOTREACHED();
 }
 
 void ChildThreadImpl::ExposeInterfacesToBrowser(mojo::BinderMap binders) {

extensions/browser/api/bluetooth/bluetooth_api_utils.cc

@@ -39,7 +39,7 @@ bool ConvertVendorIDSourceToApi(const BluetoothDevice::VendorIDSource& input,
       *output = bluetooth::VendorIdSource::kUsb;
       return true;
     default:
-      NOTREACHED_IN_MIGRATION();
+      DUMP_WILL_BE_NOTREACHED();
       return false;
   }
 }

extensions/browser/api/runtime/runtime_api.cc

@@ -890,7 +890,7 @@ RuntimeGetContextsFunction::GetFrameContexts() {
       case mojom::ViewType::kBackgroundContents:
       case mojom::ViewType::kComponent:
       case mojom::ViewType::kExtensionBackgroundPage:
-        NOTREACHED_IN_MIGRATION();
+        DUMP_WILL_BE_NOTREACHED();
         break;
 
       case mojom::ViewType::kExtensionPopup:

extensions/browser/api/usb/usb_api.cc

@@ -218,7 +218,7 @@ const char* ConvertTransferStatusToApi(const UsbTransferStatus status) {
     case UsbTransferStatus::SHORT_PACKET:
       return kErrorTransferLength;
     default:
-      NOTREACHED_IN_MIGRATION();
+      DUMP_WILL_BE_NOTREACHED();
       return "";
   }
 }

extensions/browser/extension_registrar.cc

@@ -87,7 +87,7 @@ void ExtensionRegistrar::AddExtension(
       // but that's caused problems. There are apparently times when this
       // happens that we aren't accounting for. We should track those down and
       // fix them, but it can be tricky.
-      NOTREACHED_IN_MIGRATION()
+      DUMP_WILL_BE_NOTREACHED()
           << "Attempted to downgrade extension." << "\nID: " << extension->id()
           << "\nOld Version: " << old->version()
           << "\nNew Version: " << extension->version()

services/network/cors/cors_url_loader.cc

@@ -1204,7 +1204,7 @@ void CorsURLLoader::HandleComplete(URLLoaderCompletionStatus status) {
 
     // DCHECK that we never run into this scenario, but fail the request for
     // safety if this ever happens in production.
-    NOTREACHED_IN_MIGRATION();
+    DUMP_WILL_BE_NOTREACHED();
   }
 
   status.private_network_access_preflight_result =

storage/browser/file_system/obfuscated_file_util.cc

@@ -805,7 +805,7 @@ base::File::Error ObfuscatedFileUtil::DeleteFile(
       -UsageForPath(file_info.name.size()) - platform_file_info.size;
   AllocateQuota(context, growth);
   if (!db->RemoveFileInfo(file_id)) {
-    NOTREACHED_IN_MIGRATION();
+    DUMP_WILL_BE_NOTREACHED();
     return base::File::FILE_ERROR_FAILED;
   }
   UpdateUsage(context, url, growth);

third_party/blink/renderer/core/css/css_math_expression_node.cc

@@ -855,7 +855,7 @@ double CSSMathExpressionNumericLiteral::DoubleValue() const {
   if (HasDoubleValue(ResolvedUnitType())) {
     return value_->GetDoubleValueWithoutClamping();
   }
-  NOTREACHED_IN_MIGRATION();
+  DUMP_WILL_BE_NOTREACHED();
   return 0;
 }
 

third_party/blink/renderer/core/html/forms/input_type.cc

@@ -563,7 +563,7 @@ String InputType::BadInputText() const {
 }
 
 String InputType::ValueNotEqualText(const Decimal& value) const {
-  NOTREACHED_IN_MIGRATION();
+  DUMP_WILL_BE_NOTREACHED();
   return String();
 }
 

third_party/blink/renderer/core/layout/inline/fragment_items_builder.cc

@@ -320,7 +320,7 @@ FragmentItemsBuilder::AddPreviousItems(const PhysicalBoxFragment& container,
         }
         if (!current_items_data->IsValidOffset(break_token->Start()))
             [[unlikely]] {
-          NOTREACHED_IN_MIGRATION();
+          DUMP_WILL_BE_NOTREACHED();
           break;
         }
 

third_party/blink/renderer/core/layout/inline/inline_caret_position.cc

@@ -455,7 +455,7 @@ InlineCaretPosition ComputeInlineCaretPosition(
   if (!mapping) {
     // TODO(yosin): We should find when we reach here[1].
     // [1] http://crbug.com/1100481
-    NOTREACHED_IN_MIGRATION() << context;
+    DUMP_WILL_BE_NOTREACHED() << context;
     return InlineCaretPosition();
   }
   const std::optional<unsigned> maybe_offset =
@@ -523,7 +523,7 @@ PositionWithAffinity InlineCaretPosition::ToPositionInDOMTreeWithAffinity()
         // TODO(yosin): We're not sure why |mapping| is |nullptr|. It seems
         // we are attempt to use destroyed/moved |FragmentItem|.
         // See http://crbug.com/1145514
-        NOTREACHED_IN_MIGRATION()
+        DUMP_WILL_BE_NOTREACHED()
             << cursor << " " << cursor.Current().GetLayoutObject();
         return PositionWithAffinity();
       }

third_party/blink/renderer/core/layout/layout_block.cc

@@ -334,7 +334,7 @@ void LayoutBlock::Paint(const PaintInfo& paint_info) const {
 
   // Avoid painting dirty objects because descendants maybe already destroyed.
   if (NeedsLayout() && !ChildLayoutBlockedByDisplayLock()) [[unlikely]] {
-    NOTREACHED_IN_MIGRATION();
+    DUMP_WILL_BE_NOTREACHED();
     return;
   }
 

third_party/blink/renderer/core/layout/layout_inline.cc

@@ -626,7 +626,7 @@ bool LayoutInline::NodeAtPoint(HitTestResult& result,
     // TODO(crbug.com/965976): We should fix the root cause of the missed
     // layout.
     if (NeedsLayout()) [[unlikely]] {
-      NOTREACHED_IN_MIGRATION();
+      DUMP_WILL_BE_NOTREACHED();
       return false;
     }
 

ui/base/resource/resource_bundle.cc

@@ -241,8 +241,8 @@ class ResourceBundle::BitmapImageSource : public gfx::ImageSkiaSource {
       // TODO(oshima): Android unit_tests runs at DSF=3 with 100P assets.
       return gfx::ImageSkiaRep();
 #else
-      NOTREACHED() << "Unable to load bitmap image with id " << resource_id_
-                   << ", scale=" << scale;
+      DUMP_WILL_BE_NOTREACHED() << "Unable to load bitmap image with id "
+                                << resource_id_ << ", scale=" << scale;
 #endif
     }
 

ui/gl/gl_bindings_autogen_gl.cc

@@ -14488,7 +14488,7 @@ void LogGLApi::glWindowRectanglesEXTFn(GLenum mode,
 
 namespace {
 void NoContextHelper(const char* method_name) {
-  NOTREACHED_IN_MIGRATION()
+  DUMP_WILL_BE_NOTREACHED()
       << "Trying to call " << method_name << " without current GL context";
   LOG(ERROR) << "Trying to call " << method_name
              << " without current GL context";