chromium/src
0
Fork 0
Code Activity

build: Remove a few now-no-op set_sources_assignment_filter calls

Browse Source 
After https://chromium-review.googlesource.com/c/chromium/src/+/2426564,
not having a sources assignments filter is the default.

No behavior change.

Bug: 1018739
Change-Id: Ia0f215c50d4381f74e3a5ae8db539312b7f391b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434084
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811177}
This commit is contained in:
Nico Weber
2020-09-28 10:35:35 +00:00
committed by Commit Bot
parent 22f03e2631
commit 6a010201df
44 changed files with 0 additions and 247 deletions
base
BUILD.gn
test
BUILD.gn
util
memory_pressure
BUILD.gn
chrome
browser
BUILD.gn
extensions
BUILD.gn
resources
chromeos
accessibility
chromevox
BUILD.gn
ui
BUILD.gn
common
BUILD.gn
updater
BUILD.gn
device_management
BUILD.gn
components
autofill
core
browser
BUILD.gn
dom_distiller
core
BUILD.gn
gcm_driver
BUILD.gn
instance_id
BUILD.gn
metrics
BUILD.gn
open_from_clipboard
BUILD.gn
os_crypt
BUILD.gn
password_manager
core
browser
BUILD.gn
policy
core
common
BUILD.gn
rlz
BUILD.gn
search
BUILD.gn
signin
internal
identity_manager
BUILD.gn
sync_device_info
BUILD.gn
update_client
BUILD.gn
url_formatter
BUILD.gn
skia
BUILD.gn
ui
accessibility
BUILD.gn
base
BUILD.gn
clipboard
BUILD.gn
idle
BUILD.gn
compositor
BUILD.gn
display
BUILD.gn
events
BUILD.gn
devices
BUILD.gn
gfx
BUILD.gn
animation
BUILD.gn
range
BUILD.gn
gl
BUILD.gn
native_theme
BUILD.gn
shell_dialogs
BUILD.gn
snapshot
BUILD.gn
views
BUILD.gn
controls
webview
BUILD.gn
views_content_client
BUILD.gn

6
base/BUILD.gn

@ -42,12 +42,6 @@ if (is_mac) {
import("//third_party/protobuf/proto_library.gni")
}
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
declare_args() {
# Indicates if the Location object contains the source code information
# (file, function, line). False means only the program counter (and currently

6
base/test/BUILD.gn

@ -7,12 +7,6 @@ import("//build/config/nacl/config.gni")
import("//build/config/ui.gni")
import("//build_overrides/build.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
if (is_android) {
import("//build/config/android/rules.gni")
}

6
base/util/memory_pressure/BUILD.gn

@ -2,12 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
source_set("memory_pressure") {
sources = [
"memory_pressure_voter.cc",

6
chrome/browser/BUILD.gn

@ -52,12 +52,6 @@ if (is_win) {
additional_modules_list_file =
"$root_gen_dir/chrome/browser/internal/additional_modules_list.txt"
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
if (is_win) {
# This is in a separate config so the flags can be applied to dependents.
# ldflags in GN aren't automatically inherited.

3
chrome/browser/extensions/BUILD.gn

@ -15,9 +15,6 @@ import("//rlz/buildflags/buildflags.gni")
assert(enable_extensions)
# See docs/no_sources_assignment_filter.md and https://crbug.com/1018739.
set_sources_assignment_filter([])
static_library("extensions") {
sources = [
"active_install_data.cc",

3
chrome/browser/resources/chromeos/accessibility/chromevox/BUILD.gn

@ -10,9 +10,6 @@ import("//chrome/test/base/js2gtest.gni")
import("//testing/test.gni")
import("//third_party/closure_compiler/compile_js.gni")
# Prevent Chromium source assignment filters from being inherited.
set_sources_assignment_filter([])
declare_args() {
# Whether to compress the main Chromevox javascript files or load the
# modules individually from source files.

6
chrome/browser/ui/BUILD.gn

@ -28,12 +28,6 @@ import("//ui/base/ui_features.gni")
import("//ui/ozone/ozone.gni")
import("//ui/views/features.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
# Use a static library here because many test binaries depend on this but don't
# require many files from it. This makes linking more efficient.
static_library("ui") {

3
chrome/common/BUILD.gn

@ -22,9 +22,6 @@ if (enable_pdf) {
assert(enable_plugins, "PDF support requires plugins be enabled.")
}
# See docs/no_sources_assignment_filter.md and https://crbug.com/1018739.
set_sources_assignment_filter([])
grit("resources") {
source = "common_resources.grd"
defines = chrome_grit_defines

2
chrome/updater/BUILD.gn

@ -12,8 +12,6 @@ import("//testing/test.gni")
# dependencies are modified until a presubmit is written to automatically
# check that the C++ includes match the build dependency graph.
set_sources_assignment_filter([])
# TODO(sorin): make the code build on Linux. https://crbug.com/1014320
group("updater") {
if (is_win) {

2
chrome/updater/device_management/BUILD.gn

@ -8,8 +8,6 @@ import("//build/util/process_version.gni")
import("//chrome/updater/branding.gni")
import("//testing/test.gni")
set_sources_assignment_filter([])
source_set("device_management") {
sources = [
"dm_cached_policy_info.cc",

6
components/autofill/core/browser/BUILD.gn

@ -7,12 +7,6 @@ import("//build/util/version.gni")
import("//testing/libfuzzer/fuzzer_test.gni")
import("//tools/grit/grit_rule.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
grit("autofill_address_rewriter_resources") {
source = "autofill_address_rewriter_resources.grd"
outputs = [

6
components/dom_distiller/core/BUILD.gn

@ -2,12 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
static_library("core") {
sources = [
"article_distillation_update.cc",

6
components/gcm_driver/BUILD.gn

@ -5,12 +5,6 @@
import("//build/buildflag_header.gni")
import("//components/gcm_driver/config.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
buildflag_header("gcm_buildflags") {
header = "gcm_buildflags.h"
flags = [ "USE_GCM_FROM_PLATFORM=$use_gcm_from_platform" ]

6
components/gcm_driver/instance_id/BUILD.gn

@ -8,12 +8,6 @@ if (is_android) {
import("//build/config/android/rules.gni")
}
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
static_library("instance_id") {
sources = [
"instance_id.cc",

6
components/metrics/BUILD.gn

@ -8,12 +8,6 @@ if (is_android) {
import("//build/config/android/rules.gni")
}
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
static_library("demographic_metrics_provider") {
sources = [
"demographic_metrics_provider.cc",

6
components/open_from_clipboard/BUILD.gn

@ -2,12 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
static_library("open_from_clipboard") {
sources = [
"clipboard_recent_content.cc",

6
components/os_crypt/BUILD.gn

@ -8,12 +8,6 @@ import("//build/config/linux/pkg_config.gni")
import("//build/config/ui.gni")
import("//components/os_crypt/features.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
if (use_gnome_keyring) {
# Gnome-keyring is normally dynamically loaded. The gnome_keyring config
# will set this up.

6
components/password_manager/core/browser/BUILD.gn

@ -9,12 +9,6 @@ if (is_android) {
import("//build/config/android/config.gni")
}
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
# TODO(crbug.com/1006430): Fix password reuse detection not fully functional on
# Android.
password_reuse_detection_support = !is_ios

6
components/policy/core/common/BUILD.gn

@ -5,12 +5,6 @@
import("//build/config/features.gni")
import("//testing/libfuzzer/fuzzer_test.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
group("common") {
if (is_component_build) {
public_deps = [ "//components/policy" ]

6
components/rlz/BUILD.gn

@ -2,12 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
static_library("rlz") {
sources = [
"rlz_tracker.cc",

6
components/search/BUILD.gn

@ -2,12 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
static_library("search") {
sources = [
"search.cc",

6
components/signin/internal/identity_manager/BUILD.gn

@ -4,12 +4,6 @@
import("//components/signin/features.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
# This target forms the core of the IdentityManager implementation
# (//components/signin/public/identity_manager/identity_manager.*).
source_set("identity_manager") {

6
components/sync_device_info/BUILD.gn

@ -4,12 +4,6 @@
import("//build/config/features.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
static_library("sync_device_info") {
sources = [
"device_count_metrics_provider.cc",

6
components/update_client/BUILD.gn

@ -5,12 +5,6 @@
import("//net/features.gni")
import("//testing/libfuzzer/fuzzer_test.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
source_set("network_impl") {
sources = [
"net/network_chromium.h",

6
components/url_formatter/BUILD.gn

@ -6,12 +6,6 @@ if (is_android) {
import("//build/config/android/rules.gni")
}
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
static_library("skeleton_generator") {
sources = [
"spoof_checks/skeleton_generator.cc",

6
skia/BUILD.gn

@ -23,12 +23,6 @@ if (current_cpu == "mipsel" || current_cpu == "mips64el") {
import("//build/config/mips.gni")
}
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
skia_support_gpu = !is_ios
skia_support_pdf = !is_ios && enable_basic_printing
skia_support_skottie = true

6
ui/accessibility/BUILD.gn

@ -19,12 +19,6 @@ if (is_win) {
import("//build/toolchain/win/midl.gni")
}
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
mojom("ax_constants_mojo") {
sources = [ "ax_constants.mojom" ]
}

6
ui/base/BUILD.gn

@ -23,12 +23,6 @@ if (is_android) {
import("//build/config/mac/rules.gni")
}
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
build_ime = !is_ios
# As part of building Chrome on iOS, it is necessary to run a tool on

6
ui/base/clipboard/BUILD.gn

@ -6,12 +6,6 @@ import("///ui/ozone/ozone.gni")
import("//build/config/chromeos/ui_mode.gni")
import("//build/config/ui.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
component("clipboard_types") {
output_name = "ui_base_clipboard_types"
sources = [

6
ui/base/idle/BUILD.gn

@ -8,12 +8,6 @@ if (is_mac) {
import("//build/config/mac/rules.gni")
}
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
component("idle") {
output_name = "ui_base_idle"

6
ui/compositor/BUILD.gn

@ -5,12 +5,6 @@
import("//build/config/ui.gni")
import("//testing/test.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
component("compositor") {
sources = [
"animation_metrics_recorder.cc",

6
ui/display/BUILD.gn

@ -6,12 +6,6 @@ import("//build/config/ui.gni")
import("//testing/test.gni")
import("//ui/display/display.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
component("display") {
sources = [
"display.cc",

6
ui/events/BUILD.gn

@ -16,12 +16,6 @@ if (is_ios) {
import("//ios/build/config.gni")
}
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
static_library("dom_keycode_converter") {
public = [
"keycodes/dom/dom_code.h",

6
ui/events/devices/BUILD.gn

@ -7,12 +7,6 @@ if (is_android) {
import("//build/config/android/rules.gni")
}
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
component("devices") {
sources = [
"device_data_manager.cc",

6
ui/gfx/BUILD.gn

@ -12,12 +12,6 @@ if (is_android) {
import("//build/config/android/rules.gni")
}
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
# Several targets want to include this header file, and some of them are
# child dependencies of "gfx". Therefore, we separate it out here so multiple
# targets can all have a dependency for header checking purposes without

6
ui/gfx/animation/BUILD.gn

@ -4,12 +4,6 @@
import("//build/config/ui.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
if (is_android) {
import("//build/config/android/config.gni")
import("//build/config/android/rules.gni")

6
ui/gfx/range/BUILD.gn

@ -2,12 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
component("range") {
sources = [
"gfx_range_export.h",

6
ui/gl/BUILD.gn

@ -24,12 +24,6 @@ if (is_android) {
import("//build/config/android/rules.gni")
}
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
buildflag_header("buildflags") {
header = "buildflags.h"
flags = [

6
ui/native_theme/BUILD.gn

@ -5,12 +5,6 @@
import("//build/config/ui.gni")
import("//testing/test.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
component("native_theme") {
sources = [
"caption_style.cc",

6
ui/shell_dialogs/BUILD.gn

@ -12,12 +12,6 @@ if (is_mac) {
import("//build/config/mac/rules.gni")
}
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
component("shell_dialogs") {
sources = [
"base_shell_dialog.cc",

6
ui/snapshot/BUILD.gn

@ -5,12 +5,6 @@
import("//build/config/ui.gni")
import("//testing/test.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
component("snapshot") {
sources = [
"screenshot_grabber.cc",

6
ui/views/BUILD.gn

@ -13,12 +13,6 @@ import("//ui/views/features.gni")
assert(toolkit_views)
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
config("flags") {
defines = [ "TOOLKIT_VIEWS=1" ]
}

6
ui/views/controls/webview/BUILD.gn

@ -2,12 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
component("webview") {
sources = [
"unhandled_keyboard_event_handler.cc",

6
ui/views_content_client/BUILD.gn

@ -4,12 +4,6 @@
import("//build/config/ui.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
component("views_content_client") {
testonly = true
sources = [