chromium/src
0
Fork 0
Code Activity

Revert "[X11] Set visual for ANGLE"

Browse Source 
This reverts commit 7f44eb3a1d.

Reason for revert: Vulkan blink_web_tests failures (crbug.com/1228723)

Original change's description:
> [X11] Set visual for ANGLE
>
> If a visual is not set, ANGLE will fallback to using a 24-bit visual
> without an alpha channel.  This issue manifests itself on Nvidia
> hardware as a black border around browser windows where a shadow
> is supposed to be drawn.  This issue was exposed by the switch to
> drawing client side shadows in Chrome [1].
>
> [1] https://chromium-review.googlesource.com/c/chromium/src/+/2901661
>
> R=​sky
>
> Bug: 1225953
> Change-Id: I37eff758d2e03fd27c46b542034a53d6628f9e52
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3018570
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#900714}

Bug: 1225953
Change-Id: I5caf64a6081f6b67ae282906c384e981b63d3e0d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3024586
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Behdadb <behdadb@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Behdadb <behdadb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#901042}
This commit is contained in:
Behdadb
2021-07-13 16:20:53 +00:00
committed by Chromium LUCI CQ
parent 9708dd4198
commit 6bdd267abb
1 changed files with 2 additions and 14 deletions

16
ui/base/x/x11_gl_egl_utility.cc

@ -39,20 +39,8 @@ namespace ui {
void GetPlatformExtraDisplayAttribs(EGLenum platform_type,
std::vector<EGLAttrib>* attributes) {
// ANGLE_NULL and SwiftShader backends don't use the visual,
// and may run without X11 where we can't get it anyway.
if ((platform_type != EGL_PLATFORM_ANGLE_TYPE_NULL_ANGLE) &&
(std::find(attributes->begin(), attributes->end(),
EGL_PLATFORM_ANGLE_DEVICE_TYPE_SWIFTSHADER_ANGLE) ==
attributes->end())) {
x11::VisualId visual_id;
XVisualManager::GetInstance()->ChooseVisualForWindow(
true, &visual_id, nullptr, nullptr, nullptr);
attributes->push_back(EGL_X11_VISUAL_ID_ANGLE);
attributes->push_back(static_cast<EGLAttrib>(visual_id));
attributes->push_back(EGL_PLATFORM_ANGLE_NATIVE_PLATFORM_TYPE_ANGLE);
attributes->push_back(EGL_PLATFORM_X11_EXT);
}
attributes->push_back(EGL_PLATFORM_ANGLE_NATIVE_PLATFORM_TYPE_ANGLE);
attributes->push_back(EGL_PLATFORM_X11_EXT);
}
void ChoosePlatformCustomAlphaAndBufferSize(EGLint* alpha_size,