chromium/src
0
Fork 0
Code Activity

Remove visual feedback for PDF viewer edit mode.

Browse Source 
This does not change actual behavior as kIsEditModeTracked is off.

Next CL will store and use the state passed to IsEditModeChanged() in
OutOfProcessInstance itself.

Bug: 61248
Change-Id: I4f1013b1a9540f301123a6acb0c6127e68dfd456
Reviewed-on: https://chromium-review.googlesource.com/1225104
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591739}
This commit is contained in:
Henrique Nakashima
2018-09-17 18:10:55 +00:00
committed by Commit Bot
parent 8398f75bb6
commit 6fab4a257f
2 changed files with 2 additions and 15 deletions
chrome/browser/resources/pdf
pdf_viewer.js
pdf
out_of_process_instance.cc

7
chrome/browser/resources/pdf/pdf_viewer.js

@ -746,13 +746,6 @@ PDFViewer.prototype = {
case 'setIsSelecting':
this.viewportScroller_.setEnableScrolling(message.data.isSelecting);
break;
case 'setIsEditMode':
// TODO(hnakashima): Replace this with final visual indication from UX.
if (message.data.isEditMode)
this.toolbar_.docTitle = document.title + ' (edit mode)';
else
this.toolbar_.docTitle = document.title;
break;
case 'getNamedDestinationReply':
this.paramsParser_.onNamedDestinationReceived(message.data.pageNumber);
break;

10
pdf/out_of_process_instance.cc

@ -154,10 +154,6 @@ const char kJSTransformPagePointReplyType[] = "transformPagePointReply";
const char kJSSetIsSelectingType[] = "setIsSelecting";
const char kJSIsSelecting[] = "isSelecting";
// Notify when the document was changed and edit mode is toggled.
const char kJSSetIsEditModeType[] = "setIsEditMode";
const char kJSIsEditMode[] = "isEditMode";
// Notify when a form field is focused (Plugin -> Page)
const char kJSFieldFocusType[] = "formFocusChange";
const char kJSFieldFocus[] = "focused";
@ -1898,10 +1894,8 @@ void OutOfProcessInstance::IsSelectingChanged(bool is_selecting) {
}
void OutOfProcessInstance::IsEditModeChanged(bool is_edit_mode) {
pp::VarDictionary message;
message.Set(kType, kJSSetIsEditModeType);
message.Set(kJSIsEditMode, pp::Var(is_edit_mode));
PostMessage(message);
// TODO(hnakashima): Switch to saving the edited file, rather than the
// original file.
}
float OutOfProcessInstance::GetToolbarHeightInScreenCoords() {