chromium/src
0
Fork 0
Code Activity

Feedback: Finalize the share diagnostic data string

Browse Source 
Screenshot: http://screen/5uV3JzXLmoCnBmZ

Bug: b:185624798
Test: browser_tests --gtest_filter=OSFeedbackBrowserTest.*
Change-Id: Ie969d6e26a91926da3e08946f5a7ab5b7a7eab31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3703190
Quick-Run: Danny Wang <wangdanny@google.com>
Commit-Queue: Danny Wang <wangdanny@google.com>
Reviewed-by: Xiangdong Kong <xiangdongkong@google.com>
Cr-Commit-Position: refs/heads/main@{#1013727}
This commit is contained in:
Danny Wang
2022-06-13 23:57:50 +00:00
committed by Chromium LUCI CQ
parent 3d25452416
commit 6fbadc82cc
5 changed files with 13 additions and 1 deletions
ash/webui/os_feedback_ui
os_feedback_ui.cc
resources
share_data_page.html
chrome/test/data/webui/chromeos/os_feedback_ui
share_data_page_test.js
chromeos
chromeos_strings.grd
chromeos_strings_grd
IDS_FEEDBACK_TOOL_SHARE_DIAGNOSTIC_DATA_LABEL.png.sha1

2
ash/webui/os_feedback_ui/os_feedback_ui.cc

@ -54,6 +54,8 @@ void AddLocalizedStrings(content::WebUIDataSource* source) {
{"attachFilesLabel", IDS_FEEDBACK_TOOL_ATTACH_FILES_LABEL},
{"replaceFileLabel", IDS_FEEDBACK_TOOL_REPLACE_FILE_LABEL},
{"userEmailLabel", IDS_FEEDBACK_TOOL_USER_EMAIL_LABEL},
{"shareDiagnosticDataLabel",
IDS_FEEDBACK_TOOL_SHARE_DIAGNOSTIC_DATA_LABEL},
{"confirmationTitleOnline", IDS_FEEDBACK_TOOL_PAGE_TITLE_AFTER_SENT},
};

2
ash/webui/os_feedback_ui/resources/share_data_page.html

@ -103,7 +103,7 @@
</div>
<!-- Diagnostic data -->
<div id="shareDiagnosticData">
<p>Share diagnostic data</p>
<p id="shareDiagnosticDataLabel">[[i18n('shareDiagnosticDataLabel')]]</p>
<!-- URL -->
<div id="pageUrl" class="checkbox-field-container">
<input id="pageUrlCheckbox" type="checkbox" aria-labelledby="pageUrlLabel"

6
chrome/test/data/webui/chromeos/os_feedback_ui/share_data_page_test.js

@ -99,6 +99,12 @@ export function shareDataPageTestSuite() {
// Verify the user email label is in the page.
assertEquals('Email', getElementContent('#userEmailLabel'));
// Verify the share diagnostic data label is in the page.
assertTrue(page.i18nExists('shareDiagnosticDataLabel'));
assertEquals(
'Share diagnostic data',
getElementContent('#shareDiagnosticDataLabel'));
// Screenshot elements.
assertTrue(!!getElement('#screenshotCheckbox'));
assertEquals('Screenshot', getElementContent('#screenshotCheckLabel'));

3
chromeos/chromeos_strings.grd

@ -3407,6 +3407,9 @@ Try tapping the mic to ask me anything.
<message name="IDS_FEEDBACK_TOOL_USER_EMAIL_LABEL" desc="Label showing the e-mail address that will be reported.">
Email
</message>
<message name="IDS_FEEDBACK_TOOL_SHARE_DIAGNOSTIC_DATA_LABEL" desc="Label showing the share diagnostic data.">
Share diagnostic data
</message>
<!-- Confirmation Page -->
<message name="IDS_FEEDBACK_TOOL_PAGE_TITLE_AFTER_SENT" desc="Label showing a thank you message as the title of the confirmation page after a report has been sent.">
Thanks for your feedback

1
chromeos/chromeos_strings_grd/IDS_FEEDBACK_TOOL_SHARE_DIAGNOSTIC_DATA_LABEL.png.sha1 Normal file

@ -0,0 +1 @@
e9bd08c14675a2d4c7e76314ce02fcbb1bebc0f1