chromium/src
0
Fork 0
Code Activity

Use new version of v8::String::Write* APIs in tests

Browse Source 
The old v8::String::Write* APIs are deprecated and we should use the V2
versions of these APIs instead.

Bug: 373485796
Change-Id: I8ecfcd22021815a40d355a6d06612714ca710d8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6156855
Commit-Queue: Samuel Groß <saelo@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1403511}
This commit is contained in:
Samuel Groß
2025-01-08 04:30:10 -08:00
committed by Chromium LUCI CQ
parent 35fb3b916b
commit 73648bb41e
2 changed files with 5 additions and 4 deletions
content/web_test/common
web_test_string_util.cc
third_party/blink/common/messaging
string_message_codec_unittest.cc

5
content/web_test/common/web_test_string_util.cc

@ -95,9 +95,10 @@ const char* WindowOpenDispositionToString(WindowOpenDisposition disposition) {
blink::WebString V8StringToWebString(v8::Isolate* isolate,
v8::Local<v8::String> v8_str) {
int length = v8_str->Utf8Length(isolate) + 1;
size_t length = v8_str->Utf8LengthV2(isolate) + 1;
auto chars = base::HeapArray<char>::WithSize(length);
v8_str->WriteUtf8(isolate, chars.data(), chars.size());
v8_str->WriteUtf8V2(isolate, chars.data(), chars.size(),
v8::String::WriteFlags::kNullTerminate);
return blink::WebString::FromUTF8(chars.data());
}

4
third_party/blink/common/messaging/string_message_codec_unittest.cc vendored

@ -60,8 +60,8 @@ WebMessagePayload DecodeWithV8(const TransferableMessage& message) {
v8::Local<v8::String> js_str = value->ToString(context).ToLocalChecked();
std::u16string str;
str.resize(js_str->Length());
js_str->Write(isolate, reinterpret_cast<uint16_t*>(&str[0]), 0,
str.size());
js_str->WriteV2(isolate, 0, str.size(),
reinterpret_cast<uint16_t*>(&str[0]));
result = str;
}
if (value->IsArrayBuffer()) {