0

Build WebKit Full Screen API. Support is disabled by default; enable with --enable-fullscreen.

Commit after WK bug 44797 (r79774).

Fullscreen tests are temporarily until expectations can be updated.
(Deleted test video-play-suspend.html is removed from test_expectations to fix lint errors.)

BUG=16735
TEST=fullscreen layout tests

Review URL: http://codereview.chromium.org/6627001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76979 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
ddorwin@chromium.org
2011-03-04 21:54:49 +00:00
parent 76edb6710c
commit 75b61bdafb
8 changed files with 19 additions and 5 deletions

@ -28,6 +28,7 @@
'ENABLE_JAVASCRIPT_I18N_API=1',
'ENABLE_FILE_SYSTEM=1',
'ENABLE_FILTERS=1',
'ENABLE_FULLSCREEN_API=1',
'ENABLE_GEOLOCATION=1',
'ENABLE_ICONDATABASE=0',
'ENABLE_INDEXED_DATABASE=1',

@ -305,6 +305,9 @@ WebPreferences RenderViewHostDelegateHelper::GetWebkitPrefs(
!command_line.HasSwitch(switches::kNoPings);
web_prefs.interactive_form_validation_enabled =
!command_line.HasSwitch(switches::kDisableInteractiveFormValidation);
web_prefs.fullscreen_enabled =
command_line.HasSwitch(switches::kEnableFullScreen);
// The user stylesheet watcher may not exist in a testing profile.
if (profile->GetUserStyleSheetWatcher()) {
web_prefs.user_style_sheet_enabled = true;

@ -492,6 +492,9 @@ const char kEnableFileCookies[] = "enable-file-cookies";
// Enable the use of the HistoryQuickProvider for autocomplete results.
const char kEnableHistoryQuickProvider[] = "enable-history-quick-provider";
// Enable the JavaScript Full Screen API.
const char kEnableFullScreen[] = "enable-fullscreen";
// Enable the in-browser thumbnailing, which is more efficient than the
// in-renderer thumbnailing, as we can use more information to determine
// if we need to update thumbnails.

@ -146,6 +146,7 @@ extern const char kEnableExperimentalExtensionApis[];
extern const char kEnableExtensionTimelineApi[];
extern const char kEnableFastback[];
extern const char kEnableFileCookies[];
extern const char kEnableFullScreen[];
extern const char kEnableHistoryQuickProvider[];
extern const char kEnableInBrowserThumbnailing[];
extern const char kEnableIPv6[];

@ -678,6 +678,7 @@ void ParamTraits<WebPreferences>::Write(Message* m, const param_type& p) {
WriteParam(m, p.accelerated_video_enabled);
WriteParam(m, p.memory_info_enabled);
WriteParam(m, p.interactive_form_validation_enabled);
WriteParam(m, p.fullscreen_enabled);
}
bool ParamTraits<WebPreferences>::Read(const Message* m, void** iter,
@ -734,7 +735,8 @@ bool ParamTraits<WebPreferences>::Read(const Message* m, void** iter,
ReadParam(m, iter, &p->accelerated_layers_enabled) &&
ReadParam(m, iter, &p->accelerated_video_enabled) &&
ReadParam(m, iter, &p->memory_info_enabled) &&
ReadParam(m, iter, &p->interactive_form_validation_enabled);
ReadParam(m, iter, &p->interactive_form_validation_enabled) &&
ReadParam(m, iter, &p->fullscreen_enabled);
}
void ParamTraits<WebPreferences>::Log(const param_type& p, std::string* l) {

@ -72,7 +72,8 @@ WebPreferences::WebPreferences()
accelerated_2d_canvas_enabled(false),
accelerated_plugins_enabled(false),
memory_info_enabled(false),
interactive_form_validation_enabled(true) {
interactive_form_validation_enabled(true),
fullscreen_enabled(false) {
}
WebPreferences::~WebPreferences() {
@ -205,4 +206,6 @@ void WebPreferences::Apply(WebView* web_view) const {
settings->setInteractiveFormValidationEnabled(
interactive_form_validation_enabled);
settings->setFullScreenEnabled(fullscreen_enabled);
}

@ -79,6 +79,7 @@ struct WebPreferences {
bool accelerated_plugins_enabled;
bool memory_info_enabled;
bool interactive_form_validation_enabled;
bool fullscreen_enabled;
// We try to keep the default values the same as the default values in
// chrome, except for the cases where it would require lots of extra work for

@ -10,9 +10,6 @@ BUGCR69594 SKIP : http/tests/appcache/different-https-origin-resource-main.html
BUGV8_1203 DEBUG : fast/canvas/webgl/gl-get-calls.html = PASS CRASH
// Potential broken test found by r75985.
BUGCR74092 : http/tests/media/video-play-suspend.html = TIMEOUT
// WebKit fix is at r79797, but since we had to revert the WebKit roll adding the failing expectation back.
BUGJAMESR : fast/filesystem/op-get-entry.html = PASS TEXT
@ -21,3 +18,6 @@ BUG_ANTONM MAC : http/tests/security/xss-DENIED-xml-external-entity.xhtml = TEXT
BUG_ANTONM MAC : http/tests/security/xss-DENIED-xsl-external-entity.xml = TEXT
BUG_TONYG MAC : svg/text/font-size-below-point-five.svg = TEXT
// Skip these tests until the test_expecitations can be updated after this Chromium patch lands.
BUGWK44797 SKIP : fullscreen = PASS FAIL TIMEOUT