chromium/src
0
Fork 0
Code Activity

CodeHealth: Remove use of DictionaryValue::HasKey in /services/preferences/tracked

Browse Source 
This change removes the use of `DictionaryValue::HasKey()`
and replaces with `Value::FindKey()`.

This CL was uploaded by git cl split.

R=proberge@chromium.org

Bug: 1187060
Change-Id: I695e231b9ad3a17bf35b179f9837986a5f18921d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2885124
Auto-Submit: Anastasiia N <anastasiian@chromium.org>
Commit-Queue: Anastasiia N <anastasiian@chromium.org>
Commit-Queue: proberge <proberge@chromium.org>
Reviewed-by: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881518}
This commit is contained in:
Anastasiia N
2021-05-11 13:53:55 +00:00
committed by Chromium LUCI CQ
parent 6ac66f9445
commit 75dffca910
1 changed files with 8 additions and 8 deletions

16
services/preferences/tracked/pref_hash_filter_unittest.cc

@ -1031,10 +1031,10 @@ TEST_P(PrefHashFilterTest, InitialValueChanged) {
const base::Value* split_value_in_store;
ASSERT_TRUE(pref_store_contents_->Get(kSplitPref, &split_value_in_store));
ASSERT_EQ(2U, dict_value->DictSize());
ASSERT_FALSE(dict_value->HasKey("a"));
ASSERT_TRUE(dict_value->HasKey("b"));
ASSERT_FALSE(dict_value->HasKey("c"));
ASSERT_TRUE(dict_value->HasKey("d"));
ASSERT_EQ(dict_value->FindKey("a"), nullptr);
ASSERT_NE(dict_value->FindKey("b"), nullptr);
ASSERT_EQ(dict_value->FindKey("c"), nullptr);
ASSERT_NE(dict_value->FindKey("d"), nullptr);
ASSERT_EQ(dict_value, stored_split_value.first);
VerifyRecordedReset(true);
@ -1050,10 +1050,10 @@ TEST_P(PrefHashFilterTest, InitialValueChanged) {
ASSERT_TRUE(pref_store_contents_->Get(kSplitPref, &split_value_in_store));
ASSERT_EQ(dict_value, split_value_in_store);
ASSERT_EQ(4U, dict_value->DictSize());
ASSERT_TRUE(dict_value->HasKey("a"));
ASSERT_TRUE(dict_value->HasKey("b"));
ASSERT_TRUE(dict_value->HasKey("c"));
ASSERT_TRUE(dict_value->HasKey("d"));
ASSERT_NE(dict_value->FindKey("a"), nullptr);
ASSERT_NE(dict_value->FindKey("b"), nullptr);
ASSERT_NE(dict_value->FindKey("c"), nullptr);
ASSERT_NE(dict_value->FindKey("d"), nullptr);
ASSERT_EQ(dict_value, stored_split_value.first);
VerifyRecordedReset(false);