Add launch app kb shortcut flag
Bug: b:375245704 Change-Id: I4ab1fc73b26cef502a1ab109adb4e8f3e9d2e174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5957885 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by: David Padlipsky <dpad@google.com> Cr-Commit-Position: refs/heads/main@{#1374762}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
fecb9c6621
commit
7612630f58
ash/constants
chrome/browser
tools/metrics/histograms
@ -1307,6 +1307,11 @@ BASE_FEATURE(kGameDashboardUtilities,
|
||||
"GameDashboardUtilities",
|
||||
base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
|
||||
// Enables the App launch keyboard shortcut.
|
||||
BASE_FEATURE(kAppLaunchShortcut,
|
||||
"AppLaunchShortcut",
|
||||
base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
|
||||
// Enables the Game Dashboard's Record Game feature. This flag is to be enabled
|
||||
// by the feature management module.
|
||||
BASE_FEATURE(kFeatureManagementGameDashboardRecordGame,
|
||||
@ -4263,6 +4268,10 @@ bool AreGameDashboardUtilitiesEnabled() {
|
||||
return base::FeatureList::IsEnabled(kGameDashboardUtilities);
|
||||
}
|
||||
|
||||
bool IsAppLaunchShortcutEnabled() {
|
||||
return base::FeatureList::IsEnabled(kAppLaunchShortcut);
|
||||
}
|
||||
|
||||
bool IsLockScreenInlineReplyEnabled() {
|
||||
return base::FeatureList::IsEnabled(kLockScreenInlineReply);
|
||||
}
|
||||
|
@ -428,6 +428,7 @@ BASE_DECLARE_FEATURE(kGameDashboardGamepadSupport);
|
||||
COMPONENT_EXPORT(ASH_CONSTANTS) BASE_DECLARE_FEATURE(kGameDashboardGamePWAs);
|
||||
COMPONENT_EXPORT(ASH_CONSTANTS) BASE_DECLARE_FEATURE(kGameDashboardGamesInTest);
|
||||
COMPONENT_EXPORT(ASH_CONSTANTS) BASE_DECLARE_FEATURE(kGameDashboardUtilities);
|
||||
COMPONENT_EXPORT(ASH_CONSTANTS) BASE_DECLARE_FEATURE(kAppLaunchShortcut);
|
||||
COMPONENT_EXPORT(ASH_CONSTANTS)
|
||||
BASE_DECLARE_FEATURE(kFeatureManagementGameDashboardRecordGame);
|
||||
COMPONENT_EXPORT(ASH_CONSTANTS) BASE_DECLARE_FEATURE(kBlockFwupdClient);
|
||||
@ -1226,6 +1227,7 @@ COMPONENT_EXPORT(ASH_CONSTANTS) bool IsGameDashboardGamepadSupportEnabled();
|
||||
COMPONENT_EXPORT(ASH_CONSTANTS) bool IsGameDashboardGamePWAsEnabled();
|
||||
COMPONENT_EXPORT(ASH_CONSTANTS) bool IsGameDashboardGamesInTestEnabled();
|
||||
COMPONENT_EXPORT(ASH_CONSTANTS) bool AreGameDashboardUtilitiesEnabled();
|
||||
COMPONENT_EXPORT(ASH_CONSTANTS) bool IsAppLaunchShortcutEnabled();
|
||||
COMPONENT_EXPORT(ASH_CONSTANTS) bool IsGifRecordingEnabled();
|
||||
COMPONENT_EXPORT(ASH_CONSTANTS) bool IsGraduationEnabled();
|
||||
COMPONENT_EXPORT(ASH_CONSTANTS)
|
||||
|
@ -9912,6 +9912,9 @@ const FeatureEntry kFeatureEntries[] = {
|
||||
#endif
|
||||
|
||||
#if BUILDFLAG(IS_CHROMEOS_ASH)
|
||||
{"app-launch-shortcut", flag_descriptions::kAppLaunchShortcut,
|
||||
flag_descriptions::kAppLaunchShortcutDescription, kOsCrOS,
|
||||
FEATURE_VALUE_TYPE(ash::features::kAppLaunchShortcut)},
|
||||
{"enable-holding-space-suggestions",
|
||||
flag_descriptions::kHoldingSpaceSuggestionsName,
|
||||
flag_descriptions::kHoldingSpaceSuggestionsDescription, kOsCrOS,
|
||||
|
@ -244,6 +244,15 @@
|
||||
"owners": [ "dandersson@chromium.org", "janetmac@chromium.org" ],
|
||||
"expiry_milestone": 123
|
||||
},
|
||||
{
|
||||
"name": "app-launch-shortcut",
|
||||
"owners": [
|
||||
"michaelcheco@google.com",
|
||||
"dpad@google.com",
|
||||
"cros-device-enablement@google.com"
|
||||
],
|
||||
"expiry_milestone": 140
|
||||
},
|
||||
{
|
||||
"name": "app-specific-history",
|
||||
"owners": [ "katzz@google.com", "jinsukkim@google.com" ],
|
||||
|
@ -6914,6 +6914,10 @@ const char kGameDashboardUtilities[] = "Game Dashboard Utilities";
|
||||
const char kGameDashboardUtilitiesDescription[] =
|
||||
"Enables utility features in the Game Dashboard.";
|
||||
|
||||
const char kAppLaunchShortcut[] = "App launch keyboard shortcut";
|
||||
const char kAppLaunchShortcutDescription[] =
|
||||
"Enables a keyboard shortcut that launches a user specified app.";
|
||||
|
||||
const char kGlanceablesTimeManagementClassroomStudentViewName[] =
|
||||
"Glanceables > Time Management > Classroom Student";
|
||||
const char kGlanceablesTimeManagementClassroomStudentViewDescription[] =
|
||||
|
@ -3980,6 +3980,9 @@ extern const char kGameDashboardGamesInTestDescription[];
|
||||
extern const char kGameDashboardUtilities[];
|
||||
extern const char kGameDashboardUtilitiesDescription[];
|
||||
|
||||
extern const char kAppLaunchShortcut[];
|
||||
extern const char kAppLaunchShortcutDescription[];
|
||||
|
||||
extern const char kGlanceablesTimeManagementClassroomStudentViewName[];
|
||||
extern const char kGlanceablesTimeManagementClassroomStudentViewDescription[];
|
||||
|
||||
|
@ -15993,6 +15993,7 @@ from previous Chrome versions.
|
||||
<int value="-1674868343" label="DlcSettingsUi:enabled"/>
|
||||
<int value="-1673342139"
|
||||
label="ImageServiceOptimizationGuideSalientImages:enabled"/>
|
||||
<int value="-1672894860" label="AppLaunchShortcut:enabled"/>
|
||||
<int value="-1672894214"
|
||||
label="AutofillUpstreamAllowAdditionalEmailDomains:disabled"/>
|
||||
<int value="-1672160462"
|
||||
@ -16791,6 +16792,7 @@ from previous Chrome versions.
|
||||
<int value="-1356379431" label="GlobalMediaControlsOverlayControls:enabled"/>
|
||||
<int value="-1355886577" label="ReleaseNotesNotificationAllChannels:enabled"/>
|
||||
<int value="-1355717940" label="WebViewPowerSchedulerThrottleIdle:enabled"/>
|
||||
<int value="-1355349150" label="AppLaunchShortcut:disabled"/>
|
||||
<int value="-1355267677"
|
||||
label="ArcTrackpadScrollTouchscreenEmulation:enabled"/>
|
||||
<int value="-1354983077" label="CameraAppAutoQRDetection:disabled"/>
|
||||
|
Reference in New Issue
Block a user