chromium/src
0
Fork 0
Code Activity

[docs] Improve "google branded" docs related to clank assets

Browse Source 
Change-Id: Iab095695e66c345e18053523a2f01f7f79263376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4286789
Commit-Queue: Filipa Senra <fsenra@google.com>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1109513}
This commit is contained in:
Filipa Senra
2023-02-24 11:58:55 +00:00
committed by Chromium LUCI CQ
parent 83358853c6
commit 77dcc9d112
1 changed files with 22 additions and 0 deletions

22
docs/google_chrome_branded_builds.md

@ -74,3 +74,25 @@ Once that CL lands, an auto-roller bot will update the main repo's src-internal
hash reference in `//DEPS` ([example autoroll CL](https://crrev.com/c/4024955))
and your new internal resources will be available on the bots. The chromium-side
CL making use of it can then be uploaded.
## Internal Clank assets
Internal Clank assets live in [Clank's internal downstream repo](https://chrome-internal.googlesource.com/clank/internal/apps).
In general, to check in product-specific assets:
- Add `//components` ones under
`//components/[product_name]/java/res/drawable/[asset_name]`.
E.g.
[`//components/page_info/java/res/drawable/product_logo.png`](https://chrome-internal.googlesource.com/clank/internal/apps/+/refs/heads/main/components/page_info/java/res/drawable)
To add assets there, `cd` to this repo, add your new assets and `git cl
upload` to start an internal code review. Once it lands, an auto-roller bot will
update the main repo's src/clank hash reference in `//DEPS`
([example autoroll CL](https://chromium-review.googlesource.com/c/chromium/src/+/4282317))
and your new internal assets will be available on the bots. The chromium-side
CL making use of it can then be uploaded.
The internal asset is only available on a Chrome branded build. We can not
utilize icons from the internal repo directly from Java because the assets
wouldn't be available in public builds. We can work around this by passing the
resource id to the native side and then back to Java (example [CL1](https://crrev.com/c/3327235),
[CL2](https://crrev.com/c/4286715)).