chromium/src
0
Fork 0
Code Activity

Update documentation in //chromecast for base::Feature.

Browse Source 
Bug: 1364289
Change-Id: I852ef82d3365ec0aaa67385defa17d3e6f3dcc04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3931379
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1054069}
This commit is contained in:
Daniel Cheng
2022-10-03 06:23:55 +00:00
committed by Chromium LUCI CQ
parent 4ebd6d7466
commit 783c5523b6
2 changed files with 3 additions and 3 deletions

2
chromecast/README.md

@ -14,7 +14,7 @@ comments of the header file. The basics are:
* Add your new feature to the list of `kFeatures` in `cast_features.cc`
```c++
const base::Feature kMyFeature{"my_feature", base::FEATURE_DISABLED_BY_DEFAULT};
BASE_FEATURE(kMyFeature, "my_feature", base::FEATURE_DISABLED_BY_DEFAULT);
const base::Feature* kFeatures[] = {

4
chromecast/base/cast_features.cc

@ -69,8 +69,8 @@ void SetExperimentIds(const base::Value::List& list) {
// the value that the feature will hold until overriden by the server or the
// command line. Here's an exmaple:
//
// const base::Feature kSuperSecretSauce{
// "enable_super_secret_sauce", base::FEATURE_DISABLED_BY_DEFAULT};
// BASE_FEATURE(kSuperSecretSauce, "SuperSecretSauce",
// base::FEATURE_DISABLED_BY_DEFAULT);
//
// IMPORTANT NOTE:
// The first parameter that you pass in the definition is the feature's name.