chromium/src
0
Fork 0
Code Activity

Specify ownership for CreateTestWidget() callers in a few files.

Browse Source 
We are changing Views so that the default (and only) ownership model
for Widgets will be CLIENT_OWNS_WIDGET. However, there are APIs like
CreateTestWidget() that rely on a default value for ownership. We
need to specify the ownership explicitly so that we can then track
down and change all of the uses as part of the refactoring.

This CL updates all the callers that had not been updated in other CLs:
one in //ash/components/arc, two in //ui/message_center, and one in
//ui/views/accessibility.

There should be no functional changes in this CL.

Bug: 339619005
Change-Id: Ic315d4c95f61ba32f63b60d6ba850616e28c67ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5586345
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1310695}
This commit is contained in:
Dirk Pranke
2024-06-05 16:57:36 +00:00
committed by Chromium LUCI CQ
parent c2d0e15b7c
commit 7a4c83713e
4 changed files with 8 additions and 4 deletions

3
ash/components/arc/compat_mode/resize_confirmation_dialog_view_unittest.cc

@ -24,7 +24,8 @@ class ResizeConfirmationDialogViewTest : public CompatModeTestBase {
// CompatModeTestBase:
void SetUp() override {
CompatModeTestBase::SetUp();
widget_ = CreateTestWidget();
widget_ =
CreateTestWidget(views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET);
widget_->SetBounds(gfx::Rect(800, 800));
parent_widget_ = CreateArcWidget(/*app_id=*/"123");
dialog_view_ =

3
ui/message_center/views/message_view_unittest.cc

@ -57,7 +57,8 @@ class MessageViewTest : public views::ViewsTestBase {
NotifierId(), RichNotificationData(), /*delegate=*/nullptr);
// `widget_` owns `message_view_`.
widget_ = CreateTestWidget();
widget_ =
CreateTestWidget(views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET);
message_view_ = widget_->SetContentsView(
std::make_unique<TestMessageView>(*notification_.get()));
widget_->Show();

3
ui/message_center/views/notification_control_buttons_unittest.cc

@ -56,7 +56,8 @@ class NotificationControlButtonsTest : public views::ViewsTestBase {
// views::ViewsTestBase:
void SetUp() override {
views::ViewsTestBase::SetUp();
widget_ = CreateTestWidget();
widget_ =
CreateTestWidget(views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET);
Notification notification(
NOTIFICATION_TYPE_SIMPLE, "id", u"title", u"id", ui::ImageModel(),
std::u16string(), GURL(),

3
ui/views/accessibility/view_ax_platform_node_delegate_mac_unittest.cc

@ -67,7 +67,8 @@ class ViewAXPlatformNodeDelegateMacTest : public ViewsTestBase {
void SetUp() override {
ViewsTestBase::SetUp();
widget_ = CreateTestWidget();
widget_ =
CreateTestWidget(views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET);
widget_->widget_delegate()->SetTitle(base::ASCIIToUTF16(kDialogName));
widget_->SetContentsView(std::make_unique<AccessibleView>());
}