0

Chrome for Testing: remove redundant flags from bot configs

Those are already sensibly set via GN defaults, taking CfT into account:

- proprietary_codecs: third_party/devtools-frontend/src/build/config/features.gni
- ffmpeg_branding: third_party/ffmpeg/ffmpeg_options.gni

Bug: 1457118
Change-Id: Ic55c88df748bcf5a79876cfcd82dce62fa009b09
Docs: go/chrome-for-testing:enabling-features
Cq-Include-Trybots: luci.chromium.try:mac-rel-cft,win-rel-cft
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903736
Reviewed-by: Wanda Mora <morawand@google.com>
Commit-Queue: Thiago Perrotta <tperrotta@chromium.org>
Auto-Submit: Thiago Perrotta <tperrotta@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1205984}
This commit is contained in:
Thiago Perrotta
2023-10-05 19:23:25 +00:00
committed by Chromium LUCI CQ
parent f0aba22e9b
commit 7a5de421a2
3 changed files with 36 additions and 57 deletions

@ -225,10 +225,10 @@
},
'chromium.cft': {
'linux-arm64-rel-cft': 'gpu_tests_release_bot_minimal_symbols_chrome_for_testing_reclient_arm64',
'linux-rel-cft': 'gpu_tests_release_bot_minimal_symbols_chrome_for_testing_reclient',
'mac-rel-cft': 'gpu_tests_release_bot_minimal_symbols_chrome_for_testing_reclient',
'win-rel-cft': 'gpu_tests_release_bot_minimal_symbols_chrome_for_testing_reclient',
'linux-arm64-rel-cft': 'release_bot_minimal_symbols_chrome_for_testing_reclient_arm64',
'linux-rel-cft': 'release_bot_minimal_symbols_chrome_for_testing_reclient',
'mac-rel-cft': 'release_bot_minimal_symbols_chrome_for_testing_reclient',
'win-rel-cft': 'release_bot_minimal_symbols_chrome_for_testing_reclient',
},
'chromium.chromiumos': {
@ -1146,10 +1146,10 @@
},
'tryserver.chromium.cft': {
'linux-arm64-rel-cft': 'gpu_tests_release_trybot_no_symbols_chrome_for_testing_reclient_arm64',
'linux-rel-cft': 'gpu_tests_release_trybot_no_symbols_use_dummy_lastchange_do_typecheck_chrome_for_testing_reclient',
'mac-rel-cft': 'gpu_tests_release_trybot_no_symbols_mac_chrome_for_testing_reclient',
'win-rel-cft': 'gpu_tests_release_trybot_resource_allowlisting_chrome_for_testing_reclient',
'linux-arm64-rel-cft': 'release_trybot_no_symbols_chrome_for_testing_reclient_arm64',
'linux-rel-cft': 'release_trybot_no_symbols_use_dummy_lastchange_do_typecheck_chrome_for_testing_reclient',
'mac-rel-cft': 'release_trybot_no_symbols_mac_chrome_for_testing_reclient',
'win-rel-cft': 'release_trybot_resource_allowlisting_chrome_for_testing_reclient',
},
'tryserver.chromium.chromiumos': {
@ -2939,16 +2939,6 @@
'gpu_tests', 'release_bot_reclient', 'devtools_do_typecheck',
],
'gpu_tests_release_bot_minimal_symbols_chrome_for_testing_reclient': [
'gpu_tests', 'release_bot_reclient', 'minimal_symbols',
'chrome_for_testing',
],
'gpu_tests_release_bot_minimal_symbols_chrome_for_testing_reclient_arm64': [
'gpu_tests', 'release_bot_reclient', 'minimal_symbols',
'chrome_for_testing', 'arm64',
],
'gpu_tests_release_bot_minimal_symbols_code_coverage': [
'gpu_tests', 'release_bot', 'minimal_symbols', 'use_clang_coverage',
'partial_code_coverage_instrumentation',
@ -2998,16 +2988,6 @@
'gpu_tests', 'release_trybot_minimal_symbols_reclient',
],
'gpu_tests_release_trybot_no_symbols_chrome_for_testing_reclient_arm64': [
'gpu_tests', 'release_trybot_reclient', 'no_symbols',
'chrome_for_testing', 'arm64',
],
'gpu_tests_release_trybot_no_symbols_mac_chrome_for_testing_reclient': [
'gpu_tests', 'release_trybot_reclient', 'no_symbols',
'chrome_for_testing',
],
'gpu_tests_release_trybot_no_symbols_mac_code_coverage_x64_reclient': [
'gpu_tests', 'release_trybot_reclient', 'no_symbols',
'use_clang_coverage', 'partial_code_coverage_instrumentation',
@ -3045,11 +3025,6 @@
"no_goma", "no_reclient", "siso",
],
'gpu_tests_release_trybot_no_symbols_use_dummy_lastchange_do_typecheck_chrome_for_testing_reclient': [
'gpu_tests', 'release_trybot_reclient', 'no_symbols', 'use_dummy_lastchange',
'devtools_do_typecheck', 'chrome_for_testing',
],
'gpu_tests_release_trybot_no_symbols_use_dummy_lastchange_invert_fieldtrials_reclient': [
'gpu_tests', 'release_trybot_reclient', 'no_symbols', 'use_dummy_lastchange',
'invert_fieldtrials',
@ -3063,14 +3038,6 @@
'gpu_tests', 'release_trybot_reclient',
],
# TODO(crbug.com/1004523) Delete this once coverage mode is enabled on the
# standard Windows trybot and the dedicated coverage trybot is no longer
# needed.
'gpu_tests_release_trybot_resource_allowlisting_chrome_for_testing_reclient': [
'gpu_tests', 'release_trybot_reclient', 'no_resource_allowlisting',
'chrome_for_testing',
],
'gpu_tests_release_trybot_resource_allowlisting_code_coverage': [
'gpu_tests', 'release_trybot', 'no_resource_allowlisting',
'use_clang_coverage', 'partial_code_coverage_instrumentation',
@ -3736,6 +3703,14 @@
'release_bot', 'minimal_symbols',
],
'release_bot_minimal_symbols_chrome_for_testing_reclient': [
'release_bot_reclient', 'minimal_symbols', 'chrome_for_testing',
],
'release_bot_minimal_symbols_chrome_for_testing_reclient_arm64': [
'release_bot_reclient', 'minimal_symbols', 'chrome_for_testing', 'arm64',
],
'release_bot_minimal_symbols_no_clang': [
'release_bot', 'minimal_symbols', 'no_clang', 'no_goma',
],
@ -3849,6 +3824,19 @@
'release_trybot_reclient', 'disable_nacl',
],
'release_trybot_no_symbols_chrome_for_testing_reclient_arm64': [
'release_trybot_reclient', 'no_symbols', 'chrome_for_testing', 'arm64',
],
'release_trybot_no_symbols_mac_chrome_for_testing_reclient': [
'release_trybot_reclient', 'no_symbols', 'chrome_for_testing',
],
'release_trybot_no_symbols_use_dummy_lastchange_do_typecheck_chrome_for_testing_reclient': [
'release_trybot_reclient', 'no_symbols', 'use_dummy_lastchange',
'devtools_do_typecheck', 'chrome_for_testing',
],
'release_trybot_reclient': [
'release_trybot_reclient',
],
@ -3857,6 +3845,13 @@
'release_trybot_reclient', 'x64',
],
# TODO(crbug.com/1004523) Delete this once coverage mode is enabled on the
# standard Windows trybot and the dedicated coverage trybot is no longer
# needed.
'release_trybot_resource_allowlisting_chrome_for_testing_reclient': [
'release_trybot_reclient', 'no_resource_allowlisting', 'chrome_for_testing',
],
'release_trybot_tsan': [
'release_trybot', 'tsan'
],

@ -2,11 +2,9 @@
"linux-arm64-rel-cft": {
"gn_args": {
"dcheck_always_on": false,
"ffmpeg_branding": "Chrome",
"is_chrome_for_testing": true,
"is_component_build": false,
"is_debug": false,
"proprietary_codecs": true,
"symbol_level": 1,
"target_cpu": "arm64",
"use_remoteexec": true
@ -15,11 +13,9 @@
"linux-rel-cft": {
"gn_args": {
"dcheck_always_on": false,
"ffmpeg_branding": "Chrome",
"is_chrome_for_testing": true,
"is_component_build": false,
"is_debug": false,
"proprietary_codecs": true,
"symbol_level": 1,
"use_remoteexec": true
}
@ -27,11 +23,9 @@
"mac-rel-cft": {
"gn_args": {
"dcheck_always_on": false,
"ffmpeg_branding": "Chrome",
"is_chrome_for_testing": true,
"is_component_build": false,
"is_debug": false,
"proprietary_codecs": true,
"symbol_level": 1,
"use_remoteexec": true
}
@ -39,11 +33,9 @@
"win-rel-cft": {
"gn_args": {
"dcheck_always_on": false,
"ffmpeg_branding": "Chrome",
"is_chrome_for_testing": true,
"is_component_build": false,
"is_debug": false,
"proprietary_codecs": true,
"symbol_level": 1,
"use_remoteexec": true
}

@ -2,11 +2,9 @@
"linux-arm64-rel-cft": {
"gn_args": {
"dcheck_always_on": true,
"ffmpeg_branding": "Chrome",
"is_chrome_for_testing": true,
"is_component_build": false,
"is_debug": false,
"proprietary_codecs": true,
"symbol_level": 0,
"target_cpu": "arm64",
"use_dummy_lastchange": true,
@ -17,11 +15,9 @@
"gn_args": {
"dcheck_always_on": true,
"devtools_skip_typecheck": false,
"ffmpeg_branding": "Chrome",
"is_chrome_for_testing": true,
"is_component_build": false,
"is_debug": false,
"proprietary_codecs": true,
"symbol_level": 0,
"use_dummy_lastchange": true,
"use_remoteexec": true
@ -30,11 +26,9 @@
"mac-rel-cft": {
"gn_args": {
"dcheck_always_on": true,
"ffmpeg_branding": "Chrome",
"is_chrome_for_testing": true,
"is_component_build": false,
"is_debug": false,
"proprietary_codecs": true,
"symbol_level": 0,
"use_dummy_lastchange": true,
"use_remoteexec": true
@ -44,11 +38,9 @@
"gn_args": {
"dcheck_always_on": true,
"enable_resource_allowlist_generation": false,
"ffmpeg_branding": "Chrome",
"is_chrome_for_testing": true,
"is_component_build": false,
"is_debug": false,
"proprietary_codecs": true,
"symbol_level": 0,
"use_dummy_lastchange": true,
"use_remoteexec": true