0

[Traffic Annotation] Add new fields to code examples

Specifically user_data, contacts, and last_reviewed. New annotations
require these fields since crrev.com/c/4128666, so we should keep
developer documentation up-to-date.

Bug: b/254273300
Change-Id: Ibbc35f7351e3c7b6c156003c763d3dc7dd3f0931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4166045
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1103293}
This commit is contained in:
Nicolas Ouellet-Payeur
2023-02-09 16:03:27 +00:00
committed by Chromium LUCI CQ
parent ed38f4f06c
commit 7a9724ae18
2 changed files with 70 additions and 0 deletions

@ -201,6 +201,11 @@ all other fields bundled together as a serialized protobuf string.
"suggested spellings, which will be displayed in the context menu."
trigger: "User types text into a text field or asks to correct a "
"misspelled word."
internal {
contacts {
email: "chrome-spellcheck@google.com"
}
}
user_data {
type: USER_CONTENT
}
@ -245,6 +250,10 @@ all other fields bundled together as a serialized protobuf string.
email: "chrome-safebrowsing@google.com"
}
}
user_data {
type: NONE
}
last_reviewed: "2023-01-01"
}
policy {
cookies_allowed: YES

@ -22,6 +22,18 @@ void network_traffic_annotation_template() {
trigger: "..."
data: "..."
destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER
internal {
contacts {
email: "..."
}
contacts {
email: "..."
}
}
user_data {
type: ...
}
last_reviewed: "YYYY-MM-DD"
}
policy {
cookies_allowed: NO/YES
@ -57,6 +69,18 @@ void network_traffic_annotation_sample() {
data: "Text a user has typed into a text field. No user identifier "
"is sent along with the text."
destination: GOOGLE_OWNED_SERVICE
internal {
contacts {
email: "john-doe@chromium.org"
}
contacts {
email: "spellcheck-team@google.com"
}
}
user_data {
type: USER_CONTENT
}
last_reviewed: "2023-01-01"
}
policy {
cookies_allowed: NO
@ -98,6 +122,18 @@ void PrefetchImage1(const GURL& url) {
"weather is sunny or rainy in the user's current location) from "
"the name of the image in the path."
destination: WEBSITE
internal {
contacts {
email: "john-doe@chromium.org"
}
contacts {
email: "omnibox-team@google.com"
}
}
user_data {
type: NONE
}
last_reviewed: "2023-01-01"
}
policy {
setting:
@ -133,6 +169,19 @@ void PrefetchImage2(const GURL& url) {
"Assuming there are matching credentials in the Chromium password "
"store, the avatars are retrieved."
destination: WEBSITE
internal {
contacts {
email: "john-doe@chromium.org"
}
contacts {
email: "password-manager-team@google.com"
}
}
user_data {
type: SENSITIVE_URL
type: ACCESS_TOKEN
}
last_reviewed: "2023-01-01"
}
policy {
setting:
@ -220,6 +269,18 @@ void UploadLog(const bool& uma_service_type) {
data:
"A protocol buffer with usage statistics and crash related data."
destination: GOOGLE_OWNED_SERVICE
internal {
contacts {
email: "john-doe@chromium.org"
}
contacts {
email: "metrics-team@google.com"
}
}
user_data {
type: OTHER
}
last_reviewed: "2023-01-01"
}
policy {
cookies_allowed: NO