chromium/src
0
Fork 0
Code Activity

Reland "[clank] Checkout AFDO profiles iff checkout_pgo_profiles = true"

Browse Source 
This reverts commit 6f96c16580.

Reason for revert: This reland adds the missing profile

Original change's description:
> Revert "[clank] Checkout AFDO profiles iff checkout_pgo_profiles = true"
>
> This reverts commit 5aa57b1b88.
>
> Reason for revert: Fix failing in https://ci.chromium.org/ui/p/chromium/builders/ci/android-official/22666/overview
>
> Original change's description:
> > [clank] Checkout AFDO profiles iff checkout_pgo_profiles = true
> >
> > These profiles are only needed on official builds. They're a waste to checkout unless actually needed.
> >
> > Checking them out on every workspace init also poses an issue for Cider integration. The Cider workflow involves creating many workspaces, which would eat up all the disk space if each workspace downloaded these large profiles.
> >
> > I manually checked all the android official and continuous official builders, and they set this variable to true. E.g. https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket/8731415215201822465/+/u/gclient_config/config
> >
> > Change-Id: I8de8460ac0a920fa15eb2c84740420cdeb0e37b4
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6018926
> > Commit-Queue: Gregory Guterman <guterman@google.com>
> > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> > Reviewed-by: George Burgess <gbiv@chromium.org>
> > Reviewed-by: Gary Tong <gatong@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1382478}
>
> Change-Id: Ibaa8c4c5bf14f83b447e8162bf36f97bbb2dfec8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6023545
> Owners-Override: Aya Elgendy‎ <ayag@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Auto-Submit: Aya Elgendy‎ <ayag@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1382921}

Change-Id: Ibc88f3c70b4fd1675c24275667105f0e28cf669c
Bug: b:375437208
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6023512
Commit-Queue: Gregory Guterman <guterman@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1383310}
This commit is contained in:
Greg Guterman
2024-11-14 23:19:05 +00:00
committed by Chromium LUCI CQ
parent 1210a3a823
commit 7a975a262e
4 changed files with 7 additions and 4 deletions
DEPS
infra/config
generated
builders
ci
android-official
properties.json
try
android-official
properties.json
subprojects
chromium
ci
chromium.star

4
DEPS

@ -5091,7 +5091,7 @@ hooks = [
{
'name': 'Fetch Android AFDO profile',
'pattern': '.',
'condition': 'checkout_android',
'condition': 'checkout_android and checkout_pgo_profiles',
'action': [ 'python3',
'src/tools/download_optimization_profile.py',
'--newest_state=src/chrome/android/profiles/newest.txt',
@ -5103,7 +5103,7 @@ hooks = [
{
'name': 'Fetch Android Arm AFDO profile',
'pattern': '.',
'condition': 'checkout_android',
'condition': 'checkout_android and checkout_pgo_profiles',
'action': [ 'python3',
'src/tools/download_optimization_profile.py',
'--newest_state=src/chrome/android/profiles/arm.newest.txt',

3
infra/config/generated/builders/ci/android-official/properties.json

@ -28,7 +28,8 @@
},
"legacy_gclient_config": {
"apply_configs": [
"android"
"android",
"checkout_pgo_profiles"
],
"config": "chromium"
}

3
infra/config/generated/builders/try/android-official/properties.json

@ -28,7 +28,8 @@
},
"legacy_gclient_config": {
"apply_configs": [
"android"
"android",
"checkout_pgo_profiles"
],
"config": "chromium"
}

1
infra/config/subprojects/chromium/ci/chromium.star

@ -297,6 +297,7 @@ ci.builder(
config = "chromium",
apply_configs = [
"android",
"checkout_pgo_profiles",
],
),
chromium_config = builder_config.chromium_config(