chromium/src
0
Fork 0
Code Activity

Mojo: Make closure compiler test targets for -lite bindings ash-only

Browse Source 
Only Ash UIs use either closure compiler or -lite style bindings, as
all Desktop UIs use mojom-webui bindings and TypeScript compiler for
typechecking.

Bug: 1316438
Change-Id: I1d29f12efb4d156afb44913490091564f340b878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4064523
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1078855}
This commit is contained in:
Rebekah Potter
2022-12-03 00:50:06 +00:00
committed by Chromium LUCI CQ
parent cd5a945840
commit 7b3051ce8e
2 changed files with 10 additions and 6 deletions
BUILD.gn
mojo/public/tools/bindings/generators/js_templates/lite/test
BUILD.gn

2
BUILD.gn

@ -1733,12 +1733,12 @@ if (enable_js_type_check) {
data_deps = [
"components/neterror/resources:closure_compile",
"components/security_interstitials:closure_compile",
"mojo/public/tools/bindings/generators/js_templates/lite/test:closure_compile",
"ui/webui/resources:closure_compile",
]
if (is_chromeos_ash) {
data_deps += [
"ash/webui:closure_compile",
"mojo/public/tools/bindings/generators/js_templates/lite/test:closure_compile",
"ui/file_manager:closure_compile",
]
}

14
mojo/public/tools/bindings/generators/js_templates/lite/test/BUILD.gn

@ -10,10 +10,14 @@ mojom("mojo_bindings") {
sources = [ "test.test-mojom" ]
}
js_type_check("closure_compile") {
deps = [ ":test" ]
}
# Lite style bindings, and closure compilation, are both only used for Mojo
# WebUIs on ChromeOS Ash.
if (is_chromeos_ash) {
js_type_check("closure_compile") {
deps = [ ":test" ]
}
js_library("test") {
deps = [ ":mojo_bindings_js_library_for_compile" ]
js_library("test") {
deps = [ ":mojo_bindings_js_library_for_compile" ]
}
}