chromium/src
0
Fork 0
Code Activity

Fix typo for Nullablity to Nullability

Browse Source 
Replace Nullability to Nullablity, which is a typo in
native_value_traits_buffer_sources.cc

Change-Id: Ia8c61870c75d3611a62e065ff4702a17ddfa71bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168682
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1410218}
This commit is contained in:
Wang Zirui
2025-01-23 03:09:00 -08:00
committed by Chromium LUCI CQ
parent c567aca5f2
commit 7b4b9de8ec
2 changed files with 34 additions and 33 deletions
AUTHORS
third_party/blink/renderer/bindings/core/v8
native_value_traits_buffer_sources.cc

1
AUTHORS

@ -1518,6 +1518,7 @@ Wojciech Bielawski <wojciech.bielawski@gmail.com>
Wang Chen <wangchen20@iscas.ac.cn>
Wang Chen <unicornxw@gmail.com>
Wang Weiwei <wangww@dingdao.com>
Wang Zirui <kingzirvi@gmail.com>
Wangyang Dai <jludwy@gmail.com>
Wanming Lin <wanming.lin@intel.com>
Wei Li <wei.c.li@intel.com>

66
third_party/blink/renderer/bindings/core/v8/native_value_traits_buffer_sources.cc vendored

@ -40,7 +40,7 @@ inline bool DoesExceedSizeLimit(v8::Isolate* isolate,
return DoesExceedSizeLimitSlow(isolate, exception_state);
}
enum class Nullablity {
enum class Nullability {
kIsNotNullable,
kIsNullable,
};
@ -56,7 +56,7 @@ enum class ResizableAllowance { kDisallowResizable, kAllowResizable };
// implementation for buffer source types.
template <typename RecipeTrait,
auto (*ToBlinkValue)(v8::Isolate*, v8::Local<v8::Value>),
Nullablity nullablity,
Nullability nullability,
BufferSizeCheck buffer_size_check,
ResizableAllowance allow_resizable,
typename ScriptWrappableOrBufferSourceTypeName,
@ -95,7 +95,7 @@ auto NativeValueImpl(v8::Isolate* isolate,
return RecipeTrait::ToReturnType(blink_value);
}
if constexpr (nullablity == Nullablity::kIsNullable) {
if constexpr (nullability == Nullability::kIsNullable) {
if (value->IsNullOrUndefined()) [[likely]] {
return RecipeTrait::NullValue();
}
@ -119,7 +119,7 @@ auto NativeValueImpl(v8::Isolate* isolate,
// implementation for buffer source types.
template <typename RecipeTrait,
auto (*ToBlinkValue)(v8::Isolate*, v8::Local<v8::Value>),
Nullablity nullablity,
Nullability nullability,
BufferSizeCheck buffer_size_check,
ResizableAllowance allow_resizable,
typename ScriptWrappableOrBufferSourceTypeName,
@ -159,7 +159,7 @@ auto ArgumentValueImpl(v8::Isolate* isolate,
return RecipeTrait::ToReturnType(blink_value);
}
if constexpr (nullablity == Nullablity::kIsNullable) {
if constexpr (nullability == Nullability::kIsNullable) {
if (value->IsNullOrUndefined()) [[likely]] {
return RecipeTrait::NullValue();
}
@ -457,7 +457,7 @@ DOMArrayBuffer* NativeValueTraits<DOMArrayBuffer>::NativeValue(
v8::Local<v8::Value> value,
ExceptionState& exception_state) {
return NativeValueImpl<RecipeTrait<DOMArrayBuffer>, ToDOMArrayBuffer,
Nullablity::kIsNotNullable, BufferSizeCheck::kCheck,
Nullability::kIsNotNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable,
DOMArrayBuffer>(isolate, value, exception_state);
}
@ -468,7 +468,7 @@ DOMArrayBuffer* NativeValueTraits<DOMArrayBuffer>::ArgumentValue(
v8::Local<v8::Value> value,
ExceptionState& exception_state) {
return ArgumentValueImpl<RecipeTrait<DOMArrayBuffer>, ToDOMArrayBuffer,
Nullablity::kIsNotNullable, BufferSizeCheck::kCheck,
Nullability::kIsNotNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable,
DOMArrayBuffer>(isolate, argument_index, value,
exception_state);
@ -481,7 +481,7 @@ DOMArrayBuffer* NativeValueTraits<IDLNullable<DOMArrayBuffer>>::NativeValue(
v8::Local<v8::Value> value,
ExceptionState& exception_state) {
return NativeValueImpl<RecipeTrait<DOMArrayBuffer>, ToDOMArrayBuffer,
Nullablity::kIsNullable, BufferSizeCheck::kCheck,
Nullability::kIsNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable,
DOMArrayBuffer>(isolate, value, exception_state);
}
@ -492,7 +492,7 @@ DOMArrayBuffer* NativeValueTraits<IDLNullable<DOMArrayBuffer>>::ArgumentValue(
v8::Local<v8::Value> value,
ExceptionState& exception_state) {
return ArgumentValueImpl<RecipeTrait<DOMArrayBuffer>, ToDOMArrayBuffer,
Nullablity::kIsNullable, BufferSizeCheck::kCheck,
Nullability::kIsNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable,
DOMArrayBuffer>(isolate, argument_index, value,
exception_state);
@ -506,7 +506,7 @@ NativeValueTraits<IDLAllowResizable<DOMArrayBuffer>>::NativeValue(
v8::Local<v8::Value> value,
ExceptionState& exception_state) {
return NativeValueImpl<RecipeTrait<DOMArrayBuffer>, ToDOMArrayBuffer,
Nullablity::kIsNotNullable, BufferSizeCheck::kCheck,
Nullability::kIsNotNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kAllowResizable, DOMArrayBuffer>(
isolate, value, exception_state);
}
@ -518,7 +518,7 @@ NativeValueTraits<IDLAllowResizable<DOMArrayBuffer>>::ArgumentValue(
v8::Local<v8::Value> value,
ExceptionState& exception_state) {
return ArgumentValueImpl<RecipeTrait<DOMArrayBuffer>, ToDOMArrayBuffer,
Nullablity::kIsNotNullable, BufferSizeCheck::kCheck,
Nullability::kIsNotNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kAllowResizable, DOMArrayBuffer>(
isolate, argument_index, value, exception_state);
}
@ -531,7 +531,7 @@ DOMSharedArrayBuffer* NativeValueTraits<DOMSharedArrayBuffer>::NativeValue(
ExceptionState& exception_state) {
return NativeValueImpl<
RecipeTrait<DOMSharedArrayBuffer>, ToDOMSharedArrayBuffer,
Nullablity::kIsNotNullable, BufferSizeCheck::kCheck,
Nullability::kIsNotNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable, DOMSharedArrayBuffer>(
isolate, value, exception_state);
}
@ -543,7 +543,7 @@ DOMSharedArrayBuffer* NativeValueTraits<DOMSharedArrayBuffer>::ArgumentValue(
ExceptionState& exception_state) {
return ArgumentValueImpl<
RecipeTrait<DOMSharedArrayBuffer>, ToDOMSharedArrayBuffer,
Nullablity::kIsNotNullable, BufferSizeCheck::kCheck,
Nullability::kIsNotNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable, DOMSharedArrayBuffer>(
isolate, argument_index, value, exception_state);
}
@ -557,7 +557,7 @@ NativeValueTraits<IDLNullable<DOMSharedArrayBuffer>>::NativeValue(
ExceptionState& exception_state) {
return NativeValueImpl<
RecipeTrait<DOMSharedArrayBuffer>, ToDOMSharedArrayBuffer,
Nullablity::kIsNullable, BufferSizeCheck::kCheck,
Nullability::kIsNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable, DOMSharedArrayBuffer>(
isolate, value, exception_state);
}
@ -570,7 +570,7 @@ NativeValueTraits<IDLNullable<DOMSharedArrayBuffer>>::ArgumentValue(
ExceptionState& exception_state) {
return ArgumentValueImpl<
RecipeTrait<DOMSharedArrayBuffer>, ToDOMSharedArrayBuffer,
Nullablity::kIsNullable, BufferSizeCheck::kCheck,
Nullability::kIsNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable, DOMSharedArrayBuffer>(
isolate, argument_index, value, exception_state);
}
@ -584,7 +584,7 @@ NativeValueTraits<IDLAllowResizable<DOMSharedArrayBuffer>>::NativeValue(
ExceptionState& exception_state) {
return NativeValueImpl<
RecipeTrait<DOMSharedArrayBuffer>, ToDOMSharedArrayBuffer,
Nullablity::kIsNotNullable, BufferSizeCheck::kCheck,
Nullability::kIsNotNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kAllowResizable, DOMSharedArrayBuffer>(
isolate, value, exception_state);
}
@ -597,7 +597,7 @@ NativeValueTraits<IDLAllowResizable<DOMSharedArrayBuffer>>::ArgumentValue(
ExceptionState& exception_state) {
return ArgumentValueImpl<
RecipeTrait<DOMSharedArrayBuffer>, ToDOMSharedArrayBuffer,
Nullablity::kIsNotNullable, BufferSizeCheck::kCheck,
Nullability::kIsNotNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kAllowResizable, DOMSharedArrayBuffer>(
isolate, argument_index, value, exception_state);
}
@ -609,7 +609,7 @@ DOMArrayBufferBase* NativeValueTraits<DOMArrayBufferBase>::NativeValue(
v8::Local<v8::Value> value,
ExceptionState& exception_state) {
return NativeValueImpl<RecipeTrait<DOMArrayBufferBase>, ToDOMArrayBufferBase,
Nullablity::kIsNotNullable, BufferSizeCheck::kCheck,
Nullability::kIsNotNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable,
BufferSourceTypeNameAllowSharedArrayBuffer>(
isolate, value, exception_state);
@ -621,7 +621,7 @@ DOMArrayBufferBase* NativeValueTraits<DOMArrayBufferBase>::ArgumentValue(
v8::Local<v8::Value> value,
ExceptionState& exception_state) {
return ArgumentValueImpl<RecipeTrait<DOMArrayBufferBase>,
ToDOMArrayBufferBase, Nullablity::kIsNotNullable,
ToDOMArrayBufferBase, Nullability::kIsNotNullable,
BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable,
BufferSourceTypeNameAllowSharedArrayBuffer>(
@ -636,7 +636,7 @@ DOMArrayBufferBase* NativeValueTraits<IDLBufferSourceTypeNoSizeLimit<
v8::Local<v8::Value> value,
ExceptionState& exception_state) {
return ArgumentValueImpl<RecipeTrait<DOMArrayBufferBase>,
ToDOMArrayBufferBase, Nullablity::kIsNotNullable,
ToDOMArrayBufferBase, Nullability::kIsNotNullable,
BufferSizeCheck::kDoNotCheck,
ResizableAllowance::kDisallowResizable,
BufferSourceTypeNameAllowSharedArrayBuffer>(
@ -651,7 +651,7 @@ NativeValueTraits<IDLNullable<DOMArrayBufferBase>>::NativeValue(
v8::Local<v8::Value> value,
ExceptionState& exception_state) {
return NativeValueImpl<RecipeTrait<DOMArrayBufferBase>, ToDOMArrayBufferBase,
Nullablity::kIsNullable, BufferSizeCheck::kCheck,
Nullability::kIsNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable,
BufferSourceTypeNameAllowSharedArrayBuffer>(
isolate, value, exception_state);
@ -664,7 +664,7 @@ NativeValueTraits<IDLNullable<DOMArrayBufferBase>>::ArgumentValue(
v8::Local<v8::Value> value,
ExceptionState& exception_state) {
return ArgumentValueImpl<RecipeTrait<DOMArrayBufferBase>,
ToDOMArrayBufferBase, Nullablity::kIsNullable,
ToDOMArrayBufferBase, Nullability::kIsNullable,
BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable,
BufferSourceTypeNameAllowSharedArrayBuffer>(
@ -680,7 +680,7 @@ DOMArrayBufferBase* NativeValueTraits<
v8::Local<v8::Value> value,
ExceptionState& exception_state) {
return ArgumentValueImpl<RecipeTrait<DOMArrayBufferBase>,
ToDOMArrayBufferBase, Nullablity::kIsNullable,
ToDOMArrayBufferBase, Nullability::kIsNullable,
BufferSizeCheck::kDoNotCheck,
ResizableAllowance::kDisallowResizable,
BufferSourceTypeNameAllowSharedArrayBuffer>(
@ -697,7 +697,7 @@ NotShared<T> NativeValueTraits<NotShared<T>>::NativeValue(
ExceptionState& exception_state) {
return NativeValueImpl<
RecipeTrait<NotShared<T>>, ToDOMViewType<T, kNotShared>,
Nullablity::kIsNotNullable, BufferSizeCheck::kCheck,
Nullability::kIsNotNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable, T, ABVTrait<T>::IsShared>(
isolate, value, exception_state);
}
@ -711,7 +711,7 @@ NotShared<T> NativeValueTraits<NotShared<T>>::ArgumentValue(
ExceptionState& exception_state) {
return ArgumentValueImpl<
RecipeTrait<NotShared<T>>, ToDOMViewType<T, kNotShared>,
Nullablity::kIsNotNullable, BufferSizeCheck::kCheck,
Nullability::kIsNotNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable, T, ABVTrait<T>::IsShared>(
isolate, argument_index, value, exception_state);
}
@ -726,7 +726,7 @@ MaybeShared<T> NativeValueTraits<MaybeShared<T>>::NativeValue(
ExceptionState& exception_state) {
return NativeValueImpl<RecipeTrait<MaybeShared<T>>,
ToDOMViewType<T, kMaybeShared>,
Nullablity::kIsNotNullable, BufferSizeCheck::kCheck,
Nullability::kIsNotNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable, T>(
isolate, value, exception_state);
}
@ -740,7 +740,7 @@ MaybeShared<T> NativeValueTraits<MaybeShared<T>>::ArgumentValue(
ExceptionState& exception_state) {
return ArgumentValueImpl<RecipeTrait<MaybeShared<T>>,
ToDOMViewType<T, kMaybeShared>,
Nullablity::kIsNotNullable, BufferSizeCheck::kCheck,
Nullability::kIsNotNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable, T>(
isolate, argument_index, value, exception_state);
}
@ -756,7 +756,7 @@ MaybeShared<T> NativeValueTraits<IDLBufferSourceTypeNoSizeLimit<
ExceptionState& exception_state) {
return ArgumentValueImpl<
RecipeTrait<MaybeShared<T>>, ToDOMViewType<T, kMaybeShared>,
Nullablity::kIsNotNullable, BufferSizeCheck::kDoNotCheck,
Nullability::kIsNotNullable, BufferSizeCheck::kDoNotCheck,
ResizableAllowance::kDisallowResizable, T>(isolate, argument_index, value,
exception_state);
}
@ -771,7 +771,7 @@ NotShared<T> NativeValueTraits<IDLNullable<NotShared<T>>>::NativeValue(
ExceptionState& exception_state) {
return NativeValueImpl<
RecipeTrait<NotShared<T>>, ToDOMViewType<T, kNotShared>,
Nullablity::kIsNullable, BufferSizeCheck::kCheck,
Nullability::kIsNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable, T, ABVTrait<T>::IsShared>(
isolate, value, exception_state);
}
@ -785,7 +785,7 @@ NotShared<T> NativeValueTraits<IDLNullable<NotShared<T>>>::ArgumentValue(
ExceptionState& exception_state) {
return ArgumentValueImpl<
RecipeTrait<NotShared<T>>, ToDOMViewType<T, kNotShared>,
Nullablity::kIsNullable, BufferSizeCheck::kCheck,
Nullability::kIsNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable, T, ABVTrait<T>::IsShared>(
isolate, argument_index, value, exception_state);
}
@ -800,7 +800,7 @@ MaybeShared<T> NativeValueTraits<IDLNullable<MaybeShared<T>>>::NativeValue(
ExceptionState& exception_state) {
return NativeValueImpl<RecipeTrait<MaybeShared<T>>,
ToDOMViewType<T, kMaybeShared>,
Nullablity::kIsNullable, BufferSizeCheck::kCheck,
Nullability::kIsNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable, T>(
isolate, value, exception_state);
}
@ -814,7 +814,7 @@ MaybeShared<T> NativeValueTraits<IDLNullable<MaybeShared<T>>>::ArgumentValue(
ExceptionState& exception_state) {
return ArgumentValueImpl<RecipeTrait<MaybeShared<T>>,
ToDOMViewType<T, kMaybeShared>,
Nullablity::kIsNullable, BufferSizeCheck::kCheck,
Nullability::kIsNullable, BufferSizeCheck::kCheck,
ResizableAllowance::kDisallowResizable, T>(
isolate, argument_index, value, exception_state);
}
@ -831,7 +831,7 @@ NativeValueTraits<IDLNullable<IDLBufferSourceTypeNoSizeLimit<MaybeShared<T>>>>::
ExceptionState& exception_state) {
return ArgumentValueImpl<
RecipeTrait<MaybeShared<T>>, ToDOMViewType<T, kMaybeShared>,
Nullablity::kIsNullable, BufferSizeCheck::kDoNotCheck,
Nullability::kIsNullable, BufferSizeCheck::kDoNotCheck,
ResizableAllowance::kDisallowResizable, T>(isolate, argument_index, value,
exception_state);
}