chromium/src
0
Fork 0
Code Activity

Re-format plugin section in clang docs.

Browse Source 
Make it more obvious that the tests run as part of the incremental
build are *not* the full suite of tests required.

Change-Id: Ibf77020a45a0f613f5f2dab0bdac353e271c90d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6282727
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1422109}
This commit is contained in:
Tom Sepez
2025-02-19 11:36:38 -08:00
committed by Chromium LUCI CQ
parent 0ac3a24311
commit 7b8dfcaa71
1 changed files with 5 additions and 7 deletions

12
docs/clang.md

@ -28,13 +28,11 @@ If you're working on the plugin, you can build it locally like so:
1. Run `./tools/clang/scripts/build.py --without-android --without-fuchsia`
to build the plugin.
1. Run `ninja -C third_party/llvm-build/Release+Asserts/` to build incrementally.
1. Build with clang like described above, but, if you use reclient, disable it.
To test the FindBadConstructs plugin, run:
(cd tools/clang/plugins/tests && \
./test.py ../../../../third_party/llvm-build/Release+Asserts/bin/clang)
1. Run `ninja -C third_party/llvm-build/Release+Asserts/` to build
incrementally after making changes.
1. Run `(cd tools/clang/plugins/tests && ./test.py ../../../../third_party/llvm-build/Release+Asserts/bin/clang)`
to test the plugin after making changes.
1. Build Chromium with clang as usual, but, if you use reclient, disable it.
Since the plugin is rolled with clang changes, behavior changes to the plugin
should be guarded by flags to make it easy to roll clang. A general outline: