0

[Quick Share v2] Correct settings button tooltip

Change the settings button tooltip in the Quick Share quick settings
detailed dialog to "Quick Share settings" from "Nearby visibility."

Before
------
https://screenshot.googleplex.com/Bxw2ExXAys5SdLb.png

After
-----
https://screenshot.googleplex.com/Bconcqu4nUHHtEa.png

Tested: verified on DUT.
Bug: b/323206955
Change-Id: I05300b40964e74897223b16853f8cff740149df9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6193928
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Brando Socarras <brandosocarras@google.com>
Cr-Commit-Position: refs/heads/main@{#1411775}
This commit is contained in:
Brando Socarras
2025-01-27 11:20:38 -08:00
committed by Chromium LUCI CQ
parent 65f37733c8
commit 7be50d928b
3 changed files with 10 additions and 0 deletions

@ -452,6 +452,9 @@ Style notes:
<message name="IDS_ASH_STATUS_TRAY_NEARBY_SHARE_BUTTON_LABEL" desc="The shorter label used for the button in the status tray to toggle Nearby Share high visibility mode, which makes the device visible to all nearby devices for file sharing.">
Nearby visibility
</message>
<message name="IDS_ASH_STATUS_TRAY_NEARBY_SHARE_DETAILED_VIEW_SETTINGS_BUTTON_TOOLTIP" desc="Settings button tooltip.">
Quick Share settings
</message>
<message name="IDS_ASH_STATUS_TRAY_NEARBY_SHARE_DETAILED_VIEW_CONTACTS_SUBLABEL" desc="The sublabel in the Contacts visibility row.">
Only your contacts with a Google Account
</message>

@ -0,0 +1 @@
fe791d89929af14bc619efce25730bb832c4bff3

@ -115,6 +115,11 @@ std::u16string GetEveryoneSublabel() {
return l10n_util::GetStringUTF16(
IDS_ASH_STATUS_TRAY_NEARBY_SHARE_DETAILED_VIEW_EVERYONE_SUBLABEL);
}
std::u16string GetSettingsButtonTooltip() {
return l10n_util::GetStringUTF16(
IDS_ASH_STATUS_TRAY_NEARBY_SHARE_DETAILED_VIEW_SETTINGS_BUTTON_TOOLTIP);
}
} // namespace
namespace ash {
@ -148,6 +153,7 @@ void NearbyShareDetailedViewImpl::CreateExtraTitleRowButtons() {
settings_button_->SetState(TrayPopupUtils::CanOpenWebUISettings()
? views::Button::STATE_NORMAL
: views::Button::STATE_DISABLED);
settings_button_->SetTooltipText(GetSettingsButtonTooltip());
tri_view()->AddView(TriView::Container::END, settings_button_);
}