Use exec_script_allowlist
in the GN dotfile (//.gn).
GN now supports `exec_script_allowlist` as an alternative/synonym for `exec_script_whitelist`, so we should move to it to be more inclusive and accurate. Bug: 389986807 Change-Id: I2e98d17d89d952b9b9e5841e99c02611faf4db0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6174604 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by: Fumitoshi Ukai <ukai@google.com> Cr-Commit-Position: refs/heads/main@{#1406425}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
a469802437
commit
7c6c78ad4e
8
.gn
8
.gn
@ -90,7 +90,7 @@ no_check_targets = [
|
||||
"//v8:v8_libplatform", # 2 errors
|
||||
]
|
||||
|
||||
# These are the list of GN files that run exec_script. This whitelist exists
|
||||
# These are the list of GN files that run exec_script. This allowlist exists
|
||||
# to force additional review for new uses of exec_script, which is strongly
|
||||
# discouraged.
|
||||
#
|
||||
@ -145,11 +145,11 @@ no_check_targets = [
|
||||
# this situation much easier to create. if the build always lists the
|
||||
# files and passes them to a script, it will always be correct.
|
||||
|
||||
exec_script_whitelist =
|
||||
build_dotfile_settings.exec_script_whitelist +
|
||||
exec_script_allowlist =
|
||||
build_dotfile_settings.exec_script_allowlist +
|
||||
angle_dotfile_settings.exec_script_whitelist +
|
||||
[
|
||||
# Whitelist entries for //build should go into
|
||||
# Allowlist entries for //build should go into
|
||||
# //build/dotfile_settings.gni instead, so that they can be shared
|
||||
# with other repos. The entries in this list should be only for files
|
||||
# in the Chromium repo outside of //build.
|
||||
|
@ -6,7 +6,7 @@
|
||||
# to make it easier to roll new versions of //build in.
|
||||
|
||||
build_dotfile_settings = {
|
||||
exec_script_whitelist = [
|
||||
exec_script_allowlist = [
|
||||
"//build/config/android/rules.gni",
|
||||
"//build/config/apple/mobile_config.gni",
|
||||
"//build/config/chromeos/rules.gni",
|
||||
@ -42,4 +42,8 @@ build_dotfile_settings = {
|
||||
"//build/toolchain/zos/BUILD.gn",
|
||||
"//build/util/branding.gni",
|
||||
]
|
||||
|
||||
# TODO(crbug.com/389986807) - move other clients to `exec_script_allowlist`
|
||||
# so that we don't need to keep supporting `exec_script_whitelist`.
|
||||
exec_script_whitelist = exec_script_allowlist
|
||||
}
|
||||
|
Reference in New Issue
Block a user