chromium/src
0
Fork 0
Code Activity

Remove set_sources_assignment_filter from //ipc

Browse Source 
set_sources_assignment_filter() is considered as a mis-feature
of gn (as it makes it difficult to reason about the BUILD.gn
files individually).

Bug: 1018739
Change-Id: I78aa860978a9d6426974b4f057fbc166b892a436
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409904
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806978}
This commit is contained in:
Sylvain Defresne
2020-09-15 11:26:44 +00:00
committed by Commit Bot
parent f419956443
commit 7d89ef09a7
1 changed files with 24 additions and 8 deletions

32
ipc/BUILD.gn

@ -10,6 +10,12 @@ import("//testing/test.gni")
import("//third_party/protobuf/proto_library.gni")
import("//tools/ipc_fuzzer/ipc_fuzzer.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
buildflag_header("ipc_buildflags") {
header = "ipc_buildflags.h"
@ -117,10 +123,6 @@ component("ipc") {
component("message_support") {
sources = [
"handle_attachment_win.cc",
"handle_attachment_win.h",
"handle_win.cc",
"handle_win.h",
"ipc_message.cc",
"ipc_message.h",
"ipc_message_attachment.cc",
@ -136,12 +138,17 @@ component("message_support") {
"ipc_platform_file.h",
"ipc_sync_message.cc",
"ipc_sync_message.h",
"mach_port_attachment_mac.cc",
"mach_port_attachment_mac.h",
"mach_port_mac.cc",
"mach_port_mac.h",
]
if (is_win) {
sources += [
"handle_attachment_win.cc",
"handle_attachment_win.h",
"handle_win.cc",
"handle_win.h",
]
}
if (is_posix || is_fuchsia) {
sources += [
"ipc_platform_file_attachment_posix.cc",
@ -149,6 +156,15 @@ component("message_support") {
]
}
if (is_mac) {
sources += [
"mach_port_attachment_mac.cc",
"mach_port_attachment_mac.h",
"mach_port_mac.cc",
"mach_port_mac.h",
]
}
if (is_fuchsia) {
sources += [
"handle_attachment_fuchsia.cc",