Remove testless it2me_desktop_environment_unittest.cc
Over time, all tests have either been moved or removed from this file, leaving just some unused boilerplate. Change-Id: Ibf7684158396d6d85156e6da8ed827d608a9e6db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6022057 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/main@{#1383082}
This commit is contained in:
Erik Jensen
committed by
Chromium LUCI CQ
Chromium LUCI CQ
parent
92101d1cfe
commit
7e4eae30c8
remoting/host
@ -876,7 +876,6 @@ source_set("unit_tests") {
|
||||
"it2me/it2me_confirmation_dialog_proxy_unittest.cc",
|
||||
"it2me/it2me_host_unittest.cc",
|
||||
"it2me/it2me_native_messaging_host_unittest.cc",
|
||||
"it2me_desktop_environment_unittest.cc",
|
||||
"mojo_video_capturer_list_unittest.cc",
|
||||
"mouse_cursor_monitor_proxy_unittest.cc",
|
||||
"mouse_shape_pump_unittest.cc",
|
||||
|
||||
@ -1,194 +0,0 @@
|
||||
// Copyright 2022 The Chromium Authors
|
||||
// Use of this source code is governed by a BSD-style license that can be
|
||||
// found in the LICENSE file.
|
||||
|
||||
#include "remoting/host/it2me_desktop_environment.h"
|
||||
|
||||
#include <memory>
|
||||
|
||||
#include "base/memory/scoped_refptr.h"
|
||||
#include "base/memory/weak_ptr.h"
|
||||
#include "base/task/single_thread_task_runner.h"
|
||||
#include "base/test/scoped_feature_list.h"
|
||||
#include "base/test/task_environment.h"
|
||||
#include "remoting/host/base/desktop_environment_options.h"
|
||||
#include "remoting/host/chromeos/scoped_fake_ash_proxy.h"
|
||||
#include "remoting/host/client_session_control.h"
|
||||
#include "remoting/host/client_session_events.h"
|
||||
#include "remoting/proto/control.pb.h"
|
||||
#include "remoting/protocol/capability_names.h"
|
||||
#include "remoting/protocol/errors.h"
|
||||
#include "testing/gmock/include/gmock/gmock.h"
|
||||
#include "testing/gtest/include/gtest/gtest.h"
|
||||
|
||||
#if BUILDFLAG(IS_CHROMEOS)
|
||||
#include "components/user_manager/fake_user_manager.h"
|
||||
#include "components/user_manager/scoped_user_manager.h"
|
||||
#include "remoting/host/chromeos/features.h"
|
||||
#include "remoting/host/chromeos/scoped_fake_ash_proxy.h"
|
||||
#endif // BUILDFLAG(IS_CHROMEOS)
|
||||
|
||||
namespace remoting {
|
||||
|
||||
namespace {
|
||||
|
||||
#if BUILDFLAG(IS_CHROMEOS)
|
||||
constexpr char kTestEmail[] = "test@localhost";
|
||||
#endif
|
||||
|
||||
} // namespace
|
||||
namespace {
|
||||
|
||||
using ::testing::Eq;
|
||||
using ::testing::IsNull;
|
||||
|
||||
class ClientSessionControlMock : public ClientSessionControl {
|
||||
public:
|
||||
ClientSessionControlMock() = default;
|
||||
ClientSessionControlMock(const ClientSessionControlMock&) = delete;
|
||||
ClientSessionControlMock& operator=(const ClientSessionControlMock&) = delete;
|
||||
~ClientSessionControlMock() override = default;
|
||||
|
||||
// ClientSessionControl implementation:
|
||||
const std::string& client_jid() const override { return client_jid_; }
|
||||
MOCK_METHOD(void, DisconnectSession, (protocol::ErrorCode error));
|
||||
MOCK_METHOD(void,
|
||||
OnLocalPointerMoved,
|
||||
(const webrtc::DesktopVector& position, ui::EventType type));
|
||||
MOCK_METHOD(void, OnLocalKeyPressed, (uint32_t usb_keycode));
|
||||
MOCK_METHOD(void, SetDisableInputs, (bool disable_inputs));
|
||||
MOCK_METHOD(void,
|
||||
OnDesktopDisplayChanged,
|
||||
(std::unique_ptr<protocol::VideoLayout> layout));
|
||||
|
||||
base::WeakPtr<ClientSessionControlMock> GetWeakPtr() {
|
||||
return weak_ptr_factory_.GetWeakPtr();
|
||||
}
|
||||
|
||||
private:
|
||||
std::string client_jid_ = "<fake-client-jid>";
|
||||
base::WeakPtrFactory<ClientSessionControlMock> weak_ptr_factory_{this};
|
||||
};
|
||||
|
||||
class FakeClientSessionEvents : public ClientSessionEvents {
|
||||
public:
|
||||
FakeClientSessionEvents() = default;
|
||||
FakeClientSessionEvents(const FakeClientSessionEvents&) = delete;
|
||||
FakeClientSessionEvents& operator=(const FakeClientSessionEvents&) = delete;
|
||||
~FakeClientSessionEvents() override = default;
|
||||
|
||||
// ClientSessionEvents implementation:
|
||||
void OnDesktopAttached(uint32_t session_id) override {}
|
||||
void OnDesktopDetached() override {}
|
||||
|
||||
base::WeakPtr<FakeClientSessionEvents> GetWeakPtr() {
|
||||
return weak_ptr_factory_.GetWeakPtr();
|
||||
}
|
||||
|
||||
private:
|
||||
base::WeakPtrFactory<FakeClientSessionEvents> weak_ptr_factory_{this};
|
||||
};
|
||||
|
||||
class It2MeDesktopEnvironmentTest : public ::testing::Test {
|
||||
public:
|
||||
#if BUILDFLAG(IS_CHROMEOS)
|
||||
It2MeDesktopEnvironmentTest()
|
||||
: scoped_user_manager_(std::make_unique<user_manager::FakeUserManager>()),
|
||||
fake_user_manager_(*static_cast<user_manager::FakeUserManager*>(
|
||||
user_manager::UserManager::Get())) {}
|
||||
#endif
|
||||
|
||||
~It2MeDesktopEnvironmentTest() override = default;
|
||||
|
||||
void SetUp() override {
|
||||
#if BUILDFLAG(IS_CHROMEOS)
|
||||
feature_list_.InitAndEnableFeature(features::kEnableCrdAdminRemoteAccess);
|
||||
#endif // BUILDFLAG(IS_CHROMEOS)
|
||||
}
|
||||
|
||||
#if BUILDFLAG(IS_CHROMEOS)
|
||||
void TearDown() override {
|
||||
// Wait until DeleteSoon is finished.
|
||||
environment_.RunUntilIdle();
|
||||
}
|
||||
#endif // BUILDFLAG(IS_CHROMEOS)
|
||||
|
||||
DesktopEnvironmentOptions default_options() {
|
||||
DesktopEnvironmentOptions options;
|
||||
// These options must be false or we run into crashes in HostWindowProxy.
|
||||
options.set_enable_user_interface(false);
|
||||
options.set_enable_notifications(false);
|
||||
return options;
|
||||
}
|
||||
|
||||
scoped_refptr<base::SingleThreadTaskRunner> task_runner() {
|
||||
return environment_.GetMainThreadTaskRunner();
|
||||
}
|
||||
|
||||
std::unique_ptr<It2MeDesktopEnvironment> Create(
|
||||
DesktopEnvironmentOptions options) {
|
||||
auto base_ptr = It2MeDesktopEnvironmentFactory(task_runner(), task_runner(),
|
||||
task_runner(), task_runner())
|
||||
.Create(session_control_.GetWeakPtr(),
|
||||
session_events_.GetWeakPtr(), options);
|
||||
// Cast to It2MeDesktopEnvironment
|
||||
auto desktop_environment = std::unique_ptr<It2MeDesktopEnvironment>(
|
||||
static_cast<It2MeDesktopEnvironment*>(base_ptr.release()));
|
||||
|
||||
// Give the code time to instantiate the curtain mode on the UI sequence (if
|
||||
// needed).
|
||||
FlushUiSequence();
|
||||
return desktop_environment;
|
||||
}
|
||||
|
||||
std::unique_ptr<It2MeDesktopEnvironment> CreateCurtainedSession() {
|
||||
DesktopEnvironmentOptions options(default_options());
|
||||
options.set_enable_curtaining(true);
|
||||
return Create(options);
|
||||
}
|
||||
|
||||
void FlushUiSequence() {
|
||||
// In our test scenario all sequences are single threaded,
|
||||
// so to flush the UI sequence we can simply flush the main thread.
|
||||
environment_.RunUntilIdle();
|
||||
}
|
||||
|
||||
#if BUILDFLAG(IS_CHROMEOS)
|
||||
test::ScopedFakeAshProxy& ash_proxy() { return ash_proxy_; }
|
||||
|
||||
user_manager::FakeUserManager& user_manager() { return *fake_user_manager_; }
|
||||
|
||||
void LogInUser() {
|
||||
auto account_id = AccountId::FromUserEmail(kTestEmail);
|
||||
user_manager().AddPublicAccountUser(account_id);
|
||||
user_manager().UserLoggedIn(account_id, account_id.GetUserEmail(), false,
|
||||
false);
|
||||
}
|
||||
|
||||
void LogOutUser() {
|
||||
user_manager().LogoutAllUsers();
|
||||
auto account_id = AccountId::FromUserEmail(kTestEmail);
|
||||
user_manager().RemoveUserFromList(account_id);
|
||||
}
|
||||
|
||||
ClientSessionControlMock& session_control() { return session_control_; }
|
||||
|
||||
#endif // BUILDFLAG(IS_CHROMEOS)
|
||||
|
||||
private:
|
||||
base::test::SingleThreadTaskEnvironment environment_;
|
||||
|
||||
base::test::ScopedFeatureList feature_list_;
|
||||
testing::StrictMock<ClientSessionControlMock> session_control_;
|
||||
FakeClientSessionEvents session_events_;
|
||||
|
||||
#if BUILDFLAG(IS_CHROMEOS)
|
||||
test::ScopedFakeAshProxy ash_proxy_;
|
||||
|
||||
user_manager::ScopedUserManager scoped_user_manager_;
|
||||
const raw_ref<user_manager::FakeUserManager> fake_user_manager_;
|
||||
#endif // BUILDFLAG(IS_CHROMEOS)
|
||||
};
|
||||
|
||||
} // namespace
|
||||
} // namespace remoting
|
||||
Reference in New Issue
Block a user