chromium/src
0
Fork 0
Code Activity

Revert "[Reland] WebUI: Turn on ESLint JS presubmit checks for ios/ folder."

Browse Source 
This reverts commit d8d407d71b.

Reason for revert: might have caused builder failures
crbug.com/398274433

Original change's description:
> [Reland] WebUI: Turn on ESLint JS presubmit checks for ios/ folder.
>
> Reland notes: Limiting the original change to only apply to JS files
> instead of both JS and TS, as there are still TS violations that need to
> be fixed. Also confirmed that the following command passes locally
> `git cl presubmit --files="ios/*.ts;ios/*.js"`
>
> Also adding CheckChangeOnCommit() which was previously erroneously
> missing, causing `git cl presubmit --files=...` to not behave
> equivalently to `git cl upload`.
>
> Bug: 40519637
> Change-Id: I3be6f2a7bf5d89c32d3ae316e2568baa8b509411
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6287035
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1423237}

Bug: 40519637, 398274433
Change-Id: I45eb962de484a6bc60557de3c5f3f2501618acd3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6292786
Owners-Override: Muyao Xu <muyaoxu@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Muyao Xu <muyaoxu@google.com>
Auto-Submit: Muyao Xu <muyaoxu@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1423376}
This commit is contained in:
Muyao Xu
2025-02-21 13:16:09 -08:00
committed by Chromium LUCI CQ
parent ef8018e1d6
commit 7f18fb6485
2 changed files with 1 additions and 33 deletions
ios
PRESUBMIT.py
tools/web_dev_style
eslint.config.mjs

28
ios/PRESUBMIT.py

@ -414,24 +414,7 @@ def _CheckNewColorIntroduction(input_api, output_api):
return output
def _CheckStyleESLint(input_api, output_api):
results = []
try:
import sys
old_sys_path = sys.path[:]
cwd = input_api.PresubmitLocalPath()
sys.path += [input_api.os_path.join(cwd, '..', 'tools')]
from web_dev_style import presubmit_support
results += presubmit_support.CheckStyleESLint(input_api, output_api)
finally:
sys.path = old_sys_path
return results
def CheckChange(input_api, output_api):
def CheckChangeOnUpload(input_api, output_api):
results = []
results.extend(_CheckBugInToDo(input_api, output_api))
results.extend(_CheckNullabilityAnnotations(input_api, output_api))
@ -443,13 +426,4 @@ def CheckChange(input_api, output_api):
results.extend(_CheckOrderedStringFile(input_api, output_api))
results.extend(_CheckNotUsingNSUserDefaults(input_api, output_api))
results.extend(_CheckNewColorIntroduction(input_api, output_api))
results.extend(_CheckStyleESLint(input_api, output_api))
return results
def CheckChangeOnUpload(input_api, output_api):
return CheckChange(input_api, output_api)
def CheckChangeOnCommit(input_api, output_api):
return CheckChange(input_api, output_api)

6
tools/web_dev_style/eslint.config.mjs

@ -16,12 +16,6 @@ export default [
'chrome/browser/resources/gaia_auth_host/authenticator.js',
'chrome/browser/resources/gaia_auth_host/password_change_authenticator.js',
// Ignore generated checked-in JS file.
'ios/tools/documents_statistics_viewer/tsc/viewer.js',
// TODO(crbug.com/397907153): Fix violations and remove from ignore list.
'ios/**/*.ts',
// No point linting auto-generated files.
'tools/typescript/definitions/**/*',