chromium/src
0
Fork 0
Code Activity

Remove expired V13 cookie DB metrics

Browse Source 
Obsolete and remove
Cookie.TimeDatabaseMigrationToV13Failure
Cookie.TimeDatabaseMigrationToV13Success

Bug: 1251291
Change-Id: I82b44d406f705859c35124047443742389d10150
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3260474
Reviewed-by: Chris Fredrickson <cfredric@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Steven Bingler <bingler@chromium.org>
Cr-Commit-Position: refs/heads/main@{#938384}
This commit is contained in:
Steven Bingler
2021-11-04 18:54:20 +00:00
committed by Chromium LUCI CQ
parent 0acbf8d5cb
commit 7f84c66493
2 changed files with 8 additions and 16 deletions
net/extras/sqlite
sqlite_persistent_cookie_store.cc
tools/metrics/histograms/metadata/cookie
histograms.xml

18
net/extras/sqlite/sqlite_persistent_cookie_store.cc

@ -1163,18 +1163,9 @@ SQLitePersistentCookieStore::Backend::DoMigrateDatabaseSchema() {
}
if (cur_version == 12) {
const char kMigrationSuccessHistogram[] =
"Cookie.TimeDatabaseMigrationToV13Success";
const char kMigrationFailureHistogram[] =
"Cookie.TimeDatabaseMigrationToV13Failure";
const base::TimeTicks start_time = base::TimeTicks::Now();
sql::Transaction transaction(db());
if (!transaction.Begin()) {
base::UmaHistogramTimes(kMigrationFailureHistogram,
base::TimeTicks::Now() - start_time);
if (!transaction.Begin())
return absl::nullopt;
}
std::string update_stmt(
base::StringPrintf("ALTER TABLE cookies ADD COLUMN source_port "
@ -1182,19 +1173,14 @@ SQLitePersistentCookieStore::Backend::DoMigrateDatabaseSchema() {
"ALTER TABLE cookies ADD COLUMN is_same_party "
"INTEGER NOT NULL DEFAULT 0;",
kDefaultUnknownPort));
if (!db()->Execute(update_stmt.c_str())) {
base::UmaHistogramTimes(kMigrationFailureHistogram,
base::TimeTicks::Now() - start_time);
if (!db()->Execute(update_stmt.c_str()))
return absl::nullopt;
}
++cur_version;
meta_table()->SetVersionNumber(cur_version);
meta_table()->SetCompatibleVersionNumber(
std::min(cur_version, kCompatibleVersionNumber));
transaction.Commit();
base::UmaHistogramTimes(kMigrationSuccessHistogram,
base::TimeTicks::Now() - start_time);
}
if (cur_version == 13) {

6
tools/metrics/histograms/metadata/cookie/histograms.xml

@ -942,6 +942,9 @@ chromium-metrics-reviews@google.com.
<histogram name="Cookie.TimeDatabaseMigrationToV13Failure" units="ms"
expires_after="2021-10-30">
<obsolete>
Removed Nov 2021: no longer needed and expired.
</obsolete>
<owner>bingler@chromium.org</owner>
<owner>morlovich@chromium.org</owner>
<summary>
@ -953,6 +956,9 @@ chromium-metrics-reviews@google.com.
<histogram name="Cookie.TimeDatabaseMigrationToV13Success" units="ms"
expires_after="2021-10-30">
<obsolete>
Removed Nov 2021: no longer needed and expired.
</obsolete>
<owner>bingler@chromium.org</owner>
<owner>morlovich@chromium.org</owner>
<summary>