chromium/src
0
Fork 0
Code Activity

New toolchain for Windows 11 10.0.22621.2428 SDK

Browse Source 
A couple of Chromium projects need access to Windows features that are
only exposed in the 2428 point release of 10.0.22621. The previous
toolchain package used the 10.0.22621.755 (Windows 11 22H2) SDK. This
follows the same packaging steps but it pulls in the latest SDK, thus
giving access to the new features.

When we start depending on the new SDK then developers who don't use the
packaged toolchain will need to update their locally installed SDK. The
changes that add the dependencies on the new SDK will check for it and
give error messages to guide developers.

Packaging was done on a Windows 10 Hyper-V VM, cleanly created for this
purpose. Specifically, the Hyper-V Quick Create tool was used to create
a Windows 11 dev environment. VS Community Edition was then uninstalled.

Then the package was created by installing depot_tools, downloading the
VS Professional 2022 installer from https://visualstudio.microsoft.com/downloads/
(free trial, not preview) and then running the installer like this:

$ PATH_TO_INSTALLER.EXE ^
    --add Microsoft.VisualStudio.Workload.NativeDesktop ^
    --add Microsoft.VisualStudio.Component.VC.ATLMFC ^
    --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^
    --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^
    --includeRecommended --passive

Then Add/Remove programs was used to modify the SDK to add the Debuggers
package.

Then the packaging script was run like this:

  python3 depot_tools\win_toolchain\package_from_installed.py 2022 -w 10.0.22621.0

The packaging process was done on new VMs hosted on two different
machines to make sure that the results were consistent.

Updates were made to the comments and documentation, however very few
updates were needed because the SDK change is just a point release.

Bug: 40282717, 325004812
Change-Id: I6f59d07755db715974c1c4590d751e14b85a409d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5350823
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Michael Tang <tangm@microsoft.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273698}
This commit is contained in:
Bruce Dawson
2024-03-15 22:31:20 +00:00
committed by Chromium LUCI CQ
parent 2ff2c97356
commit 7ff6e7df4c
2 changed files with 8 additions and 7 deletions

4
build/vs_toolchain.py

@ -17,7 +17,7 @@ import sys
from gn_helpers import ToGNString
# VS 2022 17.4 with 10.0.22621.0 SDK with ARM64 libraries and UWP support.
# VS 2022 17.9.2 with 10.0.22621.2428 SDK with ARM64 libraries and UWP support.
# See go/chromium-msvc-toolchain for instructions about how to update the
# toolchain.
#
@ -39,7 +39,7 @@ from gn_helpers import ToGNString
# Maps between Visual Studio version and MSVC toolset
# * MSVS_VERSIONS in this file
# Records the packaged and default version of Visual Studio
TOOLCHAIN_HASH = '27370823e7'
TOOLCHAIN_HASH = '7393122652'
SDK_VERSION = '10.0.22621.0'
script_dir = os.path.dirname(os.path.realpath(__file__))

11
docs/windows_build_instructions.md

@ -52,12 +52,13 @@ $ PATH_TO_INSTALLER.EXE ^
Required
* [Windows 11 SDK](https://developer.microsoft.com/en-us/windows/downloads/windows-sdk/)
version 10.0.22621.0. This can be installed separately or by checking the
version 10.0.22621.2428. This can be installed separately or by checking the
appropriate box in the Visual Studio Installer.
* (Windows 11) SDK Debugging Tools 10.0.22621.755. This version of the Debugging
tools is needed in order to support reading the large-page PDBs that Chrome uses
to allow greater-than 4 GiB PDBs. This can be installed after the matching
Windows SDK version is installed, from: Control Panel -> Programs and Features
* (Windows 11) SDK Debugging Tools 10.0.22621.755 or higher. This version of the
Debugging tools is needed in order to support reading the large-page PDBs that
Chrome uses to allow greater-than 4 GiB PDBs. This can be installed after the
matching Windows SDK version is installed, from: Control Panel -> Programs and
Features
-> Windows Software Development Kit [version] -> Change -> Debugging Tools for
Windows. If building on ARM64 Windows then you will need to manually copy the
Debuggers\x64 directory from another machine because it does not get installed