Remove DumpWithoutCrashing call on Android
Due to the high amount of logic run in the renderer when triggering
suggestions, it seems that something in between field focus and
suggestion event is introducing some asynchronisity, which is resulting
in the form cache becoming outdated.
This CL removes the crash call on Android, which is the only place
where caching on focus can happen. This should hoever be added back
when the underlying issue is fixed.
(cherry picked from commit b98b5b9ad6
)
Bug: 40947729
Fixed: 392907891, 404187083
Change-Id: I63452bf8381d776aa4a6778f6aba2107c1172aa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6357218
Commit-Queue: Jihad Hanna <jihadghanna@google.com>
Reviewed-by: Christoph Schwering <schwering@google.com>
Auto-Submit: Jihad Hanna <jihadghanna@google.com>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1433442}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6369015
Commit-Queue: Harry Souders <harrysouders@google.com>
Reviewed-by: Jihad Hanna <jihadghanna@google.com>
Owners-Override: Harry Souders <harrysouders@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7049@{#941}
Cr-Branched-From: 2dab7846d0951a552bdc4f350dad497f986e6fed-refs/heads/main@{#1427262}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
37f9205692
commit
807b5fc0e4
@ -49,11 +49,16 @@ std::optional<FormData> SynchronousFormCache::GetOrExtractForm(
|
||||
// that it would fail again if we do it now.
|
||||
return it->second ? std::optional(*it->second) : std::nullopt;
|
||||
}
|
||||
#if !BUILDFLAG(IS_ANDROID)
|
||||
// This codepath should not be reached, as it would mean that we populated
|
||||
// the cache with wrong forms before passing it around methods. We do not
|
||||
// crash the renderer because this wouldn't break anything since we can
|
||||
// always re-extract.
|
||||
// TODO(crbug.com/40947729): This is currently disabled on Android because
|
||||
// of pending work in order to minimize renderer logic at suggestion time.
|
||||
// Add this back when the work is done.
|
||||
base::debug::DumpWithoutCrashing(FROM_HERE);
|
||||
#endif // !BUILDFLAG(IS_ANDROID)
|
||||
}
|
||||
return form_util::ExtractFormData(document, form_element, field_data_manager,
|
||||
timer_state, extract_options);
|
||||
|
Reference in New Issue
Block a user