[NaCl SDK] Run browser tests with --disable-component-update
The PNaCl installer is more aggressive right now and checks for updates on each pexe load. Disable this behavior to test the copy of PNaCl that is already built instead of downloading the "official" one. A separate CL will make this less aggressive, but it's not clear if that will be flexible enough to detect pre-built copies of PNaCl vs official copies. E.g., if it's just based on min_version vs cur_version of official copies then it will ignore the pre-built copies. Re-enable nacl_io_test. It was timing out before because of the installation delay. The installation delay is less now due to component updater timer tweaks (2 seconds), but having --disable-component-update reduces that to 0. BUG=315253 NOTRY=true (sdk only) Review URL: https://codereview.chromium.org/70633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234638 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
@ -67,10 +67,6 @@ DISABLED_TESTS = [
|
||||
# TODO(binji): figure out a way to inject the testing code without
|
||||
# modifying the example; maybe an extension?
|
||||
{'name': 'part1'},
|
||||
# TODO(binji): loading nacl_io_test.pexe on win/linux is > 40 seconds.
|
||||
# See http://crbug.com/315253
|
||||
{'name': 'nacl_io_test', 'platform': ('win', 'linux'),
|
||||
'toolchain': 'pnacl', 'config': 'Release'},
|
||||
]
|
||||
|
||||
def ValidateToolchains(toolchains):
|
||||
@ -108,6 +104,8 @@ def GetBrowserTesterCommand(desc, toolchain, config):
|
||||
# Prevent the infobar that shows up when requesting filesystem quota.
|
||||
'--browser_flag', '--unlimited-storage',
|
||||
'--enable_sockets',
|
||||
# Prevent installing a new copy of PNaCl.
|
||||
'--browser_flag', '--disable-component-update',
|
||||
]
|
||||
|
||||
args.extend(['--serving_dir', GetServingDirForProject(desc)])
|
||||
|
Reference in New Issue
Block a user